RFR: 8232084: HotSpot build failed with GCC 9.2.1

2019-10-09 Thread Yasumasa Suenaga
Hi all, Please review this change: JBS: https://bugs.openjdk.java.net/browse/JDK-8232084 webrev: http://cr.openjdk.java.net/~ysuenaga/JDK-8232084/webrev.00/ I tried to build OpenJDK on Fedora 30 x64 with GCC 9.2.1, but it was failed in macroAssembler_x86.hpp and diagnosticArgument.cpp .

Re: RFR: 8227231: JDWP help information shows use of obsolete Xdebug flag

2019-10-09 Thread serguei.spit...@oracle.com
Hi Daniil, Looks good. Thanks, Serguei On 10/9/19 15:45, Daniil Titov wrote: Please review a small fix [1] that removes references to obsolete XDebug flag from JDWP help returned by "java -Xrunjdwp:help" command. A new CSR [2] was created for these changes and needs to be reviewed. [1]

Re: RFR: 8227231: JDWP help information shows use of obsolete Xdebug flag

2019-10-09 Thread David Holmes
+1 on each Thanks, David On 10/10/2019 9:04 am, Alex Menkov wrote: LGTM I reviewed CSR as well --alex On 10/09/2019 15:45, Daniil Titov wrote: Please review a small fix [1] that removes references to obsolete XDebug flag from JDWP help returned by "java -Xrunjdwp:help" command. A new CSR

Re: RFR: 8227231: JDWP help information shows use of obsolete Xdebug flag

2019-10-09 Thread Alex Menkov
LGTM I reviewed CSR as well --alex On 10/09/2019 15:45, Daniil Titov wrote: Please review a small fix [1] that removes references to obsolete XDebug flag from JDWP help returned by "java -Xrunjdwp:help" command. A new CSR [2] was created for these changes and needs to be reviewed. [1]

RFR: 8227231: JDWP help information shows use of obsolete Xdebug flag

2019-10-09 Thread Daniil Titov
Please review a small fix [1] that removes references to obsolete XDebug flag from JDWP help returned by "java -Xrunjdwp:help" command. A new CSR [2] was created for these changes and needs to be reviewed. [1] Webrev: http://cr.openjdk.java.net/~dtitov/8227231/webrev.01/ [2] CSR:

Re: RFR(S) 8231986 [SA] Consolidate parts of the Linux and MacOSX versions of ps_core.c

2019-10-09 Thread Chris Plummer
Ok. Good to go then. Chris On 10/9/19 2:03 PM, Ioi Lam wrote: Hi Chris, Thanks for the review. I moved the declaration of n and m to inside the "if" block. For ps_pread vs ps_pdread, I am not sure why the symbol is different on mac vs linux. Maybe the purpose is to avoid conflicting with

Re: RFR(S) 8231986 [SA] Consolidate parts of the Linux and MacOSX versions of ps_core.c

2019-10-09 Thread Ioi Lam
Hi Chris, Thanks for the review. I moved the declaration of n and m to inside the "if" block. For ps_pread vs ps_pdread, I am not sure why the symbol is different on mac vs linux. Maybe the purpose is to avoid conflicting with built-in symbols on the platform? Since this function is used by

RE: RFR: 8232056: GetOwnedMonitorInfoWithEATest.java fails with ZGC: Heap too small

2019-10-09 Thread Reingruber, Richard
> I kept the 128M That's good. Cheers, Richard. -Original Message- From: Per Liden Sent: Wednesday, October 9, 2019 8:24 PM To: Reingruber, Richard ; hotspot-compiler-dev Cc: serviceability-dev@openjdk.java.net Subject: Re: RFR: 8232056: GetOwnedMonitorInfoWithEATest.java fails

Re: RFR(S) 8231986 [SA] Consolidate parts of the Linux and MacOSX versions of ps_core.c

2019-10-09 Thread serguei.spit...@oracle.com
Hi Ioi, It looks good to me - nice consolidation. Thanks, Serguei On 10/7/19 23:37, Ioi Lam wrote: https://bugs.openjdk.java.net/browse/JDK-8231986 http://cr.openjdk.java.net/~iklam/jdk14/8231986-consolidate-ps-core.v01/ One of my upcoming CDS changes (JDK-8231610) would affect the

Re: RFR(S) 8231986 [SA] Consolidate parts of the Linux and MacOSX versions of ps_core.c

2019-10-09 Thread Chris Plummer
Hi Ioi, Overall the changes look fine. A couple of minor things: Any reason not to fix the ps_pread/ps_pdread naming issue rather than just map it with a #define? In init_classsharing_workaround(), I think the "n" and "m" declarations should be inside the "if" block. thanks, Chris On

Re: RFR: 8232056: GetOwnedMonitorInfoWithEATest.java fails with ZGC: Heap too small

2019-10-09 Thread Per Liden
Thanks for reviewing, Richard. I kept the 128M, since that was what I ran through testing, and I'd like to push this as soon as possible since it's causing noise in our CI. If someone wants to remove the -Xmx128M, feel free to file a follow up. However, note that the test might then consume

Re: RFR: 8232056: GetOwnedMonitorInfoWithEATest.java fails with ZGC: Heap too small

2019-10-09 Thread Per Liden
Thanks for reviewing, David! /Per On 10/9/19 3:53 PM, David Holmes wrote: Hi Per, Thanks for fixing this one. On 9/10/2019 11:19 pm, Per Liden wrote: The newly added: GetOwnedMonitorInfoWithEATest.java GetOwnedMonitorStackDepthInfoWithEATest.java fail when run with ZGC as they set -Xmx to

Re: RFR (M): 8231595 [TEST] develop a test case for SuspendThreadList including current thread

2019-10-09 Thread serguei.spit...@oracle.com
Thanks, Chris! Serguei On 10/9/19 10:14, Chris Plummer wrote: Hi Serguei, It's ok to push. thanks, Chris On 10/8/19 10:47 PM, serguei.spit...@oracle.com wrote:

Re: RFR (M): 8231595 [TEST] develop a test case for SuspendThreadList including current thread

2019-10-09 Thread Chris Plummer
Hi Serguei, It's ok to push. thanks, Chris On 10/8/19 10:47 PM, serguei.spit...@oracle.com wrote: Hi Chris, Please, let me know if you have more thoughts on this or it is okay to push as

Re: RFR: JDK-8199136: Dead code in src/jdk.jcmd/share/classes/sun/tools/common/ProcessArgumentMatcher.java

2019-10-09 Thread Evgeny Mandrikov
On Tue, Oct 8, 2019 at 12:52 AM Daniil Titov wrote: > I will sponsor this change. > On Tue, Oct 8, 2019 at 1:01 AM serguei.spit...@oracle.com < serguei.spit...@oracle.com> wrote: > Looks good. > On Wed, Oct 9, 2019 at 12:20 AM Daniil Titov wrote: > I pushed the changes. > > The changeset:

RE: RFR: 8232056: GetOwnedMonitorInfoWithEATest.java fails with ZGC: Heap too small

2019-10-09 Thread Reingruber, Richard
Hi Per, Sorry about the problem. Your change looks good to me, I'm not a reviewer though. Alternatively you can just remove the lines that set -Xmx (and -Xms). The lines are not needed in these tests (copied from other tests). I've tried that successfully just now. Thanks, Richard.

Re: RFR: 8232056: GetOwnedMonitorInfoWithEATest.java fails with ZGC: Heap too small

2019-10-09 Thread David Holmes
Hi Per, Thanks for fixing this one. On 9/10/2019 11:19 pm, Per Liden wrote: The newly added: GetOwnedMonitorInfoWithEATest.java GetOwnedMonitorStackDepthInfoWithEATest.java fail when run with ZGC as they set -Xmx to 32M which is too. Bumping to 128m. Seems okay. I can't see any specific

RFR: 8232056: GetOwnedMonitorInfoWithEATest.java fails with ZGC: Heap too small

2019-10-09 Thread Per Liden
The newly added: GetOwnedMonitorInfoWithEATest.java GetOwnedMonitorStackDepthInfoWithEATest.java fail when run with ZGC as they set -Xmx to 32M which is too. Bumping to 128m. Bug: https://bugs.openjdk.java.net/browse/JDK-8232056 Webrev: http://cr.openjdk.java.net/~pliden/8232056/webrev.0