RFR: 8233549: Thread interrupted state must only be accessed when not in a safepoint-safe state

2019-11-11 Thread David Holmes
webrev: http://cr.openjdk.java.net/~dholmes/8233549/webrev/ bug: https://bugs.openjdk.java.net/browse/JDK-8233549 In JDK-8229516 I moved the interrupted state of a thread from the osThread in the VM to the java.lang.Thread instance. In doing that I overlooked a critical aspect, which is that

RFC 8233915: JVMTI FollowReferences: Java Heap Leak not found because of C2 Scalar Replacement

2019-11-11 Thread Reingruber, Richard
Hi, I have created https://bugs.openjdk.java.net/browse/JDK-8233915 In short, a set of live objects L is not found using JVMTI FollowReferences() if L is only reachable from a scalar replaced object in a frame of a C2 compiled method. If L happens to be a growing leak, then a dynamically

Re: RFR: JDK-8215196: [Graal] vmTestbase/nsk/jvmti/PopFrame/popframe003/TestDescription.java fails with "changes for the arguments of the popped frame's method, did not remain current argument values"

2019-11-11 Thread serguei.spit...@oracle.com
Hi Alex, The fix itself looks Okay. Minor: replace in the comment: "compiler don't drop" => "compiler doesn't drop". However, we still have to reach a consensus on how we treat this issue (as Chris already commented).

Re: RFR: JDK-8215196: [Graal] vmTestbase/nsk/jvmti/PopFrame/popframe003/TestDescription.java fails with "changes for the arguments of the popped frame's method, did not remain current argument values"

2019-11-11 Thread serguei.spit...@oracle.com
On 11/11/19 03:06, serguei.spit...@oracle.com wrote: Hi Chris, On 11/8/19 16:55, Chris Plummer wrote: Hi Alex, Comments below: On 11/8/19 4:39 PM, Alex Menkov wrote: On 11/08/2019 15:22, Alex Menkov wrote: Hi all, Please review the fix for

Re: RFR: JDK-8215196: [Graal] vmTestbase/nsk/jvmti/PopFrame/popframe003/TestDescription.java fails with "changes for the arguments of the popped frame's method, did not remain current argument values"

2019-11-11 Thread serguei.spit...@oracle.com
Hi Chris, On 11/8/19 16:55, Chris Plummer wrote: Hi Alex, Comments below: On 11/8/19 4:39 PM, Alex Menkov wrote: On 11/08/2019 15:22, Alex Menkov wrote: Hi all, Please review the fix for https://bugs.openjdk.java.net/browse/JDK-8215196 webrev:

Re: RFR (XS) 8233790: Forward output from heap dumper to jcmd/jmap

2019-11-11 Thread serguei.spit...@oracle.com
Hi Ralf, Okay, thanks! Serguei On 11/11/19 00:48, Schmelter, Ralf wrote: Hi Serguei, Thanks for the review. The only open question seems to be: The dumper.dump() returns int value. Returned value is not used anymore in the attachListener.cpp and diagnisticCommand.cpp. Is it still used

RE: RFR (XS) 8233790: Forward output from heap dumper to jcmd/jmap

2019-11-11 Thread Schmelter, Ralf
Hi Serguei, Thanks for the review. The only open question seems to be: > The dumper.dump() returns int value. > Returned value is not used anymore in the attachListener.cpp and > diagnisticCommand.cpp. > Is it still used somewhere else or we can replace it with void? The jmm_DumpHeap0 method