On 6/12/20 17:22, Daniel D. Daugherty wrote:
Hi Serguei,
Thanks for reviewing! I pushed the changeset just before I took a dinner
break
Great!
so I won't be able to list you as a reviewer.
Not a big deal. :)
Thanks,
Serguei
Dan
On 6/12/20 6:40 PM, serguei.spit...@oracle.com wrote:
H
Hi Serguei,
Thanks for reviewing! I pushed the changeset just before I took a dinner
break so I won't be able to list you as a reviewer.
Dan
On 6/12/20 6:40 PM, serguei.spit...@oracle.com wrote:
Hi Dan and Chris,
Problem-listing it for Xcomp only looks right to me.
Thank you for taking care
Fixed all places, updated copyright. Still need second review
http://cr.openjdk.java.net/~lmesnik/8242891/webrev.02/
Leonid
On 6/11/20 8:41 PM, serguei.spit...@oracle.com wrote:
Hi Leonid,
It is much better now.
Several places still need the same fix.
http://cr.openjdk.java.net/~lmesnik/824
Hi Dan and Chris,
Problem-listing it for Xcomp only looks right to me.
Thank you for taking care about it!
Thanks,
Serguei
On 6/12/20 14:20, Chris Plummer wrote:
On 6/12/20 1:59 PM, Daniel D. Daugherty wrote:
On 6/12/20 4:48 PM, Chris Plummer wrote:
On 6/12/20 12:13 PM, Daniel D. Daugherty
On 6/12/20 5:20 PM, Chris Plummer wrote:
On 6/12/20 1:59 PM, Daniel D. Daugherty wrote:
On 6/12/20 4:48 PM, Chris Plummer wrote:
On 6/12/20 12:13 PM, Daniel D. Daugherty wrote:
On 6/12/20 2:58 PM, Chris Plummer wrote:
On 6/12/20 11:52 AM, Daniel D. Daugherty wrote:
On 6/12/20 2:49 PM, Chris
On 6/12/20 1:59 PM, Daniel D. Daugherty wrote:
On 6/12/20 4:48 PM, Chris Plummer wrote:
On 6/12/20 12:13 PM, Daniel D. Daugherty wrote:
On 6/12/20 2:58 PM, Chris Plummer wrote:
On 6/12/20 11:52 AM, Daniel D. Daugherty wrote:
On 6/12/20 2:49 PM, Chris Plummer wrote:
Hi Dan,
What's the criter
Thanks, David!
Serguei
On 6/12/20 00:27, David Holmes wrote:
On 12/06/2020 4:02 pm, serguei.spit...@oracle.com wrote:
Hi Leonid,
It looks okay to me.
> I find this whole MBean vs MXBean terminology very confusing. :)
Me too. :)
For instance, I see some references to MBeanServer (should they
On 6/12/20 4:48 PM, Chris Plummer wrote:
On 6/12/20 12:13 PM, Daniel D. Daugherty wrote:
On 6/12/20 2:58 PM, Chris Plummer wrote:
On 6/12/20 11:52 AM, Daniel D. Daugherty wrote:
On 6/12/20 2:49 PM, Chris Plummer wrote:
Hi Dan,
What's the criteria for "noise".
There is no specific criteria
On 6/12/20 12:13 PM, Daniel D. Daugherty wrote:
On 6/12/20 2:58 PM, Chris Plummer wrote:
On 6/12/20 11:52 AM, Daniel D. Daugherty wrote:
On 6/12/20 2:49 PM, Chris Plummer wrote:
Hi Dan,
What's the criteria for "noise".
There is no specific criteria that I'm aware of.
It popped up in today'
On 6/12/20 12:27 AM, David Holmes wrote:
No. There is no MXBeanServer.
This attempts to shed some light on everything:
https://docs.oracle.com/en/java/javase/14/docs/api/java.management/javax/management/MXBean.html
"An MXBean is a kind of MBean. An MXBean object can be registered
direct
Hi Matthias,
The change looks good to me. Probably it also makes sense to remove method
getHostConfiguredCpuCount0() since it is no longer used.
Thanks,
Daniil
On 6/12/20, 8:25 AM, "Baesken, Matthias" wrote:
Hello, please review the following change .
We have a Linux machine
On 6/12/20 2:58 PM, Chris Plummer wrote:
On 6/12/20 11:52 AM, Daniel D. Daugherty wrote:
On 6/12/20 2:49 PM, Chris Plummer wrote:
Hi Dan,
What's the criteria for "noise".
There is no specific criteria that I'm aware of.
It popped up in today's JDK15 testing so it got on my radar (again).
On 6/12/20 11:52 AM, Daniel D. Daugherty wrote:
On 6/12/20 2:49 PM, Chris Plummer wrote:
Hi Dan,
What's the criteria for "noise".
There is no specific criteria that I'm aware of.
It popped up in today's JDK15 testing so it got on my radar (again).
I don't consider the failures for this tes
Yumin,
Thanks for the review!
Dan
On 6/12/20 2:51 PM, Yumin Qi wrote:
Hi, Dan
Looks good to me and it is trivial.
Thanks
Yumin
On 6/12/20 11:40 AM, Daniel D. Daugherty wrote:
Tap, tap, tap... is this thing working?
Anyone out there? This is a trivial 1-liner review...
Dan
On 6/12/
On 6/12/20 2:49 PM, Chris Plummer wrote:
Hi Dan,
What's the criteria for "noise".
There is no specific criteria that I'm aware of.
It popped up in today's JDK15 testing so it got on my radar (again).
I don't consider the failures for this test as noisy. I only see 3 in
mach5 CI testing for
Hi Dan,
What's the criteria for "noise". I don't consider the failures for this
test as noisy. I only see 3 in mach5 CI testing for all of JDK 15. JDK
14 does appear to have been somewhat noisy, possibly enough so that it
looks like maybe something changed to reduce the number of failures in
Hi, Dan
Looks good to me and it is trivial.
Thanks
Yumin
On 6/12/20 11:40 AM, Daniel D. Daugherty wrote:
Tap, tap, tap... is this thing working?
Anyone out there? This is a trivial 1-liner review...
Dan
On 6/12/20 12:46 PM, Daniel D. Daugherty wrote:
Greetings,
It's time to reduce th
Tap, tap, tap... is this thing working?
Anyone out there? This is a trivial 1-liner review...
Dan
On 6/12/20 12:46 PM, Daniel D. Daugherty wrote:
Greetings,
It's time to reduce the noise in the CI so I'm ProblemListing tests.
Here's the bug for failure:
JDK-8205957 setfldw001/TestDescr
Hi David and Alex,
Thank for reviewing this change.
I will push it to jdk15 repo as David suggested.
Best regards,
Daniil
On 6/11/20, 5:28 PM, "Alex Menkov" wrote:
+1
--alex
On 06/11/2020 16:51, David Holmes wrote:
> Hi Daniil,
>
> On 12/06/2020 5:56 am, Daniil Tit
Greetings,
It's time to reduce the noise in the CI so I'm ProblemListing tests.
Here's the bug for failure:
JDK-8205957 setfldw001/TestDescription.java fails with bad field value
https://bugs.openjdk.java.net/browse/JDK-8205957
and here's the bug for the ProblemListing:
JDK-824749
On 12/06/2020 4:02 pm, serguei.spit...@oracle.com wrote:
Hi Leonid,
It looks okay to me.
> I find this whole MBean vs MXBean terminology very confusing. :)
Me too. :)
For instance, I see some references to MBeanServer (should they also be
replaced with MXBeanServer?):
No. There is no MXBea
21 matches
Mail list logo
