Hi Serguei,
On 24/06/2020 3:37 pm, serguei.spit...@oracle.com wrote:
Hi Larry,
Thank you for looking at this!
On 6/23/20 21:32, Laurence Cable wrote:
should we not consider some form of depreciation here, and continue to
support non-public pre-main invocation for some time while issuing a
Hi Larry,
Thank you for looking at this!
On 6/23/20 21:32, Laurence Cable wrote:
should we not consider some form of depreciation here, and continue to
support non-public pre-main invocation for some time while issuing a
warning???
I'm not sure what form of deprecation we can use as it has
Please, hold on.
The fix does not work for a number of the jdk_instrument tests.
Thanks,
Serguei
On 6/23/20 19:05, serguei.spit...@oracle.com wrote:
Please, review a fix for:
https://bugs.openjdk.java.net/browse/JDK-8165276
CSR draft (one CSR reviewer is needed before finalizing it):
should we not consider some form of depreciation here, and continue to
support non-public pre-main invocation for some time while issuing a
warning???
while we have a sample of agents that will not be affected there may be
some agent that will fail terminally with this change
just a thought
Thank you a lot, Sundar!
Serguei
On 6/23/20 19:53, sundararajan.athijegannat...@oracle.com wrote:
Looks good
-Sundar
On 24/06/20 7:35 am, serguei.spit...@oracle.com wrote:
Please, review a fix for:
https://bugs.openjdk.java.net/browse/JDK-8165276
CSR draft (one CSR reviewer is needed
Hi Mandy,
Thank you for looking at this!
On 6/23/20 20:21, Mandy Chung wrote:
Hi Serguei,
I'm glad that you have a patch for this.
On 6/23/20 7:05 PM, serguei.spit...@oracle.com wrote:
Please, review a fix for:
https://bugs.openjdk.java.net/browse/JDK-8165276
CSR draft (one CSR reviewer
Hi Serguei,
I'm glad that you have a patch for this.
On 6/23/20 7:05 PM, serguei.spit...@oracle.com wrote:
Please, review a fix for:
https://bugs.openjdk.java.net/browse/JDK-8165276
CSR draft (one CSR reviewer is needed before finalizing it):
On 6/23/20 6:05 PM, Yasumasa Suenaga wrote:
Hi Chris,
Skillful troubleshooters who use jhsdb will aware this warnings, and
they will take other appropriate methods.
However, I'm not sure it is worth to continue to perform even if SA
cannot get register values.
For example, Linux AMD64
On 6/23/20 7:07 PM, Daniel D. Daugherty wrote:
Just one more comment on this part:
> L220: System.out.println("CurrentFrameGuess: choosing
interpreter frame: sp = " +
> L221: spFound + ", fpFound = "
+ fp + ", pcFound = " + pc);
> This debug
Looks good
-Sundar
On 24/06/20 7:35 am, serguei.spit...@oracle.com wrote:
Please, review a fix for:
https://bugs.openjdk.java.net/browse/JDK-8165276
CSR draft (one CSR reviewer is needed before finalizing it):
https://bugs.openjdk.java.net/browse/JDK-8248189
Webrev:
Just one more comment on this part:
> L220: System.out.println("CurrentFrameGuess: choosing interpreter
frame: sp = " +
> L221: spFound + ", fpFound = " +
fp + ", pcFound = " + pc);
> This debug output doesn't make sense to me:
>
> "sp
Please, review a fix for:
https://bugs.openjdk.java.net/browse/JDK-8165276
CSR draft (one CSR reviewer is needed before finalizing it):
https://bugs.openjdk.java.net/browse/JDK-8248189
Webrev:
http://cr.openjdk.java.net/~sspitsyn/webrevs/2020/instr-setAccessible.1/
The
Hi Chris,
Skillful troubleshooters who use jhsdb will aware this warnings, and they will
take other appropriate methods.
However, I'm not sure it is worth to continue to perform even if SA cannot get
register values.
For example, Linux AMD64 depends on RIP and RSP values to find top frame.
On 6/23/20 16:00, Chris Plummer wrote:
On 6/23/20 3:01 PM, serguei.spit...@oracle.com wrote:
On 6/23/20 14:57, serguei.spit...@oracle.com wrote:
Hi Chris,
+if (!env->ExceptionOccurred()) {
On 6/23/20 3:01 PM,
serguei.spit...@oracle.com wrote:
On 6/23/20 14:57, serguei.spit...@oracle.com wrote:
Hi Chris,
+if (!env->ExceptionOccurred()) {
env->ThrowNew(ex_cls, "DWARF not found");
+}
I've updated the patch to include just the fix for class initialization:
http://cr.openjdk.java.net/~iklam/jdk16/8246019-avoid-PerfClassTraceTime.v02/
Hopefully this part is non-controversial. We are unlikely to make
call_class_initializer(THREAD) any slower when there's no , so I
didn't add
On 6/23/20 14:57,
serguei.spit...@oracle.com wrote:
Hi Chris,
+if (!env->ExceptionOccurred()) {
env->ThrowNew(ex_cls, "DWARF not found");
+}
Should the !env->ExceptionOccurred() be
replaced with
Hi Chris,
+if (!env->ExceptionOccurred()) {
env->ThrowNew(ex_cls, "DWARF not found");
+}
Should the !env->ExceptionOccurred() be
replaced with env->ExceptionOccurred()
?
Thanks,
Serguei
On
Hi Chris,
LGTM.
--alex
On 06/23/2020 11:38, Chris Plummer wrote:
Hello,
Please review the following:
https://bugs.openjdk.java.net/browse/JDK-8247730
http://cr.openjdk.java.net/~cjplummer/8247730/webrev.00/
There are two locations were we make a JNI call with the possibility of
a pending
On 6/18/20 8:54 PM, Chris Plummer wrote:
[I've added runtime-dev to this SA review since understanding
interpreter invokes (code generated by
TemplateInterpreterGenerator::generate_normal_entry()) and stack
walking is probably more important than understanding SA.]
Hello,
Please help review
Hello,
Please review the following:
https://bugs.openjdk.java.net/browse/JDK-8247730
http://cr.openjdk.java.net/~cjplummer/8247730/webrev.00/
There are two locations were we make a JNI call with the possibility of
a pending exception. This is new code in JDK 15, so it is being
addressed
Ping!
If this fix is too complicated, there is a simplification I can make,
but at the cost of abandoning some attempts to determine the current
frame when this error condition pops up. At the start of
validateInterpreterFrame() it attempts to verify that the frame is valid
by verifying that
On 6/20/20 12:53 AM, Yasumasa Suenaga wrote:
Hi Chris,
On 2020/06/20 15:20, Chris Plummer wrote:
Hi Yasumasa,
ptrace is not used for core files, so the EFAULT for a bad core file
is not a possibility. However, get_lwp_regs() does redirect to
core_get_lwp_regs() for core files. It can fail,
23 matches
Mail list logo
