Re: RFR: 8242428: JVMTI thread operations should use Thread-Local Handshake

Hi Serguei, Thanks for your comment! I will fix them after JDK-8248379. Yasumasa On 2020/06/26 13:48, serguei.spit...@oracle.com wrote: Hi Yasumasa, I agree with the approach to separate this into different bugs. At least, it would be nice to separate the stack trace functions. It will help

Re: RFR: 8242428: JVMTI thread operations should use Thread-Local Handshake

Hi Yasumasa, I agree with the approach to separate this into different bugs. At least, it would be nice to separate the stack trace functions. It will help to better focus on each fix and improve review quality. I'd wait for new webrevs from yo

Re: RFR: 8242428: JVMTI thread operations should use Thread-Local Handshake

Hi David, We can get the result from result() in their Closures. JVMTI_ERROR_THREAD_NOT_ALIVE is set by default in GetCurrentContendedMonitorClosure, so we can get this error if the handshake is not completed. Should I check result of execute_direct() even if that? (Of course, we should fix G

Re: RFR: 8242428: JVMTI thread operations should use Thread-Local Handshake

On 26/06/2020 11:31 am, Yasumasa Suenaga wrote: On 2020/06/25 21:48, David Holmes wrote: You are not checking the return value of Handshake::execute_direct and so are missing the possibility that the target thread has terminated before you got to do the operation on it. It isn't clear to me

RFR (Preliminary): 8248194: Need better support for running SA tests on core files

Hello, Please help with a preliminary review of changes to add better support for writing SA tests that work on core files: https://bugs.openjdk.java.net/browse/JDK-8248194 http://cr.openjdk.java.net/~cjplummer/8248194/webrev.00/index.html As pointed out, this is a preliminary review. I suspe

Re: RFR: 8242428: JVMTI thread operations should use Thread-Local Handshake

Hi David, On 2020/06/25 21:48, David Holmes wrote: Hi Yasumasa, On 25/06/2020 6:24 pm, Yasumasa Suenaga wrote: Hi David, Thanks for your comment! On 2020/06/25 14:17, David Holmes wrote: Hi Yasumasa, Thanks for tackling this. I've had an initial look at it and have a few concerns. On 24/

Re: RFR(T): 8248354: ProblemList vmTestbase/nsk/jdi/stress/serial/mixed002/TestDescription.java

Looks good. This a new failure as of June 2nd and has failed quite a bit the past 3 weeks or so. Chris On 6/25/20 2:22 PM, Daniel D. Daugherty wrote: Greetings, I'm doing another round of reduce-the-noise in the CI in preparation for the upcoming weekend... So I have another trivial review...

Re: RFR(T): 8248351: ProblemList serviceability/jvmti/ModuleAwareAgents/ThreadStart/MAAThreadStart.java on Windows

Thanks Igor!! Dan On 6/25/20 6:27 PM, Igor Ignatyev wrote: LGTM, -- Igor On Jun 25, 2020, at 1:44 PM, Daniel D. Daugherty wrote: Greetings, I'm doing another round of reduce-the-noise in the CI in preparation for the upcoming weekend... So I have another trivial review... Here's the bu

Re: RFR(T): 8248351: ProblemList serviceability/jvmti/ModuleAwareAgents/ThreadStart/MAAThreadStart.java on Windows

LGTM, -- Igor > On Jun 25, 2020, at 1:44 PM, Daniel D. Daugherty > wrote: > > Greetings, > > I'm doing another round of reduce-the-noise in the CI in preparation > for the upcoming weekend... So I have another trivial review... > > Here's the bug for the failures: > > JDK-8225354 > ser

Re: RFR(T): 8248351: ProblemList serviceability/jvmti/ModuleAwareAgents/ThreadStart/MAAThreadStart.java on Windows

Any takers? This is a trivial one liner for a single platform here... Dan On 6/25/20 4:44 PM, Daniel D. Daugherty wrote: Greetings, I'm doing another round of reduce-the-noise in the CI in preparation for the upcoming weekend... So I have another trivial review... Here's the bug for the fai

Re: RFR(T): 8248354: ProblemList vmTestbase/nsk/jdi/stress/serial/mixed002/TestDescription.java

Thanks for the fast review! Dan On 6/25/20 5:50 PM, Chris Plummer wrote: Looks good. This a new failure as of June 2nd and has failed quite a bit the past 3 weeks or so. Chris On 6/25/20 2:22 PM, Daniel D. Daugherty wrote: Greetings, I'm doing another round of reduce-the-noise in the CI i

RFR(T): 8248354: ProblemList vmTestbase/nsk/jdi/stress/serial/mixed002/TestDescription.java

Greetings, I'm doing another round of reduce-the-noise in the CI in preparation for the upcoming weekend... So I have another trivial review... Here's the bug for the failures:     JDK-8246493 JDI stress/serial/mixed002 "nsk.share.TestBug: There are more than one(2)     instance o

Re: RFR(M): 8244383: jhsdb/HeapDumpTestWithActiveProcess.java fails with "AssertionFailure: illegal bci"

Ping #2. I still need one more reviewer (Thanks for the review, Dan). I updated the webrev based on Dan's comments: http://cr.openjdk.java.net/~cjplummer/8244383/webrev.01/ I can still make the simplification mentioned below if necessary. thanks, Chris On 6/23/20 11:29 AM, Chris Plummer wrot

RFR(T): 8248351: ProblemList serviceability/jvmti/ModuleAwareAgents/ThreadStart/MAAThreadStart.java on Windows

Greetings, I'm doing another round of reduce-the-noise in the CI in preparation for the upcoming weekend... So I have another trivial review... Here's the bug for the failures:     JDK-8225354 serviceability/jvmti/ModuleAwareAgents/ThreadStart/MAAThreadStart.java     failed with Di

Re: RFR (S) 8247615: Initialize the bytes left for the heap sampler

A typo: inital --- I would think you might get a few samples, so maybe check sampledEvents > numThreads/2 or am I misunderstanding? +int sampledEvents = HeapMonitor.sampledEvents(); +if (sampledEvents > 0) { + throw new RuntimeException( + "Sampling the inital allocation

Re: RFR(S): 8247533: SA stack walking sometimes fails with sun.jvm.hotspot.debugger.DebuggerException: get_thread_regs failed for a lwp

Ping. I still need one more review for this. There was one updated webev. I list it below so you don't need to dig it up in the long email thread: I've  updated with webrev based on the new finding that a JavaThread cannot be on the ThreadList after its OS thread has been destroyed since the Ja

Re: RFR(T): 8248341: ProblemList java/lang/management/ThreadMXBean/ThreadMXBeanStateTest.java

Igor, Thanks for the fast review! Dan On 6/25/20 1:45 PM, Igor Ignatyev wrote: Hi Dan, LGTM -- Igor On Jun 25, 2020, at 10:34 AM, Daniel D. Daugherty wrote: Greetings, I'm doing another round of reduce-the-noise in the CI in preparation for the upcoming weekend... So I have another tr

Re: RFR (S) 8247615: Initialize the bytes left for the heap sampler

Hi Jc, It looks good. Thank you for fixing it! Thanks, Serguei On 6/25/20 11:03, Jean Christophe Beyler wrote: Hi all! I hope you are all doing well! I have a sma

Re: RFR(T) 8203005: The top-of-stack type specified for nofast_* bytecodes are wrong

Thanks Dan for the review! On 6/25/20 12:17 PM, Daniel D. Daugherty wrote: On 6/25/20 1:33 PM, Yumin Qi wrote: Hi, please review the tiny changes for bug: https://bugs.openjdk.java.net/browse/JDK-8203005 webrev:http://cr.openjdk.java.net/~minqi/2020/8203005/webrev-00/ src/hotspot/share/int

Re: RFR(T) 8203005: The top-of-stack type specified for nofast_* bytecodes are wrong

On 6/25/20 1:33 PM, Yumin Qi wrote: Hi, please review the tiny changes for bug: https://bugs.openjdk.java.net/browse/JDK-8203005 webrev:http://cr.openjdk.java.net/~minqi/2020/8203005/webrev-00/ src/hotspot/share/interpreter/bytecodes.cpp     No comments. src/jdk.hotspot.agent/share/classes/s

Re: RFR(T) 8203005: The top-of-stack type specified for nofast_* bytecodes are wrong

Hi, Chris   Thanks for the review! Thanks Yumin On 6/25/20 11:37 AM, Chris Plummer wrote: Nevermind. I should have looked at your full webrev. I see you already covered this. thanks, Chris On 6/25/20 11:28 AM, Chris Plummer wrote: Hi Yumin, It looks like the fix for https://bugs.openj

Re: 15 RFR(XS): 8165276: Spec states that invoke the premain method in an agent class if it's public but implementation differs

Thanks you for reviewing, Alan! I'll check if it can be fixed. Thanks, Serguei On 6/25/20 11:07, Alan Bateman wrote: On 25/06/2020 17:17, serguei.spit...@oracle.com wrote: New wevrev version is: http://cr.openjdk.java.net/~sspitsyn/webrevs/2020/instr-setAccessible.2/ One inconsistency is th

Re: RFR(T) 8203005: The top-of-stack type specified for nofast_* bytecodes are wrong

Nevermind. I should have looked at your full webrev. I see you already covered this. thanks, Chris On 6/25/20 11:28 AM, Chris Plummer wrote: Hi Yumin, It looks like the fix for https://bugs.openjdk.java.net/browse/JDK-8174995 has this same bug. What do you think? thanks, Chris On 6/25/

Re: RFR(T) 8203005: The top-of-stack type specified for nofast_* bytecodes are wrong

Hi Yumin, It looks like the fix for https://bugs.openjdk.java.net/browse/JDK-8174995 has this same bug. What do you think? thanks, Chris On 6/25/20 10:33 AM, Yumin Qi wrote: Hi, please review the tiny changes for bug: https://bugs.openjdk.java.net/browse/JDK-8203005 webrev:http://cr.open

Re: 15 RFR(XS): 8165276: Spec states that invoke the premain method in an agent class if it's public but implementation differs

On 25/06/2020 17:17, serguei.spit...@oracle.com wrote: New wevrev version is: http://cr.openjdk.java.net/~sspitsyn/webrevs/2020/instr-setAccessible.2/ One inconsistency is that it uses getDeclaredMethod to find the 2-arg premain and getMethod to find the 1-arg premain. The latter will fail if

RFR (S) 8247615: Initialize the bytes left for the heap sampler

Hi all! I hope you are all doing well! I have a small review request to fix initialization of the heap sampler's byte left variable: http://cr.openjdk.java.net/~jcbeyler/8247615/webrev.00/ The bug is here: https://bugs.openjdk.java.net/browse/JDK-8247615 Note, this passed the submit repo testin

Re: RFR: 8242891: vmTestbase/nsk/jvmti/ test should be fixed to fail early if JVMTI function return error

Ping > On Jun 12, 2020, at 4:18 PM, Leonid Mesnik wrote: > > Fixed all places, updated copyright. Still need second review > > http://cr.openjdk.java.net/~lmesnik/8242891/webrev.02/ > > Leonid > > On 6/11/20 8:41 PM, serguei.spit...@ora

Re: RFR(T): 8248341: ProblemList java/lang/management/ThreadMXBean/ThreadMXBeanStateTest.java

Hi Dan, LGTM -- Igor > On Jun 25, 2020, at 10:34 AM, Daniel D. Daugherty > wrote: > > Greetings, > > I'm doing another round of reduce-the-noise in the CI in preparation > for the upcoming weekend... So I have another trivial review... > > Here's the bug for the failures: > > JDK-82474

RFR(T): 8248341: ProblemList java/lang/management/ThreadMXBean/ThreadMXBeanStateTest.java

Greetings, I'm doing another round of reduce-the-noise in the CI in preparation for the upcoming weekend... So I have another trivial review... Here's the bug for the failures:     JDK-8247426 ThreadMXBean/ThreadMXBeanStateTest.java still times out     https://bugs.openjdk.java.net/browse/JDK-8

RFR(T) 8203005: The top-of-stack type specified for nofast_* bytecodes are wrong

Hi, please review the tiny changes for bug: https://bugs.openjdk.java.net/browse/JDK-8203005 webrev:http://cr.openjdk.java.net/~minqi/2020/8203005/webrev-00/ Summary: The change was left by 8074345(https://bugs.openjdk.java.net/browse/JDK-8074345), the types were wrongly put as T_ILLEGAL for

Re: 15 RFR(XS): 8165276: Spec states that invoke the premain method in an agent class if it's public but implementation differs

New wevrev version is:   http://cr.openjdk.java.net/~sspitsyn/webrevs/2020/instr-setAccessible.2/ Now the InstrumentationImpl.java has this new check to throw IAE with the meaningful error message: +// reject non-public premain or agent

Re: RFR: 8242428: JVMTI thread operations should use Thread-Local Handshake

Hi Yasumasa, On 25/06/2020 6:24 pm, Yasumasa Suenaga wrote: Hi David, Thanks for your comment! On 2020/06/25 14:17, David Holmes wrote: Hi Yasumasa, Thanks for tackling this. I've had an initial look at it and have a few concerns. On 24/06/2020 4:50 pm, Yasumasa Suenaga wrote: Hi all, P

Re: Java agents in paths containing unicode characters on Windows

Anyone know if the below is a known issue? Tried searching the bug database, but didn't find anything that really matched this issue. /Michael From: serviceability-dev on behalf of Michael Rasmussen Sent: 15 June 2020 13:48 To: serviceability-dev@openjdk.java.net Subject: Java agents in pat

Re: RFR: 8242428: JVMTI thread operations should use Thread-Local Handshake

Hi David, Thanks for your comment! On 2020/06/25 14:17, David Holmes wrote: Hi Yasumasa, Thanks for tackling this. I've had an initial look at it and have a few concerns. On 24/06/2020 4:50 pm, Yasumasa Suenaga wrote: Hi all, Please review this change:    JBS: https://bugs.openjdk.java.ne