RE: RFR(S) 8249293: Unsafe stackwalk in VM_GetOrSetLocal::doit_prologue()

Hi Serguei, > Sorry for the delay in reply and thank you for the update. > I like it in general. There are some minor comments though. Excellent, thanks :) I've prepared webrev.5. Webrev: http://cr.openjdk.java.net/~rrich/webrevs/8249293/webrev.5/ Delta: http://cr.openjdk.java.net/~rrich/webre

RFR(s):8251848: JMap.histo() and JMap.dump() should parse sub-arguments similarly

Dear All, Please help review the patch of 8251848, Thanks! Webrev: http://cr.openjdk.java.net/~lzang/8251848/webrev.00/ Bug: https://bugs.openjdk.java.net/browse/JDK-8251848 BRs, Lin

Re: RFR(s):8252101 Add specification of expected behavior of combining "all" and "live" options of jmap(Internet mail)

After discuss with paul, it is not a good idea to combine two fix together in one webrev. I will handle them separately Please help review the updated one. Thanks! Webrev: http://cr.openjdk.java.net/~lzang/8252101/webrev.01/ CSR: https://bugs.openjdk.java.net/browse/JDK-825210

Re: RFR: JDK-8251384: [TESTBUG] jvmti tests should not be executed with minimal VM

Hi Igor, On 08/20/2020 09:23, Igor Ignatyev wrote: HI Alex, one minor nit: according to usual java coding conventions, isJVMTIIncluded should be spelled as isJvmtiIncluded. otherwise the fix looks good to me. I tried to be consistent with other methods like isCDSIncludedInVmBuild, isJFRInclu

Re: RFR/RFA (M): 8185003: JMX: Add a version of ThreadMXBean.dumpAllThreads with a maxDepth argument

Hi Paul, I was also wondering if there is a compatibility risk involved with the JMM_VERSION change. So, thanks to Volker for asking these questions. One more question. I do not see a backport of the src/jdk.management/share/native/libm

Re: RFR: JDK-8251384: [TESTBUG] jvmti tests should not be executed with minimal VM

Hi Alex, Yes, of course, there are more tests depending on JVMTI in the vmTestbase, jdk_jdi and jdk_instrument. Just wanted to point that the test/hotspot/jtreg/compiler and test/hotspot/jtreg/runtime also have such tests. I wonder if there is any enhancement filed to cover all needs. One ques

Re: RFR: JDK-8251384: [TESTBUG] jvmti tests should not be executed with minimal VM

Hi Serguei, On 08/19/2020 20:34, serguei.spit...@oracle.com wrote: Hi Alex, It looks good to me. But there are more tests in test/hotspot/jtreg/runtime and test/hotspot/jtreg/compiler which use the Instrumentation API, and so, depend on the JVMTI. Examples are:   test/hotspot/jtreg/compil

Re: RFR/RFA (M): 8185003: JMX: Add a version of ThreadMXBean.dumpAllThreads with a maxDepth argument

On Wed, Aug 19, 2020 at 6:17 PM Hohensee, Paul wrote: > > Please review this backport to jdk8u. I especially need a CSR review, since > the CSR approval process can be a bottleneck. The patch significantly reduces > fleet profiling overhead, and a version of it has been in production at > Amazo

Re: RFR(T) : 8252005 : narrow disabling of allowSmartActionArgs in vmTestbase

thanks Serguei, pushed. -- Igor > On Aug 20, 2020, at 10:55 AM, serguei.spit...@oracle.com wrote: > > Hi Igor, > > Still looks good to me. > The webrev is very slow. > > Thanks, > Serguei > > > On 8/20/20 10:16, Igor Ignatyev wrote: >> Hi Serguei, >> >> thanks for your review. I've deci

Re: RFR(T) : 8252005 : narrow disabling of allowSmartActionArgs in vmTestbase

Hi Igor, Still looks good to me. The webrev is very slow. Thanks, Serguei On 8/20/20 10:16, Igor Ignatyev wrote: Hi Serguei, thanks for your review. I've decided to slightly modify th

Re: RFR(T) : 8252005 : narrow disabling of allowSmartActionArgs in vmTestbase

Hi Serguei, thanks for your review. I've decided to slightly modify the patch and use the ids of subtasks in TEST.properties files (instead of main bug id) in order to avoid possible confusion in the future: - incremental: http://cr.openjdk.java.net/~iignatyev//8252005/webrev.0-1/index.html <

Re: RFR: JDK-8251384: [TESTBUG] jvmti tests should not be executed with minimal VM

HI Alex, one minor nit: according to usual java coding conventions, isJVMTIIncluded should be spelled as isJvmtiIncluded. otherwise the fix looks good to me. > Other tests will be updated in the follow-ups. have you already identified all the tests which need this @requires? filed bugs/RFEs for

RFR(s):8252101 Add specification of expected behavior of combining "all" and "live" options of jmap(Internet mail)

Dear All, May I ask your help to review this change: Webrev: http://cr.openjdk.java.net/~lzang/8252101/webrev.00/ CSR: https://bugs.openjdk.java.net/browse/JDK-8252102 Bug: https://bugs.openjdk.java.net/browse/JDK-8252101 This change adds the description

Re: [Discussion] Expected behavior of combining "all" and "live" options of jmap(Internet mail)

Thanks Paul! I have filed CSR and Bug: CSR: https://bugs.openjdk.java.net/browse/JDK-8252102 Bug: https://bugs.openjdk.java.net/browse/JDK-8252101 Patch is under testing, will create RFR thread when it is ready. Thanks! Cheers, Lin On 20/08/2020 04:18, Hohensee, Paul wrote: >