On Wed, 23 Sep 2020 23:45:49 GMT, Serguei Spitsyn wrote:
>> No significant comments. All my concerns relate to naming and terminology,
>> where I think there is scope for quite a bit
>> of tidying up. Thanks.
>
> Hi Robbin,
> I've looked more at the Serviceability files.
> The fix looks good in
On Thu, 24 Sep 2020 00:38:32 GMT, Igor Ignatyev wrote:
>> test/hotspot/jtreg/vmTestbase/nsk/aod/VirtualMachineDescriptor/VirtualMachineDescriptor01/VirtualMachineDescriptor01.java
>> line 112:
>>> 110:
>>> 111: TestUtils.assertEquals(targetVMDesc.hashCode(),
>>> targetVMDesc2.hashCod
On Thu, 24 Sep 2020 04:57:39 GMT, David Holmes wrote:
>> Monica Beckwith has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Update orderAccess_windows_aarch64.hpp
>>
>> changing from Acq-reL to Sequential Consistency to avoid compiler
On Wed, 23 Sep 2020 13:23:43 GMT, Monica Beckwith wrote:
>> This is a continuation of
>> https://mail.openjdk.java.net/pipermail/aarch64-port-dev/2020-August/009566.html
>>
>> Changes since then:
>> * We've improved the write barrier as suggested by Andrew [1]
>> * The define-guards around R18
On 23/09/2020 8:11 pm, Robbin Ehn wrote:
On Wed, 23 Sep 2020 03:04:39 GMT, David Holmes wrote:
Robbin Ehn has updated the pull request incrementally with one additional
commit since the last revision:
Update after Coleen
src/hotspot/share/runtime/handshake.cpp line 63:
61: };
62:
63
On 23/09/2020 7:37 pm, Robbin Ehn wrote:
On Wed, 23 Sep 2020 02:56:00 GMT, David Holmes wrote:
Robbin Ehn has updated the pull request incrementally with one additional
commit since the last revision:
Update after Coleen
src/hotspot/share/runtime/handshake.hpp line 97:
95: }
96: b
On Wed, 23 Sep 2020 05:31:19 GMT, Aleksey Shipilev wrote:
>> the patch
>> - removes `PropertyResolvingWrapper` from `vmTestbase/nsk/aod` tests
>> - updates `AODRunnerArgParser` to remove surrounding `"` symbols from
>> `javaOpts` option values
>> - updates vmTestbase/nsk/aod test descriptions to
On Thu, 24 Sep 2020 00:23:13 GMT, Mandy Chung wrote:
>> @vicente-romero-oracle I noticed that we can also remove the preview args
>> from the record serialization tests and
>> ObjectMethodsTest. I opened a PR against the branch in your fork. You should
>> be able to just merge in the changes. S
On Wed, 23 Sep 2020 05:34:23 GMT, Aleksey Shipilev wrote:
>> the patch
>> - removes `PropertyResolvingWrapper` from `vmTestbase/nsk/aod` tests
>> - updates `AODRunnerArgParser` to remove surrounding `"` symbols from
>> `javaOpts` option values
>> - updates vmTestbase/nsk/aod test descriptions to
On 9/23/2020 5:26 PM, Mandy Chung wrote:
What is the policy of `@since` release value when a preview API
becomes final.I would expect `@since` should be updated from 14
to 16 because 16 is the Java SE release these APIs are added??
Yes. Per
http://openjdk.java.net/jeps/12#Specifications-of
On Tue, 22 Sep 2020 09:49:12 GMT, Chris Hegarty wrote:
>> note: I have removed from the original patch the code related to
>> javax.lang.model, I will publish them in a separate PR
>
> @vicente-romero-oracle I noticed that we can also remove the preview args
> from the record serialization test
On Wed, 23 Sep 2020 04:10:36 GMT, David Holmes wrote:
>> Robbin Ehn has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Update after Coleen
>
> No significant comments. All my concerns relate to naming and terminology,
> where I think there
On Tue, 22 Sep 2020 22:51:13 GMT, Alex Menkov wrote:
> This is subtask which covers test in hotspot/jtreg except
> test/hotspot/jtreg/vmTestbase/nsk/jvmti (there is a separate
> issue for it: JDK-8253371)
> In most tests just "@requires vm.jvmti" is added,
> in several test '@requires vm.flavor
On Tue, 22 Sep 2020 23:35:22 GMT, Serguei Spitsyn wrote:
>
> Did you test it in minimal config?
Sure. The updated tests are skipped with minimal VM
-
PR: https://git.openjdk.java.net/jdk/pull/314
On Tue, 22 Sep 2020 23:36:04 GMT, Ioi Lam wrote:
>> This is subtask which covers test in hotspot/jtreg except
>> test/hotspot/jtreg/vmTestbase/nsk/jvmti (there is a separate
>> issue for it: JDK-8253371)
>> In most tests just "@requires vm.jvmti" is added,
>> in several test '@requires vm.flavor
On Wed, 23 Sep 2020 14:27:55 GMT, Stefan Karlsson wrote:
>> Erik Österlund has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Review: SteafanK CR 2
>
> Marked as reviewed by stefank (Reviewer).
Given names like `StackWatermarkSet::lowest_w
On Wed, 23 Sep 2020 13:57:11 GMT, Erik Österlund wrote:
>> This PR the implementation of "JEP 376: ZGC: Concurrent Thread-Stack
>> Processing" (cf.
>> https://openjdk.java.net/jeps/376).
>> Basically, this patch modifies the epilog safepoint when returning from a
>> frame (supporting interprete
On Wed, 23 Sep 2020 12:59:40 GMT, Erik Österlund wrote:
>> src/hotspot/share/runtime/stackWatermarkSet.cpp line 112:
>>
>>> 110: return;
>>> 111: }
>>> 112: verify_poll_context();
>>
>> There's a verfy_poll_context here, but no update_poll_values call. I guess
>> this is because we cou
> This PR the implementation of "JEP 376: ZGC: Concurrent Thread-Stack
> Processing" (cf.
> https://openjdk.java.net/jeps/376).
> Basically, this patch modifies the epilog safepoint when returning from a
> frame (supporting interpreter frames, c1, c2,
> and native wrapper frames), to compare the
On Wed, 23 Sep 2020 10:27:05 GMT, Stefan Karlsson wrote:
>> Erik Österlund has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Review: SteafanK CR 2
>
> I've gone over the entire patch, but I'm leaving the compiler parts to others
> to revi
On Wed, 23 Sep 2020 08:33:20 GMT, Erik Österlund wrote:
>> src/hotspot/share/compiler/oopMap.cpp line 243:
>>
>>> 241: } else {
>>> 242: all_do(fr, reg_map, f, process_derived_oop, &do_nothing_cl);
>>> 243: }
>>
>> I wonder if we shouldn't hide the StackWatermarkSet in the GC code, and
> This PR the implementation of "JEP 376: ZGC: Concurrent Thread-Stack
> Processing" (cf.
> https://openjdk.java.net/jeps/376).
> Basically, this patch modifies the epilog safepoint when returning from a
> frame (supporting interpreter frames, c1, c2,
> and native wrapper frames), to compare the
On Mon, 21 Sep 2020 14:47:15 GMT, Bernhard Urban-Forster
wrote:
>>> _Mailing list message from [Andrew Haley](mailto:a...@redhat.com) on
>>> [build-dev](mailto:build-...@openjdk.java.net):_
>>>
>>> On 18/09/2020 11:14, Monica Beckwith wrote:
>>>
>>> > This is a continuation of
>>> > https://
> This is a continuation of
> https://mail.openjdk.java.net/pipermail/aarch64-port-dev/2020-August/009566.html
>
> Changes since then:
> * We've improved the write barrier as suggested by Andrew [1]
> * The define-guards around R18 have been changed to `R18_RESERVED`. This will
> be enabled for
On Wed, 23 Sep 2020 12:50:51 GMT, Erik Österlund wrote:
>> src/hotspot/share/gc/z/zDriver.cpp line 108:
>>
>>> 106: return false;
>>> 107: }
>>> 108:
>>
>> Group needs_inactive_gc_locker, skip_thread_oop_barriers, and
>> allow_coalesced_vm_operations together?
>>
>> Add a comment about
On Wed, 23 Sep 2020 08:51:08 GMT, Stefan Karlsson wrote:
>> This PR the implementation of "JEP 376: ZGC: Concurrent Thread-Stack
>> Processing" (cf.
>> https://openjdk.java.net/jeps/376).
>> Basically, this patch modifies the epilog safepoint when returning from a
>> frame (supporting interpret
On Wed, 23 Sep 2020 07:39:55 GMT, Stefan Karlsson wrote:
>> This PR the implementation of "JEP 376: ZGC: Concurrent Thread-Stack
>> Processing" (cf.
>> https://openjdk.java.net/jeps/376).
>> Basically, this patch modifies the epilog safepoint when returning from a
>> frame (supporting interpret
On Wed, 23 Sep 2020 07:17:31 GMT, Stefan Karlsson wrote:
>> This PR the implementation of "JEP 376: ZGC: Concurrent Thread-Stack
>> Processing" (cf.
>> https://openjdk.java.net/jeps/376).
>> Basically, this patch modifies the epilog safepoint when returning from a
>> frame (supporting interpret
> This patch implements asynchronous handshake, which changes how handshakes
> works by default. Asynchronous handshakes
> are target only executed, which they may never be executed. (target may block
> on socket for the rest of VM lifetime)
> Since we have several use-cases for them we can have
> This patch implements asynchronous handshake, which changes how handshakes
> works by default. Asynchronous handshakes
> are target only executed, which they may never be executed. (target may block
> on socket for the rest of VM lifetime)
> Since we have several use-cases for them we can have
On Wed, 23 Sep 2020 04:06:46 GMT, David Holmes wrote:
>> Robbin Ehn has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Update after Coleen
>
> src/hotspot/share/utilities/filterQueue.hpp line 56:
>
>> 54: }
>> 55:
>> 56: // MT-safe
>
On Wed, 23 Sep 2020 03:20:02 GMT, David Holmes wrote:
>> Robbin Ehn has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Update after Coleen
>
> src/hotspot/share/runtime/handshake.cpp line 244:
>
>> 242: // A new thread on the Threa
On Tue, 22 Sep 2020 11:43:41 GMT, Erik Österlund wrote:
> This PR the implementation of "JEP 376: ZGC: Concurrent Thread-Stack
> Processing" (cf.
> https://openjdk.java.net/jeps/376).
> Basically, this patch modifies the epilog safepoint when returning from a
> frame (supporting interpreter fra
On Wed, 23 Sep 2020 04:03:30 GMT, David Holmes wrote:
>> Robbin Ehn has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Update after Coleen
>
> src/hotspot/share/utilities/filterQueue.hpp line 32:
>
>> 30:
>> 31: template
>> 32: class Filt
On Wed, 23 Sep 2020 03:04:39 GMT, David Holmes wrote:
>> Robbin Ehn has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Update after Coleen
>
> src/hotspot/share/runtime/handshake.cpp line 63:
>
>> 61: };
>> 62:
>> 63: class AsyncHandshakeO
On Wed, 23 Sep 2020 02:56:00 GMT, David Holmes wrote:
>> Robbin Ehn has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Update after Coleen
>
> src/hotspot/share/runtime/handshake.hpp line 97:
>
>> 95: }
>> 96: bool block_for_operation(
On Wed, 23 Sep 2020 02:54:09 GMT, David Holmes wrote:
>> Robbin Ehn has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Update after Coleen
>
> src/hotspot/share/runtime/handshake.hpp line 96:
>
>> 94: return !_queue.is_empty();
>> 95:
On Wed, 23 Sep 2020 02:45:27 GMT, David Holmes wrote:
>> Robbin Ehn has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Update after Coleen
>
> src/hotspot/share/runtime/handshake.hpp line 78:
>
>> 76: FilterQueue _queue;
>> 77: Mutex
On Wed, 23 Sep 2020 02:41:37 GMT, David Holmes wrote:
>> Robbin Ehn has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Update after Coleen
>
> src/hotspot/share/runtime/handshake.hpp line 51:
>
>> 49: virtual ~HandshakeClosure() {}
>> 50
On Wed, 23 Sep 2020 02:40:31 GMT, David Holmes wrote:
>> Robbin Ehn has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Update after Coleen
>
> src/hotspot/share/runtime/handshake.hpp line 45:
>
>> 43: // a single target/direct handshake or
On Tue, 22 Sep 2020 13:45:16 GMT, Stefan Karlsson wrote:
>> This PR the implementation of "JEP 376: ZGC: Concurrent Thread-Stack
>> Processing" (cf.
>> https://openjdk.java.net/jeps/376).
>> Basically, this patch modifies the epilog safepoint when returning from a
>> frame (supporting interpret
On Tue, 22 Sep 2020 13:17:05 GMT, Stefan Karlsson wrote:
>> This PR the implementation of "JEP 376: ZGC: Concurrent Thread-Stack
>> Processing" (cf.
>> https://openjdk.java.net/jeps/376).
>> Basically, this patch modifies the epilog safepoint when returning from a
>> frame (supporting interpret
On Tue, 22 Sep 2020 11:43:41 GMT, Erik Österlund wrote:
> This PR the implementation of "JEP 376: ZGC: Concurrent Thread-Stack
> Processing" (cf.
> https://openjdk.java.net/jeps/376).
> Basically, this patch modifies the epilog safepoint when returning from a
> frame (supporting interpreter fra
43 matches
Mail list logo
