On Tue, 10 Nov 2020 23:24:24 GMT, Daniel D. Daugherty
wrote:
>> Changes from @fisk and @dcubed-ojdk to:
>>
>> - simplify ObjectMonitor list management
>> - get rid of Type-Stable Memory (TSM)
>>
>> This change has been tested with Mach5 Tier[1-3],4,5,6,7,8; no new
>> regressions.
>> Aurora Pe
On Tue, 10 Nov 2020 21:24:25 GMT, Harold Seigel wrote:
> Please review this small change to add a cgroups keyword to tests that use
> cgroups. The fix was tested by running Mach5 container tests.
Hi Harold,
The fix looks good.
Thanks,
Serguei
-
Marked as reviewed by sspitsyn (R
On Tue, 10 Nov 2020 23:15:15 GMT, Coleen Phillimore wrote:
>> Ahhh... I think I understand your confusion. This line:
>>
>> L550: // Deferred decrement for the JT EnterI() that cancelled the async
>> deflation.
>> L551: add_to_contentions(-1);
>>
>> doesn't match up with this line:
>>
>> L36
On Tue, 10 Nov 2020 23:27:52 GMT, Daniel D. Daugherty
wrote:
>> Well since it controls async deflation, it should probably get a mention
>> since this comment on its own is not true:
>>
>> // Keep track of contention for JVM/TI and M&M queries and control async
>> deflation.
>>
>> The field
> Changes from @fisk and @dcubed-ojdk to:
>
> - simplify ObjectMonitor list management
> - get rid of Type-Stable Memory (TSM)
>
> This change has been tested with Mach5 Tier[1-3],4,5,6,7,8; no new
> regressions.
> Aurora Perf runs have also been done (DaCapo-h2, Quick Startup/Footprint,
> SPECj
On Tue, 10 Nov 2020 20:34:12 GMT, Robbin Ehn wrote:
>> Daniel D. Daugherty has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> coleenp CR - refactor common ThreadBlockInVM code block into
>> ObjectSynchronizer::chk_for_block_req().
>
> Hi,
On Tue, 10 Nov 2020 22:53:10 GMT, Daniel D. Daugherty
wrote:
>> But contentions is used for more than informing JVMTI, it's used to test
>> whether the monitor is_busy on the slow path. That's why I wanted the
>> comment to say something like your last sentence, since I spent time trying
>>
On Tue, 10 Nov 2020 22:27:06 GMT, Coleen Phillimore wrote:
>> No it is not a ref_count. We got rid of the accurate ref_count field
>> because maintaining it was too slow.
>>
>> contentions just tells you how many threads have blocked on the
>> slow-path trying to enter the monitor. The fast-path
On Tue, 10 Nov 2020 22:08:10 GMT, Coleen Phillimore wrote:
>> Done. I also did the one in
>> ObjectSynchronizer::request_deflate_idle_monitors().
>
> I like it but can you do one thing for me? Can you s/chk/check/ in the name?
I'd rather not. It is a function with six freaking parameters so
I
On Tue, 10 Nov 2020 21:25:51 GMT, Daniel D. Daugherty
wrote:
>> src/hotspot/share/runtime/objectMonitor.cpp line 551:
>>
>>> 549: if (try_set_owner_from(DEFLATER_MARKER, NULL) !=
>>> DEFLATER_MARKER) {
>>> 550: // Deferred decrement for the JT EnterI() that cancelled the
>>> asy
On Tue, 10 Nov 2020 21:12:25 GMT, Daniel D. Daugherty
wrote:
>> src/hotspot/share/runtime/monitorDeflationThread.cpp line 85:
>>
>>> 83: // visible to external suspension.
>>> 84:
>>> 85: ThreadBlockInVM tbivm(jt);
>>
>> Does this have to be a JavaThread? Could it be a non-java t
On Tue, 10 Nov 2020 21:35:43 GMT, Daniel D. Daugherty
wrote:
>> Yes that avoids it!
>
> Done. I also did the one in
> ObjectSynchronizer::request_deflate_idle_monitors().
I like it but can you do one thing for me? Can you s/chk/check/ in the name?
-
PR: https://git.openjdk.java.
On Tue, 10 Nov 2020 21:16:33 GMT, Robbin Ehn wrote:
>> So if I narrow the scope around the ThreadBlockInVM, then it would be fine?
>>
>> {
>> // Honor block request.
>> ThreadBlockInVM tbivm(self);
>> }
>>
>> I can make that change before I integrate...
>
> Yes that avoids it!
Done. I also
On Tue, 10 Nov 2020 20:57:48 GMT, Coleen Phillimore wrote:
>> Daniel D. Daugherty has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> dholmes-ora - convert inner while loop to do-while loop in
>> unlink_deflated().
>
> src/hotspot/share/run
On Tue, 10 Nov 2020 17:32:56 GMT, Coleen Phillimore wrote:
>> Daniel D. Daugherty has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> dholmes-ora - convert inner while loop to do-while loop in
>> unlink_deflated().
>
> src/hotspot/share/run
Please review this small change to add a cgroups keyword to tests that use
cgroups. The fix was tested by running Mach5 container tests.
-
Commit messages:
- 8255787: Tag container tests that use cGroups with cgroups keyword
Changes: https://git.openjdk.java.net/jdk/pull/1148/file
On Tue, 10 Nov 2020 17:05:16 GMT, Coleen Phillimore wrote:
>> Daniel D. Daugherty has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> dholmes-ora - convert inner while loop to do-while loop in
>> unlink_deflated().
>
> src/hotspot/share/run
On Tue, 10 Nov 2020 16:46:10 GMT, Coleen Phillimore wrote:
>> Daniel D. Daugherty has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> dholmes-ora - convert inner while loop to do-while loop in
>> unlink_deflated().
>
> src/hotspot/share/run
On Tue, 10 Nov 2020 21:01:21 GMT, Daniel D. Daugherty
wrote:
>> So why not use a local semaphore and wait with safepoint check instead?
>
> Sorry my preference is for Monitors instead of semaphores. Let's
> take that discussion off this PR and you can explain why you dislike
> the Monitor so muc
On Tue, 10 Nov 2020 20:55:17 GMT, Robbin Ehn wrote:
>> @fisk said we should not release the oopStorage during a safepoint
>> because that's not safe or will not be safe. I can't remember which.
>
> Yes that's why I said you can release it during deflation instead.
>
> (not saying you should do t
On Tue, 10 Nov 2020 16:41:49 GMT, Coleen Phillimore wrote:
>> Daniel D. Daugherty has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> dholmes-ora - convert inner while loop to do-while loop in
>> unlink_deflated().
>
> src/hotspot/share/oop
On Tue, 10 Nov 2020 02:35:17 GMT, Daniel D. Daugherty
wrote:
>> Changes from @fisk and @dcubed-ojdk to:
>>
>> - simplify ObjectMonitor list management
>> - get rid of Type-Stable Memory (TSM)
>>
>> This change has been tested with Mach5 Tier[1-3],4,5,6,7,8; no new
>> regressions.
>> Aurora Pe
On Tue, 10 Nov 2020 20:52:15 GMT, Robbin Ehn wrote:
>> We may still decide to do this fix (even though the _object field is now
>> weak):
>>
>> JDK-8249638 Re-instate idle monitor deflation as part of System.gc()
>> https://bugs.openjdk.java.net/browse/JDK-8249638
>>
>> and if we do, t
On Tue, 10 Nov 2020 20:45:18 GMT, Daniel D. Daugherty
wrote:
>> src/hotspot/share/runtime/monitorDeflationThread.cpp line 92:
>>
>>> 90: // We wait for GuaranteedSafepointInterval so that
>>> 91: // is_async_deflation_needed() is checked at the same interval.
>>> 92: ml.
On Tue, 10 Nov 2020 20:34:12 GMT, Robbin Ehn wrote:
>> Daniel D. Daugherty has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> coleenp CR - refactor common ThreadBlockInVM code block into
>> ObjectSynchronizer::chk_for_block_req().
>
> Hi,
On Tue, 10 Nov 2020 19:41:23 GMT, Robbin Ehn wrote:
>> Daniel D. Daugherty has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> coleenp CR - refactor common ThreadBlockInVM code block into
>> ObjectSynchronizer::chk_for_block_req().
>
> src/
On Mon, 9 Nov 2020 23:46:04 GMT, Coleen Phillimore wrote:
> This option has been removed in favor of always verifying the bytecodes in
> debug mode. Tested with tier1-3.
This pull request has now been integrated.
Changeset: 7d4e86be
Author:Coleen Phillimore
URL: https://git.openjdk
On Tue, 10 Nov 2020 20:09:06 GMT, Serguei Spitsyn wrote:
>> This option has been removed in favor of always verifying the bytecodes in
>> debug mode. Tested with tier1-3.
>
> Hi Coleen,
>
> This looks good to me.
> Thank you for taking care about this flag!
>
> Thanks,
> Serguei
Thanks Dan,
On Tue, 10 Nov 2020 17:39:25 GMT, Daniel D. Daugherty
wrote:
>> Changes from @fisk and @dcubed-ojdk to:
>>
>> - simplify ObjectMonitor list management
>> - get rid of Type-Stable Memory (TSM)
>>
>> This change has been tested with Mach5 Tier[1-3],4,5,6,7,8; no new
>> regressions.
>> Aurora Pe
On Tue, 10 Nov 2020 12:04:21 GMT, Aleksey Shipilev wrote:
>> This is fork off the SizeOf JEP, JDK-8249196. There is already the entry
>> point in JDK that can use the intrinsic like this:
>> `Instrumentation.getInstanceSize`. Therefore, we can implement the C1/C2
>> intrinsic now, hook it up t
On Mon, 9 Nov 2020 23:46:04 GMT, Coleen Phillimore wrote:
> This option has been removed in favor of always verifying the bytecodes in
> debug mode. Tested with tier1-3.
Hi Coleen,
This looks good to me.
Thank you for taking care about this flag!
Thanks,
Serguei
-
Marked as rev
On Mon, 9 Nov 2020 20:23:55 GMT, Harold Seigel wrote:
>> Frederic Parain has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Fix comment
>
> Looks good!
Claes, Lois, Harold,
Thank you for your reviews and feedback.
Fred
-
PR
On Mon, 9 Nov 2020 15:43:09 GMT, Frederic Parain wrote:
> Please review this small cleanup code, removing the now unused allocation
> type from the fieldInfo structure.
>
> Tested with Mach5, tiers 1 to 3 and locally by running
> test/hotspot/jtreg/serviceability/sa tests.
>
> Thank you,
>
>
On Tue, 10 Nov 2020 15:02:31 GMT, Daniel D. Daugherty
wrote:
>> I'd rather see ThreadBlockInVM as the convention of allowing the thread to
>> block if a safepoint is requested. The calls like process_if_requested are
>> becoming alphabet soup and keep changing, so having TBIVM is better in my
On Fri, 6 Nov 2020 12:54:28 GMT, Lin Zang wrote:
> The implementation of jmap tool depends on the implementation of object
> iteration by different GC heap.
> This patch extend the BasicJMapTest to cover differet GC Heap.
I believe this would fail when some GCs are not available. For example, i
On Tue, 10 Nov 2020 14:53:34 GMT, Daniel D. Daugherty
wrote:
>> Looks very good! Thanks for picking this up and taking it all the way!
>
> @fisk - Thanks for the sanity check review. And thanks for prototyping
> this work and showing that this crazy idea could work! :-)
@coleenp - I refactored
> Changes from @fisk and @dcubed-ojdk to:
>
> - simplify ObjectMonitor list management
> - get rid of Type-Stable Memory (TSM)
>
> This change has been tested with Mach5 Tier[1-3],4,5,6,7,8; no new
> regressions.
> Aurora Perf runs have also been done (DaCapo-h2, Quick Startup/Footprint,
> SPECj
On Tue, 10 Nov 2020 14:15:02 GMT, Coleen Phillimore wrote:
>> This kind of use of ThreadBlockInVM predates this changeset so while
>> the location is new, then code style is old, very old... I'll hold off
>> changing
>> this for now.
>
> I'd rather see ThreadBlockInVM as the convention of allowi
On Tue, 10 Nov 2020 14:31:14 GMT, Erik Österlund wrote:
>> Daniel D. Daugherty has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> dholmes-ora - convert inner while loop to do-while loop in
>> unlink_deflated().
>
> Looks very good! Thanks
On Mon, 9 Nov 2020 23:46:04 GMT, Coleen Phillimore wrote:
> This option has been removed in favor of always verifying the bytecodes in
> debug mode. Tested with tier1-3.
Thumbs up!
Please make sure this is okay with someone on the Serviceability team.
src/hotspot/share/runtime/globals.hpp lin
On Tue, 10 Nov 2020 02:35:17 GMT, Daniel D. Daugherty
wrote:
>> Changes from @fisk and @dcubed-ojdk to:
>>
>> - simplify ObjectMonitor list management
>> - get rid of Type-Stable Memory (TSM)
>>
>> This change has been tested with Mach5 Tier[1-3],4,5,6,7,8; no new
>> regressions.
>> Aurora Pe
On Sat, 7 Nov 2020 17:17:01 GMT, Daniel D. Daugherty wrote:
>> src/hotspot/share/runtime/synchronizer.cpp line 136:
>>
>>> 134:
>>> 135: // Honor block request.
>>> 136: ThreadBlockInVM tbivm(self->as_Java_thread());
>>
>> ThreadBlockInVM is generally used to wrap blocking code, no
On Tue, 10 Nov 2020 03:28:52 GMT, David Holmes wrote:
>> Daniel D. Daugherty has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> dholmes-ora - convert inner while loop to do-while loop in
>> unlink_deflated().
>
> Marked as reviewed by dhol
On Mon, 9 Nov 2020 23:46:04 GMT, Coleen Phillimore wrote:
> This option has been removed in favor of always verifying the bytecodes in
> debug mode. Tested with tier1-3.
Looks good!
Thanks, Harold
-
Marked as reviewed by hseigel (Reviewer).
PR: https://git.openjdk.java.net/jdk/p
This option has been removed in favor of always verifying the bytecodes in
debug mode. Tested with tier1-3.
-
Commit messages:
- Fix test using option.
- 8138588: VerifyMergedCPBytecodes option cleanup needed
Changes: https://git.openjdk.java.net/jdk/pull/1137/files
Webrev: http
> This is fork off the SizeOf JEP, JDK-8249196. There is already the entry
> point in JDK that can use the intrinsic like this:
> `Instrumentation.getInstanceSize`. Therefore, we can implement the C1/C2
> intrinsic now, hook it up to `Instrumentation`, and let the tools use that
> fast path tod
On Tue, 10 Nov 2020 11:01:54 GMT, Serguei Spitsyn wrote:
> I have a question and a couple of minor suggestions on new test.
> Q: Why the value of ITERS is that big? What is the need to have this number
> of iterations?
The test verifies the answer does not change if we hit JIT compilers in that
On Sun, 8 Nov 2020 16:58:24 GMT, Phil Race wrote:
> You reference a desktop bug that discusses many, many deprecations ...
Yep. In my opinion this is a bot problem here and need other place to discuss.
> Yet you propose to fix precisely one of these.
@prrace: Not really.
The way to work with
On Mon, 9 Nov 2020 19:02:41 GMT, Aleksey Shipilev wrote:
>> Thanks for review, @kvn! I would also like a review from someone from
>> serviceability.
>
> Friendly reminder.
Hi Aleksey,
I've not looked at the compiler generated code.
The fix looks okay to me.
I have a question and a couple of mi
49 matches
Mail list logo
