On Fri, 13 Nov 2020 02:32:14 GMT, David Holmes wrote:
>> Still good.
>
> I have updated the bug report. I am not convinced the underlying issue has
> been identified.
> @sspitsyn What do you think about this ?
Hi Robbin,
I'm not sure, a conclusion about the failure mode and root cause is corre
On Thu, 12 Nov 2020 20:42:39 GMT, Daniel D. Daugherty
wrote:
>> Robbin Ehn has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Fixed comment
>
> Still good.
I have updated the bug report. I am not convinced the underlying issue has been
i
On Wed, 11 Nov 2020 16:35:50 GMT, Daniel D. Daugherty
wrote:
>> I typically use size_t for entities that can scale with the size of the
>> machine's memory, so I don't have to think about whether there are enough
>> bits. Could AvgMonitorsPerThreadEstimate be uintx instead of intx? And then
>
On Tue, 10 Nov 2020 22:28:12 GMT, Coleen Phillimore wrote:
>> It can be a future RFE, but it won't be at the top of my list of
>> things to do. There may already be an RFE for that.
>
> No, I assume it's not high priority. I'll file an RFE because someday I want
> these to be cleaned up as a pe
On Tue, 10 Nov 2020 21:08:53 GMT, Daniel D. Daugherty
wrote:
>> src/hotspot/share/runtime/globals.hpp line 750:
>>
>>> 748: product(intx, MonitorUsedDeflationThreshold, 90, EXPERIMENTAL,
>>> \
>>> 749: "Percentage of used monitors before triggering deflation (0
>>> is "
On Tue, 10 Nov 2020 20:57:00 GMT, Robbin Ehn wrote:
>> We've removed enough padding with this work already. If we
>> want to do more padding removal, then we need to use a
>> different RFE.
>
> Sure, this was more a FYI.
Filed this new RFE:
JDK-8256303 revisit ObjectMonitor padding between f
On Tue, 10 Nov 2020 21:37:40 GMT, Daniel D. Daugherty
wrote:
>> If you only need to free CHeap memory, you can do:
>>size_t deleted_count = 0;
>>ThreadBlockInVM tbivm(self);
>> for (ObjectMonitor* monitor: delete_list) {
>> delete monitor;
>> deleted_count++;
>> }
>>
On Tue, 10 Nov 2020 21:16:20 GMT, Robbin Ehn wrote:
>> Sorry my preference is for Monitors instead of semaphores. Let's
>> take that discussion off this PR and you can explain why you dislike
>> the Monitor so much and think the local semaphore is the way to go.
>
> Yes
Filed the following new R
On Thu, 12 Nov 2020 08:11:10 GMT, Robbin Ehn wrote:
>> As the stack trace in the bug shows, we cannot load classes, since we may
>> take a monitor.
>> Resulting in an unexpected result to GetCurrentContendedMonitor().
>> Trying to use some decent primitive, e.g. Wicket/Semaphore/.., without bein
> This change turns the HashTable that JVMTI uses for object tagging into a
> regular Hotspot hashtable - the one in hashtable.hpp with resizing and
> rehashing. Instead of pointing directly to oops so that GC has to walk the
> table to follow oops and then to rehash the table, this table poin
On Wed, 11 Nov 2020 11:11:25 GMT, Thomas Schatzl wrote:
> Hi all,
>
> can I get reviews for this change that removes the "Allocation of old
> generation of Java heap on alternate memory devices" functionality introduced
> with JDK 12 with
> [JDK-8202286](https://bugs.openjdk.java.net/browse
On Wed, 11 Nov 2020 15:19:05 GMT, Albert Mingkun Yang wrote:
>> Thomas Schatzl has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> ayang review
>
> A general comment for future PRs: I think it's best to isolate mechanical
> changes into the
On Wed, 11 Nov 2020 00:27:59 GMT, Serguei Spitsyn wrote:
>> Please review this small change to add a cgroups keyword to tests that use
>> cgroups. The fix was tested by running Mach5 container tests.
>
> Hi Harold,
>
> The fix looks good.
>
> Thanks,
> Serguei
Thanks Serguei!
Harold
---
On Tue, 10 Nov 2020 21:24:25 GMT, Harold Seigel wrote:
> Please review this small change to add a cgroups keyword to tests that use
> cgroups. The fix was tested by running Mach5 container tests.
This pull request has now been integrated.
Changeset: 4df8abc2
Author:Harold Seigel
URL:
On Wed, 11 Nov 2020 11:39:59 GMT, Thomas Schatzl wrote:
> Hi all,
>
> can I have reviews for this change that changes the way how archive regions
> are managed in general and specifically by the G1 collector, fixing the
> crashes caused by adding the module graph into the archive in
> [JDK-
On Wed, 11 Nov 2020 12:31:52 GMT, Thomas Schatzl wrote:
>> Hi all,
>>
>> can I have reviews for this change that changes the way how archive
>> regions are managed in general and specifically by the G1 collector, fixing
>> the crashes caused by adding the module graph into the archive in
>>
Hi all,
can I have reviews for this change that changes the way how archive regions
are managed in general and specifically by the G1 collector, fixing the crashes
caused by adding the module graph into the archive in
[JDK-8244778](https://bugs.openjdk.java.net/browse/JDK-8244778)?
Previousl
> As the stack trace in the bug shows, we cannot load classes, since we may
> take a monitor.
> Resulting in an unexpected result to GetCurrentContendedMonitor().
> Trying to use some decent primitive, e.g. Wicket/Semaphore/.., without being
> implementation dependent means we must warm up every
On Wed, 11 Nov 2020 22:55:16 GMT, Daniel D. Daugherty
wrote:
> I like the fix. Taking Wicket out of play will help with class loading
> issues in this test. You don't really need to deal with unexpected
> locking events from the ObjectLocker usage by class loading.
Great, that was my feeling al
On Thu, 12 Nov 2020 08:00:32 GMT, Robbin Ehn wrote:
>> LGTM. Thanks for finding the issue!
>>
>> Patricio
>
>> LGTM. Thanks for finding the issue!
>>
>> Patricio
>
> Thanks!
> Typo: do execute -> to execute
Thanks, fixed!
-
PR: https://git.openjdk.java.net/jdk/pull/1177
On Wed, 11 Nov 2020 22:24:11 GMT, Patricio Chilano Mateo
wrote:
> LGTM. Thanks for finding the issue!
>
> Patricio
Thanks!
-
PR: https://git.openjdk.java.net/jdk/pull/1177
On Wed, 11 Nov 2020 22:48:38 GMT, Daniel D. Daugherty
wrote:
>> As the stack trace in the bug shows, we cannot load classes, since we may
>> take a monitor.
>> Resulting in an unexpected result to GetCurrentContendedMonitor().
>> Trying to use some decent primitive, e.g. Wicket/Semaphore/.., wi
22 matches
Mail list logo
