> This PR add "gz" option to jmap -dump command to support generate gzipped
> heap dump.
>
> example:
> jmap -dump:live,gz=1,file=dump.gz
Lin Zang has updated the pull request incrementally with one additional commit
since the last revision:
fix indentation issue of BasicJmapTest.java
On Wed, 18 Nov 2020 19:55:48 GMT, Chris Plummer wrote:
> I think you need to add a test case. You can use the work done for
> JDK-8237354 dcmd as a template. See
> http://cr.openjdk.java.net/~rschmelter/webrevs/8237354/webrev.3/. I don't
> know that's it's necessary to add a test case for each
> This PR add "gz" option to jmap -dump command to support generate gzipped
> heap dump.
>
> example:
> jmap -dump:live,gz=1,file=dump.gz
Lin Zang has updated the pull request incrementally with one additional commit
since the last revision:
Add test cases
-
Changes:
-
On Wed, 18 Nov 2020 19:31:44 GMT, Serguei Spitsyn wrote:
> test/hotspot/jtreg/vmTestbase/nsk/jvmti/AttachOnDemand/attach021/attach021Agent00.cpp:
>
> The change below is not needed as the call to
> nsk_jvmti_aod_disableEventAndFinish() does exactly the same:
>
> ```
> -nsk_jvmti_aod_disabl
> This change turns the HashTable that JVMTI uses for object tagging into a
> regular Hotspot hashtable - the one in hashtable.hpp with resizing and
> rehashing. Instead of pointing directly to oops so that GC has to walk the
> table to follow oops and then to rehash the table, this table poin
On Wed, 18 Nov 2020 19:31:44 GMT, Serguei Spitsyn wrote:
> There is a double-check for _needs_cleaning, so the one at line 136 can be
> removed:
I want to leave _needs_cleaning at 136 because even though the boolean is
checked twice, it doesn't hurt performance and it has a nice symmetry in th
On Mon, 16 Nov 2020 23:10:21 GMT, Coleen Phillimore wrote:
>> This change turns the HashTable that JVMTI uses for object tagging into a
>> regular Hotspot hashtable - the one in hashtable.hpp with resizing and
>> rehashing. Instead of pointing directly to oops so that GC has to walk the
>> t
On Wed, 18 Nov 2020 19:53:42 GMT, Chris Plummer wrote:
>> Hi @plummercj,
>> For old jmap, if "gz" option is used in commandline, it prompt usage
>> info indicating that option is illegal.
>> if "gz" option is not used, the op->arg(2) will be an empty string "",
>> which is set from th
On Wed, 18 Nov 2020 10:37:43 GMT, Lin Zang wrote:
>> So I assume then that the `op->arg(2)` reference will return `NULL` when an
>> older `jmap` is used? Is that correct?
>
> Hi @plummercj,
> For old jmap, if "gz" option is used in commandline, it prompt usage
> info indicating that option
On Mon, 16 Nov 2020 23:30:25 GMT, Coleen Phillimore wrote:
>> This change turns the HashTable that JVMTI uses for object tagging into a
>> regular Hotspot hashtable - the one in hashtable.hpp with resizing and
>> rehashing. Instead of pointing directly to oops so that GC has to walk the
>> t
On Wed, 18 Nov 2020 08:41:59 GMT, Chris Plummer wrote:
>> Hi @plummercj ,
>>
>> Thanks for your explaination. I get your point.
>> The issue of JDK-8219721 was fixed by reverting the problematic change. And
>> the root cause of that issue is there is fixed limitation of number of
>> arguments
On Wed, 18 Nov 2020 04:19:51 GMT, Lin Zang wrote:
>>> And the old jmap -dump can not accept "gz" option, it fails with error
>>> message printed, no matter what jvm version it work with.
>>
>> I just want to clarify what I was referring to. I was not talking about
>> trying to use gz with the
On Wed, 11 Nov 2020 11:39:59 GMT, Thomas Schatzl wrote:
> Hi all,
>
> can I have reviews for this change that changes the way how archive regions
> are managed in general and specifically by the G1 collector, fixing the
> crashes caused by adding the module graph into the archive in
> [JDK-
On Tue, 17 Nov 2020 14:52:35 GMT, Kim Barrett wrote:
>> Thomas Schatzl has updated the pull request incrementally with two
>> additional commits since the last revision:
>>
>> - sjohanss review
>> - Remove code that "activates" dormant objects as now all active objects
>> are reachable via t
14 matches
Mail list logo
