On Wed, 16 Dec 2020 23:45:08 GMT, Patricio Chilano Mateo
wrote:
>> Hi,
>>
>> Please review the following small fix for test
>> RemovingUnixDomainSocketTest.java. As explained in the bug comments, the
>> issue is due to having two different StreamPumper objects consuming from the
>> same stde
On Wed, 16 Dec 2020 10:27:05 GMT, Yasumasa Suenaga wrote:
> `search codecache` command does not work as following:
>
> hsdb> search codecache 0x7fedbd0aec90
> java.lang.RuntimeException: Unable to deduce type of CodeBlob from address
> 0x7fedbc85e810 (expected type nmethod, RuntimeStub, Saf
On Thu, 17 Dec 2020 05:27:36 GMT, Chris Plummer wrote:
>> The error code during class redefinition might be not enough to easily
>> diagnose the problem. Some more logging might be useful to understand it. I
>> encountered this problem when redefined methods with lambda usage.
>> I run all exis
On Thu, 17 Dec 2020 00:44:18 GMT, Leonid Mesnik wrote:
> The error code during class redefinition might be not enough to easily
> diagnose the problem. Some more logging might be useful to understand it. I
> encountered this problem when redefined methods with lambda usage.
> I run all existing
On Wed, 16 Dec 2020 19:44:04 GMT, Mandy Chung wrote:
>> Mandy is correct, the bigger picture here is accessibility. Code in the
>> java.instrument module should be able to invoke the premain or agentmain
>> without needing to suppress access checks. It's a perquisite to supporting
>> the deplo
> This change have been already reviewed by Mandy, Sundar, Alan and David.
> Please, see the jdk 15 review thread:
>
> http://mail.openjdk.java.net/pipermail/serviceability-dev/2020-June/031998.html
>
> Now, the PR approval is needed.
> The push was postponed because the CSR was not approved at
> This change have been already reviewed by Mandy, Sundar, Alan and David.
> Please, see the jdk 15 review thread:
>
> http://mail.openjdk.java.net/pipermail/serviceability-dev/2020-June/031998.html
>
> Now, the PR approval is needed.
> The push was postponed because the CSR was not approved at
On Thu, 17 Dec 2020 02:48:38 GMT, Jesper Wilhelmsson
wrote:
> Merge JDK 16 -> JDK 17
This pull request has now been integrated.
Changeset: 11bd7a81
Author:Jesper Wilhelmsson
URL: https://git.openjdk.java.net/jdk/commit/11bd7a81
Stats: 882 lines in 41 files changed: 659 ins; 30 d
Merge JDK 16 -> JDK 17
-
Commit messages:
- Merge
- 8258338: Support deprecated records
- 8241353: NPE in ToolProvider.getSystemJavaCompiler
- 8255880: UI of Swing components is not redrawn after their internal state
changed
- 8257637: Update usage of "type" terminology in java.
The error code during class redefinition might be not enough to easily diagnose
the problem. Some more logging might be useful to understand it. I encountered
this problem when redefined methods with lambda usage.
I run all existing tests with enabled logging and sanity verified error
messages.
On Wed, 16 Dec 2020 01:19:43 GMT, David Holmes wrote:
>> Patricio Chilano Mateo has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> include 'VM Warning' in stderr search
>
> test/lib/jdk/test/lib/process/OutputAnalyzer.java line 43:
>
>> 41
> Hi,
>
> Please review the following small fix for test
> RemovingUnixDomainSocketTest.java. As explained in the bug comments, the
> issue is due to having two different StreamPumper objects consuming from the
> same stderr, one created by ProcessTools.startProcess() and another by
> OutputAn
On Mon, 14 Dec 2020 19:36:48 GMT, Brent Christian wrote:
> This is part of an effort in the JDK to replace archaic/non-inclusive words
> with more neutral terms (see JDK-8253315 for details).
>
> Here are the changes covering core libraries code and tests. Terms were
> changed as follows:
> 1
On Wed, 16 Dec 2020 20:08:11 GMT, Brent Christian wrote:
>> This is part of an effort in the JDK to replace archaic/non-inclusive words
>> with more neutral terms (see JDK-8253315 for details).
>>
>> Here are the changes covering core libraries code and tests. Terms were
>> changed as follows
> This is part of an effort in the JDK to replace archaic/non-inclusive words
> with more neutral terms (see JDK-8253315 for details).
>
> Here are the changes covering core libraries code and tests. Terms were
> changed as follows:
> 1. grandfathered -> legacy
> 2. blacklist -> filter or rejec
On Wed, 16 Dec 2020 07:10:41 GMT, Alan Bateman wrote:
>> Brent Christian has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> improve SERIAL_FILTER_PATTERN comment
>
> src/java.base/share/classes/java/util/Locale.java line 1649:
>
>> 1647:
On Wed, 16 Dec 2020 08:18:49 GMT, Alan Bateman wrote:
> So PR1694 is really just about aligning the spec so that the premain method
> is public. However, it does not fix the overall accessibility issue.
OK I see that JDK-5070281 changes to allow the agent class to be non-public as
the main cla
On Wed, 16 Dec 2020 07:40:18 GMT, Serguei Spitsyn wrote:
>> This change have been already reviewed by Mandy, Sundar, Alan and David.
>> Please, see the jdk 15 review thread:
>>
>> http://mail.openjdk.java.net/pipermail/serviceability-dev/2020-June/031998.html
>>
>> Now, the PR approval is nee
On Wed, 16 Dec 2020 07:40:18 GMT, Serguei Spitsyn wrote:
>> This change have been already reviewed by Mandy, Sundar, Alan and David.
>> Please, see the jdk 15 review thread:
>>
>> http://mail.openjdk.java.net/pipermail/serviceability-dev/2020-June/031998.html
>>
>> Now, the PR approval is nee
`search codecache` command does not work as following:
hsdb> search codecache 0x7fedbd0aec90
java.lang.RuntimeException: Unable to deduce type of CodeBlob from address
0x7fedbc85e810 (expected type nmethod, RuntimeStub, SafepointBlob,
DeoptimizationBlob, or ExceptionBlob)
at
jdk.hot
On Wed, 16 Dec 2020 08:11:44 GMT, Serguei Spitsyn wrote:
>> Thanks, David!
>> Yes, I was also thinking that the setAccessible has to be remained after all
>> the checks.
>
> I've pushed an update with the following changes:
> - InstrumentationImpl.java update with the process sequence suggested
On Wed, 16 Dec 2020 02:23:33 GMT, Serguei Spitsyn wrote:
>> David, thank you for catching this. I'm probably missing something here.
>> If the agent class is not public then the `m.canAccess(null)` check is not
>> passed and IAE is thrown with the message:
>> `Exception in thread "main" java.l
22 matches
Mail list logo