On Mon, 8 Feb 2021 18:49:51 GMT, Kevin Walls wrote:
> Oops, I didn't mean to suggest the comment should go entirely. It's actually
> very useful to say something here, as the way we use the dynamic field,
> setting it then fixing it up.
> Is it possible to re-add the comment in a new change?
I
> 8257234 : Add gz option to SA jmap to write a gzipped heap dump
Lin Zang has updated the pull request incrementally with one additional commit
since the last revision:
remove redundant check
-
Changes:
- all: https://git.openjdk.java.net/jdk/pull/1712/files
- new: https://g
On Sun, 7 Feb 2021 12:38:55 GMT, Hamlin Li wrote:
>> parallel -histo of jmap was added by JDK-8214535, it's better to support
>> parallel for jcmd GC.class_histogram too.
>
> Hamlin Li has updated the pull request incrementally with one additional
> commit since the last revision:
>
> improv
On Sun, 7 Feb 2021 08:31:10 GMT, Lin Zang wrote:
>> 8261131: jcmd jmap dump should not accept gz option with no value
>
> Lin Zang has updated the pull request with a new target base due to a merge
> or a rebase. The incremental webrev excludes the unrelated changes brought in
> by the merge/re
On Fri, 5 Feb 2021 21:09:37 GMT, Alex Menkov wrote:
> JDK-8258917 fixed non-java launchers ("wrong launcher" VM warning for tools).
> The fix un-problemlists RemovingUnixDomainSocketTest and changes
> serviceability tests to use
> OutputAnalyzer.stderrShouldBeEmptyIgnoreDeprecatedWarnings inste
On Mon, 8 Feb 2021 19:54:03 GMT, Harold Seigel wrote:
> Please review this small fix for JDK-8261340 to clean up deprecation
> warnings, such as the following, in the vmTestbase/nsk tests.
>
> warning: [dep-ann] deprecated item is not annotated with @Deprecated
>
> The change was tested by
On Tue, 9 Feb 2021 02:38:44 GMT, Lin Zang wrote:
>> Marked as reviewed by cjplummer (Reviewer).
>
> Thanks @plummercj @sspitsyn @YaSuenag a lot for helping review this PR again
> and again!
> I have marked it as ready for push.
Hi Lin,
Sorry for confusing you but I've not noticed a duplicati
On Mon, 8 Feb 2021 22:03:18 GMT, Chris Plummer wrote:
>> Lin Zang has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> refine code for argument parsing
>
> Marked as reviewed by cjplummer (Reviewer).
Thanks @plummercj @sspitsyn @YaSuenag a
On Mon, 8 Feb 2021 08:05:09 GMT, Lin Zang wrote:
>> 8257234 : Add gz option to SA jmap to write a gzipped heap dump
>
> Lin Zang has updated the pull request incrementally with one additional
> commit since the last revision:
>
> refine code for argument parsing
Marked as reviewed by cjplumm
On Mon, 8 Feb 2021 20:58:01 GMT, Andrey Turbanov
wrote:
>> 8080272 Refactor I/O stream copying to use
>> InputStream.transferTo/readAllBytes and Files.copy
>
> Andrey Turbanov has updated the pull request incrementally with one
> additional commit since the last revision:
>
> 8080272: Refa
On Mon, 8 Feb 2021 19:54:03 GMT, Harold Seigel wrote:
> Please review this small fix for JDK-8261340 to clean up deprecation
> warnings, such as the following, in the vmTestbase/nsk tests.
>
> warning: [dep-ann] deprecated item is not annotated with @Deprecated
>
> The change was tested by
> 8080272 Refactor I/O stream copying to use
> InputStream.transferTo/readAllBytes and Files.copy
Andrey Turbanov has updated the pull request incrementally with one additional
commit since the last revision:
8080272: Refactor I/O stream copying to use java.io.InputStream.transferTo
fix re
On Mon, 8 Feb 2021 14:38:52 GMT, Weijun Wang wrote:
>> Andrey Turbanov has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> 8080272: Refactor I/O stream copying to use java.io.InputStream.transferTo
>> revert changes in Apache Santuario
>
>
On Mon, 8 Feb 2021 16:19:17 GMT, Julia Boes wrote:
>> Andrey Turbanov has refreshed the contents of this pull request, and
>> previous commits have been removed. The incremental views will show
>> differences compared to the previous content of the PR.
>
> src/java.base/share/classes/sun/securi
On Mon, 8 Feb 2021 14:01:34 GMT, Alan Bateman wrote:
>> Andrey Turbanov has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> 8080272: Refactor I/O stream copying to use java.io.InputStream.transferTo
>> revert changes in Apache Santuario
>
Please review this small fix for JDK-8261340 to clean up deprecation warnings,
such as the following, in the vmTestbase/nsk tests.
warning: [dep-ann] deprecated item is not annotated with @Deprecated
The change was tested by running the tests locally and checking for the
warnings. It was r
On Sun, 7 Feb 2021 02:21:47 GMT, Yasumasa Suenaga wrote:
>> Looks good, I made a suggestions elsewhere in the PR about the comments at
>> line 510...
>
> @kevinjwalls Thank you for the comment!
>
>> I found the "svr4_exec_displacement() in GDB" more confusing than
>> informative, maybe this is
On Mon, 8 Feb 2021 14:40:16 GMT, Weijun Wang wrote:
>> Andrey Turbanov has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> 8080272: Refactor I/O stream copying to use java.io.InputStream.transferTo
>> revert changes in Apache Santuario
>
>
On Mon, 21 Dec 2020 08:19:08 GMT, Andrey Turbanov
wrote:
>> 8080272 Refactor I/O stream copying to use java.io.InputStream.transferTo
>
> Andrey Turbanov has refreshed the contents of this pull request, and previous
> commits have been removed. The incremental views will show differences
> co
On Mon, 21 Dec 2020 09:16:11 GMT, Andrey Turbanov
wrote:
>> 8080272 Refactor I/O stream copying to use java.io.InputStream.transferTo
>
> Andrey Turbanov has updated the pull request incrementally with one
> additional commit since the last revision:
>
> 8080272: Refactor I/O stream copying
On Mon, 21 Dec 2020 09:16:11 GMT, Andrey Turbanov
wrote:
>> 8080272 Refactor I/O stream copying to use java.io.InputStream.transferTo
>
> Andrey Turbanov has updated the pull request incrementally with one
> additional commit since the last revision:
>
> 8080272: Refactor I/O stream copying
On Fri, 5 Feb 2021 16:53:00 GMT, Coleen Phillimore wrote:
>> Please review this change to clean up warnings, such as the following, in
>> the vmTestbase tests.
>>
>> warning: [synchronization] attempt to synchronize on an instance of a
>> value-based class
>> warning: [removal] Integer(int)
On Fri, 5 Feb 2021 14:48:25 GMT, Harold Seigel wrote:
> Please review this change to clean up warnings, such as the following, in the
> vmTestbase tests.
>
> warning: [synchronization] attempt to synchronize on an instance of a
> value-based class
> warning: [removal] Integer(int) in Intege
> 8257234 : Add gz option to SA jmap to write a gzipped heap dump
Lin Zang has updated the pull request incrementally with one additional commit
since the last revision:
refine code for argument parsing
-
Changes:
- all: https://git.openjdk.java.net/jdk/pull/1712/files
- new:
24 matches
Mail list logo
