On Sun, 7 Feb 2021 02:21:47 GMT, Yasumasa Suenaga <ysuen...@openjdk.org> wrote:
>> Looks good, I made a suggestions elsewhere in the PR about the comments at >> line 510... > > @kevinjwalls Thank you for the comment! > >> I found the "svr4_exec_displacement() in GDB" more confusing than >> informative, maybe this is the same technique GDB uses... But I followed our >> dynamic_addr setting and agree with the new changes. > > I removed it in new commit. > >> An alternative comment could be this, which would also removes the >> "substract" typo (which was not yours!): > > It's my change in > [JDK-8173941](https://bugs.openjdk.java.net/browse/JDK-8173941). > I removed it too. Oops, I didn't mean to suggest the comment should go entirely. It's actually very useful to say something here, as the way we use the dynamic field, setting it then fixing it up. Is it possible to re-add the comment in a new change? ------------- PR: https://git.openjdk.java.net/jdk/pull/2366
