> Please review this PR that intents to make sealed classes a final feature in
> Java. This PR contains compiler and VM changes. In line with similar PRs,
> which has made preview features final, this one is mostly removing preview
> related comments from APIs plus options in test cases. Please
On Wed, 7 Apr 2021 00:12:11 GMT, Yasumasa Suenaga wrote:
>> `jhsdb debugd` will start RMI registry by default, but we want to prevent it
>> due to port confliction in some cases. We can control it with
>> `sun.jvm.hotspot.rmi.startRegistry` system property. However we have no way
>> to set it
On Thu, 22 Apr 2021 20:38:50 GMT, Daniel D. Daugherty
wrote:
> Serviceability Reviewers!
> When a new SA test is added, please ask if the new test has been run with ZGC.
> If it doesn't work with ZGC, then it probably needs to be added to
> ProblemList-zgc.txt
> with an entry referring to this
On Thu, 22 Apr 2021 15:59:09 GMT, Chris Plummer wrote:
> This bug was introduced by my recent changes for
> [JDK-8265028](https://bugs.openjdk.java.net/browse/JDK-8265028), which
> attempted to speed up ThreadNode lookups by not looking in the runningThreads
> list if the TLS lookup failed.
On Thu, 22 Apr 2021 17:20:43 GMT, Daniel D. Daugherty
wrote:
>> I'm updating the runtime/Thread/SuspendAtExit.java test:
>>
>> - switch from java.lang.Thread.suspend() to JVM/TI SuspendThread()
>> - switch from java.lang.Thread.resume() to JVM/TI ResumeThread()
>> - switch from counter-based
On Thu, 22 Apr 2021 21:52:20 GMT, Daniel D. Daugherty
wrote:
>> src/jdk.jdwp.agent/share/native/libjdwp/threadControl.c line 261:
>>
>>> 259: */
>>> 260: if ( node == NULL ) {
>>> 261: if (list == NULL || list == ) {
>>
>> nit - s/ )/)/
>
> In that case, this one
> This bug was introduced by my recent changes for
> [JDK-8265028](https://bugs.openjdk.java.net/browse/JDK-8265028), which
> attempted to speed up ThreadNode lookups by not looking in the runningThreads
> list if the TLS lookup failed. At the time it was thought that the thread
> could not
On Thu, 22 Apr 2021 15:59:09 GMT, Chris Plummer wrote:
> This bug was introduced by my recent changes for
> [JDK-8265028](https://bugs.openjdk.java.net/browse/JDK-8265028), which
> attempted to speed up ThreadNode lookups by not looking in the runningThreads
> list if the TLS lookup failed.
On Thu, 22 Apr 2021 20:10:43 GMT, Daniel D. Daugherty
wrote:
>> This bug was introduced by my recent changes for
>> [JDK-8265028](https://bugs.openjdk.java.net/browse/JDK-8265028), which
>> attempted to speed up ThreadNode lookups by not looking in the
>> runningThreads list if the TLS
On Fri, 16 Apr 2021 20:30:15 GMT, Rafael Winterhalter
wrote:
>> To allow agents the definition of auxiliary classes, an API is needed to
>> allow this. Currently, this is often achieved by using `sun.misc.Unsafe` or
>> `jdk.internal.misc.Unsafe` ever since the `defineClass` method was removed
On Thu, 22 Apr 2021 20:11:56 GMT, Daniel D. Daugherty
wrote:
> Do you plan to another bug to continue your investigation?
Yes. The search of runningThreads becomes a performance issue in Loom when the
list could have a million items.
> src/jdk.jdwp.agent/share/native/libjdwp/threadControl.c
On Thu, 22 Apr 2021 20:34:48 GMT, Joe Darcy wrote:
>> A trivial fix to ProblemList
>> serviceability/sa/sadebugd/DisableRegistryTest.java on ZGC.
>
> Marked as reviewed by darcy (Reviewer).
@jddarcy - Thanks for the fast review!
-
PR: https://git.openjdk.java.net/jdk/pull/3641
On Thu, 22 Apr 2021 20:32:33 GMT, Daniel D. Daugherty
wrote:
> A trivial fix to ProblemList
> serviceability/sa/sadebugd/DisableRegistryTest.java on ZGC.
This pull request has now been integrated.
Changeset: e81baead
Author:Daniel D. Daugherty
URL:
On Thu, 22 Apr 2021 20:32:33 GMT, Daniel D. Daugherty
wrote:
> A trivial fix to ProblemList
> serviceability/sa/sadebugd/DisableRegistryTest.java on ZGC.
Marked as reviewed by darcy (Reviewer).
-
PR: https://git.openjdk.java.net/jdk/pull/3641
A trivial fix to ProblemList
serviceability/sa/sadebugd/DisableRegistryTest.java on ZGC.
-
Commit messages:
- 8265786: ProblemList serviceability/sa/sadebugd/DisableRegistryTest.java on
ZGC
Changes: https://git.openjdk.java.net/jdk/pull/3641/files
Webrev:
On Wed, 7 Apr 2021 00:12:11 GMT, Yasumasa Suenaga wrote:
>> `jhsdb debugd` will start RMI registry by default, but we want to prevent it
>> due to port confliction in some cases. We can control it with
>> `sun.jvm.hotspot.rmi.startRegistry` system property. However we have no way
>> to set it
On Thu, 22 Apr 2021 15:59:09 GMT, Chris Plummer wrote:
> This bug was introduced by my recent changes for
> [JDK-8265028](https://bugs.openjdk.java.net/browse/JDK-8265028), which
> attempted to speed up ThreadNode lookups by not looking in the runningThreads
> list if the TLS lookup failed.
On Thu, 22 Apr 2021 15:59:09 GMT, Chris Plummer wrote:
> This bug was introduced by my recent changes for
> [JDK-8265028](https://bugs.openjdk.java.net/browse/JDK-8265028), which
> attempted to speed up ThreadNode lookups by not looking in the runningThreads
> list if the TLS lookup failed.
This bug was introduced by my recent changes for
[JDK-8265028](https://bugs.openjdk.java.net/browse/JDK-8265028), which
attempted to speed up ThreadNode lookups by not looking in the runningThreads
list if the TLS lookup failed. At the time it was thought that the thread could
not possibly be
On Thu, 22 Apr 2021 05:53:35 GMT, Lin Zang wrote:
>> This PR revise the help message of the `parallel=[N]` option of command
>> `jmap -histo`. It mainly comes from the discussion at
>> https://github.com/openjdk/jdk/pull/2379#issuecomment-782609582 and
>>
> I'm updating the runtime/Thread/SuspendAtExit.java test:
>
> - switch from java.lang.Thread.suspend() to JVM/TI SuspendThread()
> - switch from java.lang.Thread.resume() to JVM/TI ResumeThread()
> - switch from counter-based to time-based testing
> - improve error checking since we're now using
On Fri, 16 Apr 2021 20:30:15 GMT, Rafael Winterhalter
wrote:
>> To allow agents the definition of auxiliary classes, an API is needed to
>> allow this. Currently, this is often achieved by using `sun.misc.Unsafe` or
>> `jdk.internal.misc.Unsafe` ever since the `defineClass` method was removed
On Sun, 28 Mar 2021 07:53:31 GMT, Yasumasa Suenaga wrote:
> `jhsdb debugd` will start RMI registry by default, but we want to prevent it
> due to port confliction in some cases. We can control it with
> `sun.jvm.hotspot.rmi.startRegistry` system property. However we have no way
> to set it
On Wed, 21 Apr 2021 21:22:50 GMT, Daniel D. Daugherty
wrote:
>> I'm updating the runtime/Thread/SuspendAtExit.java test:
>>
>> - switch from java.lang.Thread.suspend() to JVM/TI SuspendThread()
>> - switch from java.lang.Thread.resume() to JVM/TI ResumeThread()
>> - switch from counter-based
On Thu, 22 Apr 2021 02:35:26 GMT, David Holmes wrote:
>> Daniel D. Daugherty has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> dholmes CR changes.
>
> test/hotspot/jtreg/runtime/Thread/SuspendAtExit.java line 38:
>
>> 36: private
On Thu, 22 Apr 2021 09:49:56 GMT, Kevin Walls wrote:
>> Yasumasa Suenaga has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Rename --disableregistry to --disable-registry
>
> Yes, I think this looks good.
> If the test ever causes problems
On Thu, 25 Mar 2021 10:56:23 GMT, Robbin Ehn wrote:
> A suspend request is done by handshaking thread target thread(s). When
> executing the handshake operation we know the target mutator thread is in a
> dormant state (as in safepoint safe state). We have a guarantee that it will
> check
On Thu, 22 Apr 2021 09:36:26 GMT, David Holmes wrote:
> Approving again for good measure. :)
Thank you!
-
PR: https://git.openjdk.java.net/jdk/pull/3191
On Wed, 7 Apr 2021 00:12:11 GMT, Yasumasa Suenaga wrote:
>> `jhsdb debugd` will start RMI registry by default, but we want to prevent it
>> due to port confliction in some cases. We can control it with
>> `sun.jvm.hotspot.rmi.startRegistry` system property. However we have no way
>> to set it
On Wed, 21 Apr 2021 07:59:09 GMT, Robbin Ehn wrote:
>> A suspend request is done by handshaking thread target thread(s). When
>> executing the handshake operation we know the target mutator thread is in a
>> dormant state (as in safepoint safe state). We have a guarantee that it will
>> check
30 matches
Mail list logo
