Re: RFR: 8268241: deprecate JVM TI Heap functions 1.0 [v2]

2021-06-07 Thread Serguei Spitsyn
On Tue, 8 Jun 2021 02:02:38 GMT, Serguei Spitsyn wrote: >> The JVM TI Heap functions 1.0 were superseded by newer functions in JVM TI >> 1.2 (Java 6) and should be deprecated so they can be removed in a future >> release. >> >> We need to replace this sentence: >> "These functions and data

Re: RFR: 8266130: convert Thread-SMR stress tests from counter based to time based [v2]

2021-06-07 Thread Chris Plummer
On Tue, 1 Jun 2021 20:52:40 GMT, Daniel D. Daugherty wrote: >> The Thread-SMR project added counter based tests for various APIs. >> See "JDK-8167108 inconsistent handling of SR_lock can lead to crashes". >> >> Time based tests are more appropriate for stress kits so I'm >> updating the counter

RFR: 8268361: Fix the infinite loop in next_line

2021-06-07 Thread UncleNine
If the /proc/stat mount point is changed in container environment, the while loop may lead to 100% cpu usage. - Commit messages: - Fix the dead loop.\nSummary: If the /proc/stat mount point is changed in container environment, the while loop may lead to 100% cpu usage. Changes:

Re: RFR: 8268361: Fix the infinite loop in next_line

2021-06-07 Thread Yi Yang
On Sun, 6 Jun 2021 14:47:31 GMT, UncleNine wrote: > If the /proc/stat mount point is changed in container environment, the while > loop may lead to 100% cpu usage. I have encountered a similar problem before, I've filed a new issue https://bugs.openjdk.java.net/browse/JDK-8268361 for this.

Re: RFR: 8268241: deprecate JVM TI Heap functions 1.0 [v2]

2021-06-07 Thread Lin Zang
On Tue, 8 Jun 2021 02:02:38 GMT, Serguei Spitsyn wrote: >> The JVM TI Heap functions 1.0 were superseded by newer functions in JVM TI >> 1.2 (Java 6) and should be deprecated so they can be removed in a future >> release. >> >> We need to replace this sentence: >> "These functions and data

Re: RFR: 8268241: deprecate JVMTI Heap functions 1.0 [v2]

2021-06-07 Thread Serguei Spitsyn
> The JVM TI Heap functions 1.0 were superseded by newer functions in JVM TI > 1.2 (Java 6) and should be deprecated so they can be removed in a future > release. > > We need to replace this sentence: > "These functions and data types were introduced in the original JVM TI > version 1.0 and

RFR: JDK-8268241: deprecate JVMTI Heap functions 1.0

2021-06-07 Thread Serguei Spitsyn
The JVM TI Heap functions 1.0 were superseded by newer functions in JVM TI 1.2 (Java 6) and should be deprecated so they can be removed in a future release. We need to replace this sentence: "These functions and data types were introduced in the original JVM TI version 1.0 and have been

Re: RFR: 8266130: convert Thread-SMR stress tests from counter based to time based [v2]

2021-06-07 Thread Daniel D . Daugherty
On Mon, 7 Jun 2021 22:09:51 GMT, Chris Plummer wrote: >> Daniel D. Daugherty has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Apply @plummercj code review fix from JDK-8265153 to this review also. > >

Re: RFR: 8266130: convert Thread-SMR stress tests from counter based to time based [v2]

2021-06-07 Thread Chris Plummer
On Tue, 1 Jun 2021 20:52:40 GMT, Daniel D. Daugherty wrote: >> The Thread-SMR project added counter based tests for various APIs. >> See "JDK-8167108 inconsistent handling of SR_lock can lead to crashes". >> >> Time based tests are more appropriate for stress kits so I'm >> updating the counter

Re: RFR: 8266130: convert Thread-SMR stress tests from counter based to time based [v2]

2021-06-07 Thread Chris Plummer
On Tue, 1 Jun 2021 20:52:40 GMT, Daniel D. Daugherty wrote: >> The Thread-SMR project added counter based tests for various APIs. >> See "JDK-8167108 inconsistent handling of SR_lock can lead to crashes". >> >> Time based tests are more appropriate for stress kits so I'm >> updating the counter

Integrated: 8266967: debug.cpp utility find() should print Java Object fields.

2021-06-07 Thread Kevin Walls
On Thu, 13 May 2021 12:12:42 GMT, Kevin Walls wrote: > This change enables debug.cpp's find() utility to print Java Objects with > their fields. > > find() calls os::print_location, and Java heap objects are printed with > instanceKlass oop_print_on. > Removing the ifdef for defining

Re: RFR: 8266130: convert Thread-SMR stress tests from counter based to time based [v2]

2021-06-07 Thread Chris Plummer
On Tue, 1 Jun 2021 20:52:40 GMT, Daniel D. Daugherty wrote: >> The Thread-SMR project added counter based tests for various APIs. >> See "JDK-8167108 inconsistent handling of SR_lock can lead to crashes". >> >> Time based tests are more appropriate for stress kits so I'm >> updating the counter

Re: RFR: 8266130: convert Thread-SMR stress tests from counter based to time based [v2]

2021-06-07 Thread Chris Plummer
On Tue, 1 Jun 2021 20:52:40 GMT, Daniel D. Daugherty wrote: >> The Thread-SMR project added counter based tests for various APIs. >> See "JDK-8167108 inconsistent handling of SR_lock can lead to crashes". >> >> Time based tests are more appropriate for stress kits so I'm >> updating the counter

Re: RFR: 8263203: jconsole Online User Guide has wrong URL [v2]

2021-06-07 Thread Chris Plummer
> The URL for the users guide, referenced from both the About dialog and from > the "Help -> Online Users Guide" menu item, has not functioned for a few > releases due the restructuring of the JDK online docs. This PR fixes the URL. > Note I also filed JDK-8268351 to get rid of the URL, but for

Re: RFR: 8263203: jconsole Online User Guide has wrong URL [v2]

2021-06-07 Thread Mandy Chung
On Mon, 7 Jun 2021 21:46:52 GMT, Chris Plummer wrote: >> The URL for the users guide, referenced from both the About dialog and from >> the "Help -> Online Users Guide" menu item, has not functioned for a few >> releases due the restructuring of the JDK online docs. This PR fixes the >> URL.

Re: RFR: 8263203: jconsole Online User Guide has wrong URL

2021-06-07 Thread Chris Plummer
On Mon, 7 Jun 2021 21:28:50 GMT, Mandy Chung wrote: > Try "using_jconsole" I already did. No luck. - PR: https://git.openjdk.java.net/jdk/pull/4399

Re: RFR: 8263203: jconsole Online User Guide has wrong URL

2021-06-07 Thread Chris Plummer
On Mon, 7 Jun 2021 19:36:23 GMT, Chris Plummer wrote: > The URL for the users guide, referenced from both the About dialog and from > the "Help -> Online Users Guide" menu item, has not functioned for a few > releases due the restructuring of the JDK online docs. This PR fixes the URL. > Note

Re: RFR: 8263203: jconsole Online User Guide has wrong URL

2021-06-07 Thread Mandy Chung
Try "using_jconsole" Mandy On 6/7/21 2:09 PM, Chris Plummer wrote: On Mon, 7 Jun 2021 19:36:23 GMT, Chris Plummer wrote: The URL for the users guide, referenced from both the About dialog and from the "Help -> Online Users Guide" menu item, has not functioned for a few releases due the

Re: RFR: 8263203: jconsole Online User Guide has wrong URL

2021-06-07 Thread Chris Plummer
On Mon, 7 Jun 2021 19:36:23 GMT, Chris Plummer wrote: > The URL for the users guide, referenced from both the About dialog and from > the "Help -> Online Users Guide" menu item, has not functioned for a few > releases due the restructuring of the JDK online docs. This PR fixes the URL. > Note

Re: RFR: 8263203: jconsole Online User Guide has wrong URL

2021-06-07 Thread Chris Plummer
On Mon, 7 Jun 2021 20:48:40 GMT, Mandy Chung wrote: > Hi Chris, > > It has been a while but I think this may intend to link to the User Guide > (not the tool reference) > https://docs.oracle.com/en/java/javase/16/management/using-jconsole.html I think you are right. And there is a reference

Re: RFR: 8263203: jconsole Online User Guide has wrong URL

2021-06-07 Thread Mandy Chung
On Mon, 7 Jun 2021 19:36:23 GMT, Chris Plummer wrote: > The URL for the users guide, referenced from both the About dialog and from > the "Help -> Online Users Guide" menu item, has not functioned for a few > releases due the restructuring of the JDK online docs. This PR fixes the URL. > Note

RFR: 8263203: jconsole Online User Guide has wrong URL

2021-06-07 Thread Chris Plummer
The URL for the users guide, referenced from both the About dialog and from the "Help -> Online Users Guide" menu item, has not functioned for a few releases due the restructuring of the JDK online docs. This PR fixes the URL. Note I also filed JDK-8268351 to get rid of the URL, but for 17 I

Re: RFR: 8266967: debug.cpp utility find() should print Java Object fields. [v2]

2021-06-07 Thread Kevin Walls
On Thu, 13 May 2021 13:24:17 GMT, Kevin Walls wrote: >> This change enables debug.cpp's find() utility to print Java Objects with >> their fields. >> >> find() calls os::print_location, and Java heap objects are printed with >> instanceKlass oop_print_on. >> Removing the ifdef for defining

Re: RFR: 8266967: debug.cpp utility find() should print Java Object fields. [v3]

2021-06-07 Thread Kevin Walls
> This change enables debug.cpp's find() utility to print Java Objects with > their fields. > > find() calls os::print_location, and Java heap objects are printed with > instanceKlass oop_print_on. > Removing the ifdef for defining oop_print_on for instanceKlass, and also on > methods in

Re: RFR: 8266130: convert Thread-SMR stress tests from counter based to time based [v2]

2021-06-07 Thread Chris Plummer
On Mon, 7 Jun 2021 15:17:36 GMT, Daniel D. Daugherty wrote: > @dholmes-ora and @plummercj - You both reviewed the related test work done > in: > JDK-8265153 add time based test for ThreadMXBean.getThreadInfo() and > ThreadInfo.getLockOwnerName() > Any chance you have the cycles for these

Re: RFR: 8266130: convert Thread-SMR stress tests from counter based to time based [v2]

2021-06-07 Thread Daniel D . Daugherty
On Tue, 1 Jun 2021 20:52:40 GMT, Daniel D. Daugherty wrote: >> The Thread-SMR project added counter based tests for various APIs. >> See "JDK-8167108 inconsistent handling of SR_lock can lead to crashes". >> >> Time based tests are more appropriate for stress kits so I'm >> updating the counter

Re: RFR: 8263323: Debug Agent help output includes invalid URL

2021-06-07 Thread Kevin Walls
On Fri, 4 Jun 2021 03:36:26 GMT, Chris Plummer wrote: > Rather than embed a URL in the help output, which needs to be updated if the > location of docs ever changes, just include a description of the document so > it can be looked up. The output now looks like: > > > $ ./java

Re: RFR: 8262386: resourcehogs/serviceability/sa/TestHeapDumpForLargeArray.java timed out [v14]

2021-06-07 Thread Lin Zang
> 8262386: resourcehogs/serviceability/sa/TestHeapDumpForLargeArray.java timed > out Lin Zang has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains 18

Re: RFR: 8252842: Extend jmap to support parallel heap dump [v27]

2021-06-07 Thread Lin Zang
> 8252842: Extend jmap to support parallel heap dump Lin Zang has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 36 commits: - Merge branch 'master' into par-dump - Merge branch 'master' into par-dump - fix build issue after rebase