> More refactoring to limit the scope of `@SuppressWarnings` annotations.
>
> Sometimes I introduce new methods. Please feel free to suggest method names
> you like to use.
Weijun Wang has updated the pull request incrementally with one additional
commit since the last revision:
one more
--
On Fri, 25 Jun 2021 20:04:37 GMT, Weijun Wang wrote:
> More refactoring to limit the scope of `@SuppressWarnings` annotations.
>
> Sometimes I introduce new methods. Please feel free to suggest method names
> you like to use.
LGTM.
-
Marked as reviewed by naoto (Reviewer).
PR: h
On Fri, 25 Jun 2021 18:11:27 GMT, Alex Menkov wrote:
> Please review this simple test fix for jdk17.
>
> The cycle should run until connection is established
> (connection.isConnected() returns true) or error occurred (error != null)
> This wrong condition causes test error if ListenerThread.ge
On Fri, 25 Jun 2021 20:26:16 GMT, Daniel D. Daugherty
wrote:
> Thumbs up.
>
> This looks like a trivial fix to me. I don't see any mention of
> testing. It looks like the two tests mentioned in the bug both
> run in Tier1 on multiple platforms.
Run 3 tests in test/hotspot/jtreg/serviceability/
On Thu, 24 Jun 2021 16:51:59 GMT, Chris Plummer wrote:
>> Re-enable the assert that was disabled (with some overhead) by
>> [JDK-8265683](https://bugs.openjdk.java.net/browse/JDK-8265683). Explanation
>> is in the CR and also in comments included with the changes.
>>
>> I tested by running `vm
On Fri, 25 Jun 2021 18:11:27 GMT, Alex Menkov wrote:
> Please review this simple test fix for jdk17.
>
> The cycle should run until connection is established
> (connection.isConnected() returns true) or error occurred (error != null)
> This wrong condition causes test error if ListenerThread.ge
On Fri, 25 Jun 2021 20:04:37 GMT, Weijun Wang wrote:
> More refactoring to limit the scope of `@SuppressWarnings` annotations.
>
> Sometimes I introduce new methods. Please feel free to suggest method names
> you like to use.
Changes look good Max
-
Marked as reviewed by lancea (
On Fri, 25 Jun 2021 18:11:27 GMT, Alex Menkov wrote:
> Please review this simple test fix for jdk17.
>
> The cycle should run until connection is established
> (connection.isConnected() returns true) or error occurred (error != null)
> This wrong condition causes test error if ListenerThread.ge
More refactoring to limit the scope of `@SuppressWarnings` annotations.
Sometimes I introduce new methods. Please feel free to suggest method names you
like to use.
-
Commit messages:
- 8269409: Post JEP 411 refactoring: core-libs with maximum covering > 10K
Changes: https://git.o
On 6/21/2021 2:02 PM, Paul Sandoz wrote:
On Mon, 21 Jun 2021 05:17:09 GMT, Yi Yang wrote:
After JDK-8265518(#3615), it's possible to replace all variants of checkIndex
by Objects.checkIndex/Objects.checkFromToIndex/Objects.checkFromIndexSize in
the whole JDK codebase.
Yi Yang has updated th
Please review this simple test fix for jdk17.
The cycle should run until connection is established (connection.isConnected()
returns true) or error occurred (error != null)
This wrong condition causes test error if ListenerThread.getConnection()
reaches "synchronized (this)" section earlier than
On Fri, 25 Jun 2021 04:25:08 GMT, Alex Menkov wrote:
> Please review this trivial fix in the cycle condition.
>
> The cycle should run until connection is established
> (connection.isConnected() returns true) or error occurred (error != null)
> This wrong condition causes test error if Listener
On Fri, 25 Jun 2021 15:32:09 GMT, Daniel D. Daugherty
wrote:
>
>
> @alexmenkov - would you mind withdrawing this PR and creating a new PR
> against JDK17?
> We're seeing these test failures in the JDK17 CI also. I've bumped the
> priority of the bug
> from P4 -> P3 since we're seeing Tier3 t
On Fri, 25 Jun 2021 06:22:37 GMT, Thomas Stuefe wrote:
>> Proposal to add a Linux+glibc-only jcmd to manually induce malloc_trim(3) in
>> the VM process.
>>
>>
>> The glibc is somewhat notorious for retaining released C Heap memory:
>> calling free(3) returns memory to the glibc, and most lib
On Fri, 25 Jun 2021 04:25:08 GMT, Alex Menkov wrote:
> Please review this trivial fix in the cycle condition.
>
> The cycle should run until connection is established
> (connection.isConnected() returns true) or error occurred (error != null)
> This wrong condition causes test error if Listener
On Fri, 25 Jun 2021 11:48:52 GMT, Patrick Concannon
wrote:
>> Hi,
>>
>> Could someone please review my changes for the removal of the legacy
>> `PlainSocketImpl` and `PlainDatagramSocketImpl` implementations?
>>
>> In JDK 13, JEP 353 provided a drop in replacement for the legacy
>> `PlainSoc
On Fri, 25 Jun 2021 11:48:52 GMT, Patrick Concannon
wrote:
>> Hi,
>>
>> Could someone please review my changes for the removal of the legacy
>> `PlainSocketImpl` and `PlainDatagramSocketImpl` implementations?
>>
>> In JDK 13, JEP 353 provided a drop in replacement for the legacy
>> `PlainSoc
On Fri, 25 Jun 2021 11:37:50 GMT, Daniel Fuchs wrote:
>> src/java.base/share/classes/java/net/DatagramSocket.java line 1398:
>>
>>> 1396: DatagramSocketImpl impl =
>>> factory.createDatagramSocketImpl();
>>> 1397: Objects.requireNonNull(impl,
>>> 1398:
> Hi,
>
> Could someone please review my changes for the removal of the legacy
> `PlainSocketImpl` and `PlainDatagramSocketImpl` implementations?
>
> In JDK 13, JEP 353 provided a drop in replacement for the legacy
> `PlainSocketImpl` implementation. Since JDK 13, the `PlainSocketImpl`
> imple
On Fri, 25 Jun 2021 10:56:15 GMT, Alan Bateman wrote:
>> Patrick Concannon has updated the pull request with a new target base due to
>> a merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains five additional
>> co
On Fri, 25 Jun 2021 10:25:52 GMT, Patrick Concannon
wrote:
>> Hi,
>>
>> Could someone please review my changes for the removal of the legacy
>> `PlainSocketImpl` and `PlainDatagramSocketImpl` implementations?
>>
>> In JDK 13, JEP 353 provided a drop in replacement for the legacy
>> `PlainSoc
On Fri, 25 Jun 2021 10:25:52 GMT, Patrick Concannon
wrote:
>> Hi,
>>
>> Could someone please review my changes for the removal of the legacy
>> `PlainSocketImpl` and `PlainDatagramSocketImpl` implementations?
>>
>> In JDK 13, JEP 353 provided a drop in replacement for the legacy
>> `PlainSoc
On Thu, 24 Jun 2021 15:06:49 GMT, Daniel Fuchs wrote:
>>> I've created an issue to track this:
>>> https://bugs.openjdk.java.net/browse/JDK-8269288
>>
>> Thanks. So are you keeping the Objects.requireNonNull here? If so then it
>> should probably be the 2-arg version so that the message is cle
> Hi,
>
> Could someone please review my changes for the removal of the legacy
> `PlainSocketImpl` and `PlainDatagramSocketImpl` implementations?
>
> In JDK 13, JEP 353 provided a drop in replacement for the legacy
> `PlainSocketImpl` implementation. Since JDK 13, the `PlainSocketImpl`
> imple
On Thu, 24 Jun 2021 16:51:59 GMT, Chris Plummer wrote:
>> Re-enable the assert that was disabled (with some overhead) by
>> [JDK-8265683](https://bugs.openjdk.java.net/browse/JDK-8265683). Explanation
>> is in the CR and also in comments included with the changes.
>>
>> I tested by running `vm
On Fri, 25 Jun 2021 04:25:08 GMT, Alex Menkov wrote:
> Please review this trivial fix in the cycle condition.
>
> The cycle should run until connection is established
> (connection.isConnected() returns true) or error occurred (error != null)
> This wrong condition causes test error if Listener
On Mon, 7 Jun 2021 07:58:26 GMT, Lin Zang wrote:
>> 8252842: Extend jmap to support parallel heap dump
>
> Lin Zang has updated the pull request with a new target base due to a merge
> or a rebase. The pull request now contains 36 commits:
>
> - Merge branch 'master' into par-dump
> - Merge b
27 matches
Mail list logo
