On Tue, 19 Oct 2021 20:17:59 GMT, Chris Plummer wrote:
>> Richard Reingruber has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Call blockOnDebuggerSuspend() after setup of the resumer tracking.
>
> src/jdk.jdwp.agent/share/native/libjdwp/t
On Thu, 23 Sep 2021 15:24:47 GMT, Jakob Cornell wrote:
>> This has been under discussion on and off for the past month or so on
>> serviceability-dev, and I think a CSR request is required, so this may be a
>> work in progress.
>>
>> Notes on the patch:
>>
>> - The `list` command previously m
> This has been under discussion on and off for the past month or so on
> serviceability-dev, and I think a CSR request is required, so this may be a
> work in progress.
>
> Notes on the patch:
>
> - The `list` command previously marked a line in each listing with `=>`. In
> a bare `list` thi
On Wed, 13 Oct 2021 04:17:25 GMT, Ioi Lam wrote:
> LocalVmManager and PerfDataFile have APIs that are supposed to look for VMs
> owned by a specific user. No one uses these APIs, and they don't work anyway.
>
> The current code is very confusing to look at. Since we're likely to change
> code
On Tue, 19 Oct 2021 21:52:14 GMT, Ioi Lam wrote:
> > > Hi Jacob, this is not your fault, but the "zz help text" in the Chinese
> > > and Japanese versions are in a single huge line. This makes it impossible
> > > to see what you have changed in the GitHub diffs, and impossible to tell
> > > wh
On Tue, 19 Oct 2021 21:41:41 GMT, Ioi Lam wrote:
>> src/jdk.internal.jvmstat/share/classes/sun/jvmstat/perfdata/monitor/protocol/local/PerfDataFile.java
>> line 80:
>>
>>> 78: "^hsperfdata_[0-9]+(_[1-2]+)?$";
>>> 79:
>>> 80:
>>
>> I don't understand why you thought it best to rem
On Wed, 13 Oct 2021 04:17:25 GMT, Ioi Lam wrote:
> LocalVmManager and PerfDataFile have APIs that are supposed to look for VMs
> owned by a specific user. No one uses these APIs, and they don't work anyway.
>
> The current code is very confusing to look at. Since we're likely to change
> code
On Tue, 19 Oct 2021 21:26:11 GMT, Chris Plummer wrote:
> > Hi Jacob, this is not your fault, but the "zz help text" in the Chinese and
> > Japanese versions are in a single huge line. This makes it impossible to
> > see what you have changed in the GitHub diffs, and impossible to tell
> > whet
On Tue, 19 Oct 2021 21:17:57 GMT, Chris Plummer wrote:
>> LocalVmManager and PerfDataFile have APIs that are supposed to look for VMs
>> owned by a specific user. No one uses these APIs, and they don't work anyway.
>>
>> The current code is very confusing to look at. Since we're likely to chang
On Tue, 19 Oct 2021 21:16:03 GMT, Ioi Lam wrote:
> Hi Jacob, this is not your fault, but the "zz help text" in the Chinese and
> Japanese versions are in a single huge line. This makes it impossible to see
> what you have changed in the GitHub diffs, and impossible to tell whether you
> made a
On Wed, 13 Oct 2021 04:17:25 GMT, Ioi Lam wrote:
> LocalVmManager and PerfDataFile have APIs that are supposed to look for VMs
> owned by a specific user. No one uses these APIs, and they don't work anyway.
>
> The current code is very confusing to look at. Since we're likely to change
> code
On Thu, 23 Sep 2021 15:24:47 GMT, Jakob Cornell wrote:
>> This has been under discussion on and off for the past month or so on
>> serviceability-dev, and I think a CSR request is required, so this may be a
>> work in progress.
>>
>> Notes on the patch:
>>
>> - The `list` command previously m
On Mon, 18 Oct 2021 20:02:21 GMT, Richard Reingruber wrote:
>> This change fixes deadlocks described in the JBS-bug by:
>>
>> * Releasing `handlerLock` before waiting on `threadLock` in
>> `blockOnDebuggerSuspend()`
>>
>> * Notifying on `threadLock` in `threadControl_reset()`
>>
>> Also the a
On Tue, 19 Oct 2021 15:31:39 GMT, Markus Grönlund wrote:
> Greetings (again),
>
> The quick fix for
> [JDK-8275445](https://bugs.openjdk.java.net/browse/JDK-8275445) includes an
> off-by-one error as part of the allocation. :-(
>
> Sorry for this inconvenience.
>
> Markus
This pull request
On Tue, 19 Oct 2021 15:31:39 GMT, Markus Grönlund wrote:
> Greetings (again),
>
> The quick fix for
> [JDK-8275445](https://bugs.openjdk.java.net/browse/JDK-8275445) includes an
> off-by-one error as part of the allocation. :-(
>
> Sorry for this inconvenience.
>
> Markus
Lgtm. Fingers cros
Greetings (again),
The quick fix for
[JDK-8275445](https://bugs.openjdk.java.net/browse/JDK-8275445) includes an
off-by-one error as part of the allocation. :-(
Sorry for this inconvenience.
Markus
-
Commit messages:
- Off-by-one error in allocation
Changes: https://git.openjdk
On Tue, 19 Oct 2021 15:34:13 GMT, Thomas Schatzl wrote:
>> Greetings (again),
>>
>> The quick fix for
>> [JDK-8275445](https://bugs.openjdk.java.net/browse/JDK-8275445) includes an
>> off-by-one error as part of the allocation. :-(
>>
>> Sorry for this inconvenience.
>>
>> Markus
>
> Lgtm. F
On Sat, 25 Sep 2021 11:15:35 GMT, Andrey Turbanov wrote:
> Collections.sort is just a wrapper, so it is better to use an instance method
> directly.
This pull request has now been integrated.
Changeset: a579483c
Author:Andrey Turbanov
Committer: Albert Mingkun Yang
URL:
https://gi
On Sat, 25 Sep 2021 11:15:35 GMT, Andrey Turbanov wrote:
> Collections.sort is just a wrapper, so it is better to use an instance method
> directly.
Marked as reviewed by ayang (Reviewer).
-
PR: https://git.openjdk.java.net/jdk/pull/5697
On Thu, 7 Oct 2021 06:18:00 GMT, Kim Barrett wrote:
>> Leo Korinth has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Use a thread local buffer so that the compiler might reorder operator new.
>
> src/hotspot/share/memory/memRegion.hpp line
On Thu, 7 Oct 2021 06:21:52 GMT, Kim Barrett wrote:
>> Leo Korinth has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Use a thread local buffer so that the compiler might reorder operator new.
>
> src/hotspot/share/memory/allocation.hpp lin
On Thu, 7 Oct 2021 06:21:09 GMT, Kim Barrett wrote:
>> Leo Korinth has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Use a thread local buffer so that the compiler might reorder operator new.
>
> src/hotspot/share/memory/allocation.hpp lin
On Tue, 19 Oct 2021 13:01:10 GMT, Leo Korinth wrote:
>> src/hotspot/share/memory/allocation.hpp line 398:
>>
>>> 396: class ResourceObj ALLOCATION_SUPER_CLASS_SPEC {
>>> 397: public:
>>> 398: enum allocation_type : uint8_t { STACK_OR_EMBEDDED, RESOURCE_AREA,
>>> C_HEAP, ARENA };
>>
>> Consi
On Thu, 7 Oct 2021 06:12:07 GMT, Kim Barrett wrote:
>> Leo Korinth has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Use a thread local buffer so that the compiler might reorder operator new.
>
> src/hotspot/share/memory/allocation.hpp lin
On Tue, 19 Oct 2021 09:39:06 GMT, Markus Grönlund wrote:
> Greetings,
>
> This fixes the issue seen in testing when accessing an oop as part of
> unloading (introduced with
> [JDK-8266936](https://bugs.openjdk.java.net/browse/JDK-8266936)).
>
> Instead, oop accesses will be done outside of un
On Tue, 19 Oct 2021 12:19:24 GMT, Erik Gahlin wrote:
>> Markus Grönlund has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> header
>
> Marked as reviewed by egahlin (Reviewer).
Thanks, @egahlin and @coleenp, for your quick reviews. I will p
On Tue, 19 Oct 2021 10:05:15 GMT, Markus Grönlund wrote:
>> Greetings,
>>
>> This fixes the issue seen in testing when accessing an oop as part of
>> unloading (introduced with
>> [JDK-8266936](https://bugs.openjdk.java.net/browse/JDK-8266936)).
>>
>> Instead, oop accesses will be done outsid
On Thu, 7 Oct 2021 05:54:55 GMT, Kim Barrett wrote:
>> Leo Korinth has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Use a thread local buffer so that the compiler might reorder operator new.
>
> src/hotspot/share/asm/codeBuffer.hpp line 3
On Thu, 7 Oct 2021 05:49:24 GMT, Kim Barrett wrote:
>> Leo Korinth has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Use a thread local buffer so that the compiler might reorder operator new.
>
> src/hotspot/share/asm/codeBuffer.cpp line 1
On Tue, 19 Oct 2021 10:05:15 GMT, Markus Grönlund wrote:
>> Greetings,
>>
>> This fixes the issue seen in testing when accessing an oop as part of
>> unloading (introduced with
>> [JDK-8266936](https://bugs.openjdk.java.net/browse/JDK-8266936)).
>>
>> Instead, oop accesses will be done outsid
> Greetings,
>
> This fixes the issue seen in testing when accessing an oop as part of
> unloading (introduced with
> [JDK-8266936](https://bugs.openjdk.java.net/browse/JDK-8266936)).
>
> Instead, oop accesses will be done outside of unloading and the result, i.e
> the codesource attribute, wi
31 matches
Mail list logo
