Re: RFR: JDK-8280503: Use allStatic.hpp instead of allocation.hpp where possible [v2]

2022-01-23 Thread Thomas Stuefe
On Mon, 24 Jan 2022 05:44:50 GMT, Thomas Stuefe wrote: >> JDK-8249944 moved AllStatic to its own header. We should use that one >> instead of allocation.hpp where possible to reduce header dependencies. >> >> This patch: >> - replaces includes of allocation.hpp with allstatic.hpp where appropia

Re: RFR: JDK-8280503: Use allStatic.hpp instead of allocation.hpp where possible [v3]

2022-01-23 Thread Thomas Stuefe
> JDK-8249944 moved AllStatic to its own header. We should use that one instead > of allocation.hpp where possible to reduce header dependencies. > > This patch: > - replaces includes of allocation.hpp with allstatic.hpp where appropiate > - fixes up resulting errors since this changes uncovers m

Re: RFR: JDK-8280503: Use allStatic.hpp instead of allocation.hpp where possible [v2]

2022-01-23 Thread Thomas Stuefe
On Mon, 24 Jan 2022 05:54:18 GMT, Ioi Lam wrote: > > > BTW, I have some scripts for checking how often a header file is > > > included. See https://github.com/iklam/tools/tree/main/headers > > > > > > Does your tool tell you include chokepoints, maybe its just one central > > include pulling

Re: RFR: JDK-8280503: Use allStatic.hpp instead of allocation.hpp where possible [v2]

2022-01-23 Thread Ioi Lam
On Mon, 24 Jan 2022 05:44:50 GMT, Thomas Stuefe wrote: >> JDK-8249944 moved AllStatic to its own header. We should use that one >> instead of allocation.hpp where possible to reduce header dependencies. >> >> This patch: >> - replaces includes of allocation.hpp with allstatic.hpp where appropia

Re: RFR: JDK-8280503: Use allStatic.hpp instead of allocation.hpp where possible [v2]

2022-01-23 Thread Thomas Stuefe
> JDK-8249944 moved AllStatic to its own header. We should use that one instead > of allocation.hpp where possible to reduce header dependencies. > > This patch: > - replaces includes of allocation.hpp with allstatic.hpp where appropiate > - fixes up resulting errors since this changes uncovers m

Re: RFR: JDK-8280503: Use allStatic.hpp instead of allocation.hpp where possible

2022-01-23 Thread Thomas Stuefe
On Mon, 24 Jan 2022 04:22:34 GMT, Ioi Lam wrote: > BTW, I have some scripts for checking how often a header file is included. > See https://github.com/iklam/tools/tree/main/headers > > count_hotspot_headers.tcl shows that allocation.hpp was included by 1006 .o > files before this fix, and 996

Re: RFR: JDK-8280503: Use allStatic.hpp instead of allocation.hpp where possible

2022-01-23 Thread Thomas Stuefe
On Mon, 24 Jan 2022 02:43:04 GMT, David Holmes wrote: > Hi Thomas, > > Seems okay - hard to validate (and I expect allocation.hpp to be included > somewhere in most cases anyway). > It shouldn't, that's the idea of JDK-8249944. > Some of the changes seem to have nothing to do with: > > -#in

Integrated: 8279124: VM does not handle SIGQUIT during initialization

2022-01-23 Thread Xin Liu
On Mon, 10 Jan 2022 05:19:26 GMT, Xin Liu wrote: > In early stage of initialization, HotSpot doesn't handle SIGQUIT. The default > signal preposition on Linux is to quit the process and generate coredump. > > There are 2 applications for this signal. > 1. There's a handshake protocol between su

Re: RFR: JDK-8280503: Use allStatic.hpp instead of allocation.hpp where possible

2022-01-23 Thread Ioi Lam
On Mon, 24 Jan 2022 04:18:48 GMT, Ioi Lam wrote: > I am running a mach5 job for tier1 + builds-tier5. That should cover most of > the builds done by the Oracle CI. I'll post the results when they are ready. Unfortunately I am seeing failures on macos and windows: macos: src/hotspot/os/bsd/gc/

Re: RFR: JDK-8280503: Use allStatic.hpp instead of allocation.hpp where possible

2022-01-23 Thread Ioi Lam
On Sat, 22 Jan 2022 13:33:24 GMT, Thomas Stuefe wrote: > JDK-8249944 moved AllStatic to its own header. We should use that one instead > of allocation.hpp where possible to reduce header dependencies. > > This patch: > - replaces includes of allocation.hpp with allstatic.hpp where appropiate >

Re: RFR: JDK-8280503: Use allStatic.hpp instead of allocation.hpp where possible

2022-01-23 Thread Ioi Lam
On Sat, 22 Jan 2022 13:33:24 GMT, Thomas Stuefe wrote: > JDK-8249944 moved AllStatic to its own header. We should use that one instead > of allocation.hpp where possible to reduce header dependencies. > > This patch: > - replaces includes of allocation.hpp with allstatic.hpp where appropiate >

Re: RFR: 8275775: Add jcmd VM.classes to print details of all classes [v5]

2022-01-23 Thread Ioi Lam
On Thu, 20 Jan 2022 09:47:31 GMT, Yi Yang wrote: >> Add VM.classes to print details of all classes, output looks like: >> >> 1. jcmd VM.classes >> >> KlassAddr Size State Flags LoaderName ClassName >> 0x000800c0b400 62 inited W bootstrap >> java.lang.invoke.LambdaForm$MH/0x000800c0b400

Re: RFR: JDK-8280503: Use allStatic.hpp instead of allocation.hpp where possible

2022-01-23 Thread David Holmes
On Sat, 22 Jan 2022 13:33:24 GMT, Thomas Stuefe wrote: > JDK-8249944 moved AllStatic to its own header. We should use that one instead > of allocation.hpp where possible to reduce header dependencies. > > This patch: > - replaces includes of allocation.hpp with allstatic.hpp where appropiate >

Re: RFR: JDK-8280503: Use allStatic.hpp instead of allocation.hpp where possible

2022-01-23 Thread David Holmes
On Sat, 22 Jan 2022 13:33:24 GMT, Thomas Stuefe wrote: > JDK-8249944 moved AllStatic to its own header. We should use that one instead > of allocation.hpp where possible to reduce header dependencies. > > This patch: > - replaces includes of allocation.hpp with allstatic.hpp where appropiate >

Re: RFR: JDK-8280492: Address remaining doclint issues in JDK build

2022-01-23 Thread Lance Andersen
On Sat, 22 Jan 2022 21:09:03 GMT, Joe Darcy wrote: > Use presumed syntax that will be introduced by JDK-8280488. Marked as reviewed by lancea (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/7189

Re: RFR: 8279124: VM does not handle SIGQUIT during initialization [v7]

2022-01-23 Thread David Holmes
On Sat, 22 Jan 2022 01:17:41 GMT, Xin Liu wrote: >> In early stage of initialization, HotSpot doesn't handle SIGQUIT. The >> default signal preposition on Linux is to quit the process and generate >> coredump. >> >> There are 2 applications for this signal. >> 1. There's a handshake protocol b

Re: RFR: JDK-8280492: Address remaining doclint issues in JDK build

2022-01-23 Thread Sergey Bylokhov
On Sat, 22 Jan 2022 21:09:03 GMT, Joe Darcy wrote: > Use presumed syntax that will be introduced by JDK-8280488. Marked as reviewed by serb (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/7189