> On 12 Mar 2019, at 16:19, Stefan Karlsson wrote:
>
> Hi all,
Hey StefanK,
> Please review and/or comment on this change to remove
> CodeCache::scavenge_root_nmehods_do from
> VM_HeapWalkOperation::collect_simple_roots.
>
> http://cr.openjdk.java.net/~stefank/8220342/webrev.01/
I think
On 07/13/2018 04:10 PM, Daniel Mitterdorfer wrote:
Hi,
I have good news. I was able to reproduce this issue but this time I
have logs. A test failed with the following stack trace around
15:06:55 with:
java.lang.IllegalArgumentException: committed = 537919488 should be <
max = 536870912
>
On 07/12/2018 10:34 PM, mandy chung wrote:
It's indeed strange that no one reports this issue. I created:
https://bugs.openjdk.java.net/browse/JDK-8207200
Mandy: I moved the bug over to hotspot/gc, this is much more likely to
be a problem with how the GC calculates the sizes. I don't
Hi Daniel,
thanks for letting us know. Since you have only set -Xms512 and -Xmx512
and you are running on JDK 10 that means you are using the G1 garbage
collector, so all the calls to pool->get_memory_usage() in the loop will
end up in g1MemoryPool.cpp [0] which in turn will return cached
On 06/18/2018 06:14 PM, Hohensee, Paul wrote:
Thanks, Eric!
I'd push, but it seems I don't seem to have permission at the moment. Who
should I contact to get that fixed?
That would be o...@openjdk.java.net.
Thanks,
Erik
Thanks,
Paul
On 6/18/18, 7:09 AM, "Erik Helin" wrote:
On 06/16/2018 09:00 PM, Hohensee, Paul wrote:
Thanks for the re-review, Erik. New webrev with your fixes:
http://cr.openjdk.java.net/~phh/8195115/webrev.04/
The patch is good to go now, Reviewed.
Thanks,
Erik
Need another reviewer, please.
Thanks,
Paul
On 6/16/18, 1:25 AM, "Erik
ou mind updating the patch with this
change (and remove the trailing whitespace)?
Thanks,
Erik
Thanks,
Paul
On 6/12/18, 6:52 AM, "Erik Helin" wrote:
(adding back serviceability-dev, please keep both hotspot-gc-dev and
serviceability-dev)
Hi Paul,
On 06/15/2018 11:16 AM, serguei.spit...@oracle.com wrote:
Please, review a fix for:
https://bugs.openjdk.java.net/browse/JDK-8205096
Webrev:
http://cr.openjdk.java.net/~sspitsyn/webrevs/2018/8205096-missed-files-for-8203394/
Looks good, Reviewed. I can confirm that jdk/jdk builds with patch
Bug: https://bugs.openjdk.java.net/browse/JDK-8195115
Webrev: http://cr.openjdk.java.net/~phh/8195115/webrev.02/
TIA for your re-review. Plus, may I have another reviewer look at it please?
Paul
On 2/26/18, 8:47 AM, "Erik Helin" wrote:
On 03/09/2018 02:34 PM, Leo Korinth wrote:
I still need another reviewer (and a sponsor).
Looks good (well XSLT combined with C++ is awful, but the patch is good
:D), Reviewed. I can sponsor this patch.
Thanks,
Erik
Thanks,
Leo
On 08/03/18 10:23, Markus Gronlund wrote:
Hi Leo,
Looks
Hi Paul,
a couple of comments on the patch:
- memoryService.hpp:
+ 150 bool countCollection,
+ 151 bool allMemoryPoolsAffected = true);
There is no need to use a default value for the parameter
allMemoryPoolsAffected here. Skipping the default value
ll the interfaces are MXBeans, hope that’s ok) which must be either indefinitely maintained, or go through a deprecation cycle. I don’t see a way out of the ‘iterate over all collectors’ problem without it though.
Paul
On 1/31/18, 3:42 AM,
eases. The
perm gen pool was removed in JDK 8, the default pools changed when
Parallel Old became default old collector way back in JDK 7 and changed
again when G1 became the default collector in JDK 9.
Thanks,
Erik
Thanks,
Paul
On 1/30/18, 5:51 AM, "Erik Helin" <erik.he...@
iting on the submit repo to come back with a result on it.
Thanks,
Paul
*From: *mandy chung <mandy.ch...@oracle.com>
<mailto:mandy.ch...@oracle.com>
*Organization: *Oracle Corporation
*Date: *Monday, January 29, 2018 at 10:52 AM
*To: *"Hohensee, Paul&quo
Hi Paul,
thanks for your interest in this area and for your patch! The
GarbageCollectorMXBean and MemoryPoolMXBean support for G1 is in need of
some updates, so thanks for working on this.
Looking at your patch, I'm not sure that this is the direction we want
to go in. I discussed this a
Please review the full change:
http://cr.openjdk.java.net/~rkennke/8191564/webrev.02/
Thanks, Roman
I had some off-band discussions with Erik Helin and re-did most
of the changeset:
- The GC interface now resides in CollectedHeap, specifically
the two methods memory_managers() and memory_pools
about the corresponding GCMemoryManager
Please review the full change:
http://cr.openjdk.java.net/~rkennke/8191564/webrev.02/
Thanks, Roman
I had some off-band discussions with Erik Helin and re-did most
of the changeset:
- The GC interface now resides in CollectedHeap, specifically the
two
Hi Per,
On 11/24/2017 09:01 AM, Per Liden wrote:
Hi,
jstat is designed to handle the case where a perf counter doesn't exits.
In the output jstat will then print a "-" instead of the perf counter
value to indicate that the counter doesn't exist. However, jstat also
prints an unnecessary
I'm adding hotspot-gc-dev since GC code is touched and not all GC
developers are on serviceability-dev (probably just me).
Thanks,
Erik
On 10/18/2017 04:34 AM, Erik Gahlin wrote:
Hi,
Could I have a review of a change that adds two macros to be used with
event-based JVM tracing.
Bug:
On 07/17/2017 02:07 PM, Roman Kennke wrote:
Ok, added those and some more that I found. Not sure why we'd need
#include "gc/cms/concurrentMarkSweepGeneration.hpp" ? Left that out
for now.
Because you are accessing CMSCollcetor in:
99 NOT_PRODUCT(
100 virtual size_t
On 2016-02-05, Marcus Larsson wrote:
> Hi,
>
> Please review the following patch to make the configure_stdout
> internalvmtest independent on VM arguments for UL. Without this fix the test
> fails if run while logging to a file (-Xlog::somefile).
>
> Webrev:
>
On 2015-02-16, Andrew Haley wrote:
On 02/16/2015 12:06 PM, Erik Helin wrote:
On 2015-02-16, Andrew Haley wrote:
On 02/16/2015 10:43 AM, Volker Simonis wrote:
Now if we replicate this SA code one more time in a Python library for
GDB, you'll probably agree that it can't work more reliably
On 2015-02-16, Andrew Haley wrote:
On 02/16/2015 10:43 AM, Volker Simonis wrote:
Now if we replicate this SA code one more time in a Python library for
GDB, you'll probably agree that it can't work more reliably than the
original SA code. This may be good enough for some use cases, but it
On 2015-02-12, Alexander Smundak wrote:
It was the previous implementation that used the serviceability agent,
sorry for the confusion. The new one replicates the necessary
functionality of the serviceability agent instead. All the operations
on the debuggee (catching events, reading writing
On 2015-02-13, Erik Helin wrote:
On 2015-02-12, Alexander Smundak wrote:
It was the previous implementation that used the serviceability agent,
sorry for the confusion. The new one replicates the necessary
functionality of the serviceability agent instead. All the operations
On 2014-12-08 21:31, Brendan Gregg wrote:
G'Day Staffan,
On Mon, Dec 8, 2014 at 11:17 AM, Staffan Larsen
staffan.lar...@oracle.com wrote:
On 8 dec 2014, at 16:05, Maynard Johnson mayna...@us.ibm.com wrote:
[...]
And if the VM creates a /tmp/perf-PID.map file to save information about
I applied the patch on top of jdk9/hs-comp and created a webrev:
http://cr.openjdk.java.net/~ehelin/brendan/frame-pointer/webrev/
I also successfully run the patch through JPRT.
Thanks,
Erik
On 2014-12-05 20:57, Brendan Gregg wrote:
On Thu, Dec 4, 2014 at 2:55 PM, Brendan Gregg
I should also add that I don't have enough knowledge of the compiler
internals to review this patch, sorry.
Thanks,
Erik
On 2014-12-09 10:53, Erik Helin wrote:
I applied the patch on top of jdk9/hs-comp and created a webrev:
http://cr.openjdk.java.net/~ehelin/brendan/frame-pointer/webrev/
I
On 2014-12-02, Staffan Friberg wrote:
Hi,
As noted in the original thread [1] about this event we split up the commit
in 4 different steps. This is the first step that only adds the event and
methods to send them, but the usage will be added separately for the 3 GCs
using PLABs.
Bug
Hi Markus,
looks good, Reviewed. I can sponsor this change.
If it is ok for the svc team, I would like to push this via the
jdk9/hs-gc/hotspot repo (not via jdk9/hs-rt/hotspot) since we have other
upcoming patches depending on this one.
Thanks,
Erik
On 2014-11-07 16:32, Marcus Larsson
const, then the getter can
return a const ParallelScavengeTracer*, right?
Thanks,
Erik
Will upload a new webrev shortly.
//Staffan
On 08/28/2014 02:27 AM, Erik Helin wrote:
Hi Staffan,
thanks for the patch, looks like a useful event!
A few initial comments:
- Aren't the events for promotion
Hi Markus,
this looks good.
Thanks,
Erik
On 2014-04-24 19:06, Markus Grönlund wrote:
Thanks Coleen,
It’s just a simple scalar assignment – it’s ok to take yet another
incremented value if needed.
/Markus
*From:*Coleen Phillimore
*Sent:* den 24 april 2014 18:56
*To:*
://cr.openjdk.java.net/~ysuenaga/JDK-7090324/webrev.07/
Could you review again?
Thanks,
Yasumasa
On 03/05/2014 03:47 PM, Erik Helin wrote:
Hi Yasu,
I think this looks good except for the comment in globals.hpp for
GCLogFileSize which needs to be updated.
What do you think about the following?
product(uintx
/
Yasumasa
On 02/05/2014 09:09 PM, Yasumasa Suenaga wrote:
Hi Erik,
Thank you for reviewing again!
I've updated new webrev.
On 02/05/2014 07:40 PM, Erik Helin wrote:
Hi Yasumasa,
I've looked through the latest patch, it is much better! I just
have two comments:
- ostream.hpp:
Why did you add
,
Yasumasa
On 2014/01/30 0:55, Yasumasa Suenaga wrote:
Hi Erik,
On 2014/01/30 0:13, Erik Helin wrote:
Hi Yasumasa,
(have to use HTML email to get a width of more than 78 chars, sorry)
why did you change the code in arguments.cpp in the method
check_gc_log_consistency?
In current implementation
Hi Yasumasa,
(have to use HTML email to get a width of more than 78 chars, sorry)
why did you change the code in arguments.cpp in the method
check_gc_log_consistency?
Next, the gcLogFileStream::rotate_log method now does a lot of things.
Could you separate out the first block into a new
, at 15:08, Staffan Larsen staffan.lar...@oracle.com wrote:
Erik Helin suggested using template functions instead of macros which makes the
code a little more type safe.
Also added a missing #include in globals.cpp.
Here is a new version of the webrev:
http://cr.openjdk.java.net/~sla/8032250
Hi Coleen,
this looks great, just one minor nit: could you please update the
comment starting at jvmtiImpl.cpp:242 (which explains why using
allow_unhandled_oop is correct) to use _class_holder instead of
_class_loader?
Thanks,
Erik
On 2013-10-30, Coleen Phillimore wrote:
8026948:
/JDK-8026946
- https://bugs.openjdk.java.net/browse/JDK-8026948
Everyone, thanks for all your feedback on this change!
Erik
On 2013-10-18, Erik Helin wrote:
Hi David and Serguei,
thanks for having a look at this change!
On 2013-10-18, David Holmes wrote:
On 18/10/2013 5:58 PM, serguei.spit
Hi all,
this is the second version of a patch for JDK-8025834.
Background:
In JvmtiEnv::SetBreakpoint and JvmtiEnv::ClearBreakpoint, we create a
JvmtiBreakpoint on the stack. This JvmtiBreakpoint contains an
unhandled oop to the class loader of the Method's class.
A pointer to the
// CHECK_UNHANDLED_OOPS
assert(_method != NULL, _method != NULL);
_bci = (int) location;
assert(_bci = 0, _bci = 0);
What do you think?
Thanks,
Erik
On 2013-10-21, Mikael Gerdin wrote:
Erik,
On Monday 21 October 2013 11.26.51 Erik Helin wrote:
Hi all,
this is the second
.
Thanks,
Serguei
Thanks,
Serguei
David
Also, you need to run the nsk.jdi.testlist and nsk.jdwp.testlist test
suites as well.
Thanks,
Serguei
On 10/17/13 2:28 PM, Erik Helin wrote:
Hi Mikael and Coleen,
thanks for your reviews!
On 2013-10-16, Mikael Gerdin wrote
,
(it's not necessary to cross-post between hotspot-dev and
hotspot-gc-dev, so I removed hotspot-gc from the CC list)
On 2013-10-16 18:09, Erik Helin wrote:
Hi all,
this patch fixes an issue where an oop in JvmtiBreakpoint,
JvmtiBreakpoint::_class_loader, was found by the unhandled oop detector
Hi all,
this patch fixes an issue where an oop in JvmtiBreakpoint,
JvmtiBreakpoint::_class_loader, was found by the unhandled oop detector.
Instead of registering the oop as an unhandled oop, which would have
worked, I decided to wrap the oop in a handle as long as it is on the
stack.
A
Changeset: 1a8fb39bdbc4
Author:ehelin
Date: 2013-08-07 16:47 +0200
URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/1a8fb39bdbc4
8014659: NPG: performance counters for compressed klass space
Reviewed-by: mgerdin, coleenp, hseigel, jmasa, ctornqvi
!
Thanks!
Erik
On 2013-07-05, Alan Bateman wrote:
On 05/07/2013 15:08, Erik Helin wrote:
Hi all,
still looking for a review for this testfix. Looping in
hotspot-gc-...@openjdk.java.net as well.
It looks like okay to me and the comments make it clear the memory
pools that it expects
Hi all,
still looking for a review for this testfix. Looping in
hotspot-gc-...@openjdk.java.net as well.
Thanks,
Erik
On 2013-07-01, Erik Helin wrote:
Hi all,
this change updates MemoryTest.java to take the newly added Metaspace
and Compressed Class Space MemoryMXBeans into account
On 2013-07-02, Alan Bateman wrote:
On 01/07/2013 16:32, Erik Helin wrote:
Hi all,
this change excludes the following two MemoryMXBean tests:
- java/lang/management/MemoryMXBean/MemoryTestAllGC.sh
- java/lang/management/MemoryMXBean/MemoryTest.java
This is needed since a change in hotspot
Hi all,
this change excludes the following two MemoryMXBean tests:
- java/lang/management/MemoryMXBean/MemoryTestAllGC.sh
- java/lang/management/MemoryMXBean/MemoryTest.java
This is needed since a change in hotspot added a new memory pool for
metaspace:
hg log hotspot-main/hotspot:
Hi all,
this change updates MemoryTest.java to take the newly added Metaspace
and Compressed Class Space MemoryMXBeans into account, as well as the
new Metaspace Memory Manager.
This change also removes the following two tests from ProblemList.txt
since they are now passing again:
Hi all,
this minimal change removes the test sun/tools/JMAP/Basic.sh from
ProblemList.txt since the bug that caused the test to fail has been
fixed.
Webrev:
http://cr.openjdk.java.net/~ehelin/8017159/webrev.00/
Thanks,
Erik
-31, Mikael Gerdin wrote:
(merging the gc-dev and svc-dev threads)
Hi Erik,
On 2013-05-29 10:44, Erik Helin wrote:
Hi all,
this want sent to hotspot-gc-...@openjdk.java.net, sending to
serviceability-dev@openjdk.java.net as well since the change is about
memory pools.
This change adds
Hi all,
this want sent to hotspot-gc-...@openjdk.java.net, sending to
serviceability-dev@openjdk.java.net as well since the change is about
memory pools.
This change adds two memory pools for metaspace, one for Metaspace and
one for compressed klass space. The memory pool for compressed klass
Jesper,
On 05/08/2013 10:20 AM, Jesper Wilhelmsson wrote:
Erik Helin skrev 8/5/13 10:00 AM:
Jesper,
On 05/07/2013 09:52 PM, Jesper Wilhelmsson wrote:
Erik Helin skrev 7/5/13 9:28 PM:
Jesper,
I've changed the flag to be an experimental flag instead of a product
flag.
Thanks!
Please see
Thanks!
Erik
On 05/08/2013 01:29 PM, Jesper Wilhelmsson wrote:
Erik Helin skrev 8/5/13 1:00 PM:
Jesper,
On 05/08/2013 10:20 AM, Jesper Wilhelmsson wrote:
Erik Helin skrev 8/5/13 10:00 AM:
Jesper,
On 05/07/2013 09:52 PM, Jesper Wilhelmsson wrote:
Erik Helin skrev 7/5/13 9:28 PM:
Jesper
adding a flag
to control the threshold. I suspect that they would prefer some tracing
specific way to configure these thresholds.
/Jesper
Erik Helin skrev 7/5/13 2:58 PM:
Hi Bengt,
thanks for the review!
On 05/07/2013 11:42 AM, Bengt Rutisson wrote:
Hi Erik,
Looks good.
Two minor nits:
Could
Anyone?
It is a very small change and I would really like these tests to start
running again in the nightly testing.
Thanks,
Erik
On 03/22/2013 03:53 PM, Erik Helin wrote:
Hi all,
the tests for jstat can be re-enabled now that jstat and the tests for
jstat have been updated to account
Hi Staffan,
thanks for the review! Now I just need a JDK reviewer to take a look at
this.
Erik
On 03/26/2013 01:09 PM, Staffan Larsen wrote:
Looks good!
On 26 mar 2013, at 12:29, Erik Helin erik.he...@oracle.com wrote:
Anyone?
It is a very small change and I would really like
, Daniel D. Daugherty wrote:
Thumbs up for the ProblemList.txt change.
Thanks!
Erik
Dan
On 3/26/13 5:29 AM, Erik Helin wrote:
Anyone?
It is a very small change and I would really like these tests to start
running again in the nightly testing.
Thanks,
Erik
On 03/22/2013 03:53 PM, Erik
Hi all,
the tests for jstat can be re-enabled now that jstat and the tests for
jstat have been updated to account for metaspace changes [0].
This change removes the jstat tests (and one jstatd test) from
ProblemList.txt.
Webrev:
http://cr.openjdk.java.net/~ehelin/8009427/webrev.00/
Bug:
really does hit this, or think it's likely, we can look
again...
On 06/03/13 18:19, Erik Helin wrote:
Hi Kevin,
I think that there _might_ be a bug in CMS which was present even
before you added the event tracing.
If you look in aquire_control_and_collect, you will see that
should_compact can
Hi Jesper,
looks good.
Thanks,
Erik
On 03/06/2013 05:04 PM, Jesper Wilhelmsson wrote:
Hi,
Additional feedback resulted in a new webrev:
http://cr.openjdk.java.net/~jwilhelm/8008790/webrev.hsx24.3/
Thanks,
/Jesper
On 26/2/13 4:54 PM, Jesper Wilhelmsson wrote:
Hi,
After some internal
Hi Kevin,
I think that there _might_ be a bug in CMS which was present even before
you added the event tracing.
If you look in aquire_control_and_collect, you will see that
should_compact can be set to false by
decide_foreground_collection_type. If this is the case, then we will end
up in
On 02/20/2013 05:02 PM, Erik Helin wrote:
Hi all,
this change is the third of three changes related to renaming the jmap
option permstat to clstats. The change has to be done as three separate
changes in order to not break any repositories:
1. Add support for the -clstats option to the SA agent
2
been updated.
Thanks,
Erik
On 02/20/2013 05:02 PM, Erik Helin wrote:
Hi all,
this change is the second of three changes related to renaming the jmap
option permstat to clstats. The change has to be done as three separate
changes in order to not break any repositories:
1. Add support
have also been updated.
Thanks,
Erik
On 02/20/2013 05:01 PM, Erik Helin wrote:
Hi all,
this change is the first of three changes related to renaming the jmap
option permstat to clstats. The change has to be done as three separate
changes in order to not break any repositories:
1. Add support
/21/2013 12:22 PM, Staffan Larsen wrote:
The 8005116 bug says that the new option should be -classstats, but the
code uses -clstats. I think this is better, but you may want to update the bug.
Agree, I've updated the bug.
Thanks,
Erik
Thanks,
/Staffan
On 20 feb 2013, at 17:01, Erik Helin
Hi all,
this change is the third of three changes related to renaming the jmap
option permstat to clstats. The change has to be done as three separate
changes in order to not break any repositories:
1. Add support for the -clstats option to the SA agent
2. Change the tool jmap to use -clstats
Hi all,
this change is the second of three changes related to renaming the jmap
option permstat to clstats. The change has to be done as three separate
changes in order to not break any repositories:
1. Add support for the -clstats option to the SA agent
2. Change the tool jmap to use -clstats
Hi all,
this change is the first of three changes related to renaming the jmap
option permstat to clstats. The change has to be done as three separate
changes in order to not break any repositories:
1. Add support for the -clstats option to the SA agent
2. Change the tool jmap to use -clstats
Hi Mandy,
thanks for the review! See comments inline.
On 02/05/2013 09:14 PM, Mandy Chung wrote:
Hi Erik,
On 2/4/13 8:01 AM, Erik Helin wrote:
There have been some updates to the hotspot code based on feedback from
the hotspot-gc-dev mailing list. The only change to the JDK code
://cr.openjdk.java.net/~ehelin/8004172/hotspot/webrev.03/
Thanks,
Erik
On 01/28/2013 04:23 PM, Erik Helin wrote:
Jon Masamitsu suggested that the sun.rt namespace should be used
instead of the sun.gc namespace. I've updated both the jdk and the
hotspot code based on this suggestion.
New webrevs:
- hotspot: http
Hi all,
this change adds supports for defining trace types in closed code.
Webrev:
http://cr.openjdk.java.net/~ehelin/8006400/webrev.00/
Testing:
JPRT
Thanks,
Erik
Hi,
Staffan Larsen pointed out an error in the file trace.xml - the types
were included after the events.
The following updated webrev corrects this issue:
http://cr.openjdk.java.net/~ehelin/8006400/webrev.01/
Thanks,
Erik
On 01/16/2013 10:52 AM, Erik Helin wrote:
Hi all,
this change
Hi Nils,
thanks for reviewing this code!
Please see the updated webrev that I just posted in response to an issue
pointed out by Staffan Larsen.
Thanks,
Erik
On 01/16/2013 11:37 AM, Nils Loodin wrote:
I think it looks good.
/Nisse
On Jan 16, 2013, at 10:52 , Erik Helin erik.he
75 matches
Mail list logo
