On Mon, 1 Nov 2021 04:39:27 GMT, Jakob Cornell wrote:
> This will fix a few issues with the tests added in #5290:
>
> - [x] intermittent failures
> - [x] tests should use `failure` method to report problems rather than
> throwing `AssertionError`
This pull request has now
On Tue, 2 Nov 2021 01:07:30 GMT, Jakob Cornell wrote:
>> This will fix a few issues with the tests added in #5290:
>>
>> - [x] intermittent failures
>> - [x] tests should use `failure` method to report problems rather than
>> throwing `AssertionError`
>
>
> This will fix a few issues with the tests added in #5290:
>
> - [x] intermittent failures
> - [x] tests should use `failure` method to report problems rather than
> throwing `AssertionError`
Jakob Cornell has updated the pull request incrementally with one additional
commit
On Mon, 1 Nov 2021 04:39:27 GMT, Jakob Cornell wrote:
> This will fix a few issues with the tests added in #5290:
>
> - [x] intermittent failures
> - [x] tests should use `failure` method to report problems rather than
> throwing `AssertionError`
That certainly does make sen
On Mon, 1 Nov 2021 04:39:27 GMT, Jakob Cornell wrote:
> This will fix a few issues with the tests added in #5290:
>
> - [ ] intermittent failures
> - [x] tests should use `failure` method to report problems rather than
> throwing `AssertionError`
This isn't ready for revi
This will fix a few issues with the tests added in #5290:
- [ ] intermittent failures
- [x] tests should use `failure` method to report problems rather than throwing
`AssertionError`
-
Commit messages:
- Use `failure' method instead of `AssertionError' in new tests
Changes: https:
On Mon, 1 Nov 2021 04:39:27 GMT, Jakob Cornell wrote:
> This will fix a few issues with the tests added in #5290:
>
> - [ ] intermittent failures
> - [x] tests should use `failure` method to report problems rather than
> throwing `AssertionError`
I'm not sure whether this
On Mon, 25 Oct 2021 22:21:54 GMT, Jakob Cornell wrote:
>> This has been under discussion on and off for the past month or so on
>> serviceability-dev, and I think a CSR request is required, so this may be a
>> work in progress.
>>
>> Notes on the patch:
>>
On Mon, 25 Oct 2021 22:21:54 GMT, Jakob Cornell wrote:
>> This has been under discussion on and off for the past month or so on
>> serviceability-dev, and I think a CSR request is required, so this may be a
>> work in progress.
>>
>> Notes on the patch:
>>
On Mon, 25 Oct 2021 22:21:54 GMT, Jakob Cornell wrote:
>> This has been under discussion on and off for the past month or so on
>> serviceability-dev, and I think a CSR request is required, so this may be a
>> work in progress.
>>
>> Notes on the patch:
>>
On Mon, 25 Oct 2021 22:21:54 GMT, Jakob Cornell wrote:
>> This has been under discussion on and off for the past month or so on
>> serviceability-dev, and I think a CSR request is required, so this may be a
>> work in progress.
>>
>> Notes on the patch:
>>
On Mon, 25 Oct 2021 22:21:54 GMT, Jakob Cornell wrote:
>> This has been under discussion on and off for the past month or so on
>> serviceability-dev, and I think a CSR request is required, so this may be a
>> work in progress.
>>
>> Notes on the patch:
>>
On Sat, 28 Aug 2021 05:48:47 GMT, Jakob Cornell wrote:
> This has been under discussion on and off for the past month or so on
> serviceability-dev, and I think a CSR request is required, so this may be a
> work in progress.
>
> Notes on the patch:
>
> - The `list` comm
On Mon, 25 Oct 2021 19:50:54 GMT, Chris Plummer wrote:
>> Based on my local testing it appears the localization system falls back to
>> the English values when entries are missing, so it appears the current
>> behavior does already match what you've suggested. However, I don't
>> understand t
On Tue, 19 Oct 2021 21:52:14 GMT, Ioi Lam wrote:
>>> Hi Jacob, this is not your fault, but the "zz help text" in the Chinese and
>>> Japanese versions are in a single huge line. This makes it impossible to
>>> see what you have changed in the GitHub diffs, and impossible to tell
>>> whether yo
x27;s out of range.
> - I don't speak Chinese or Japanese, so I've omitted localizations for the
> new messages in those locales. However, I updated the help text in both to
> include the new commands, with the descriptions left empty for now.
Jakob Cornell has updated th
x27;s out of range.
> - I don't speak Chinese or Japanese, so I've omitted localizations for the
> new messages in those locales. However, I updated the help text in both to
> include the new commands, with the descriptions left empty for now.
Jakob Cornell has updated th
On Wed, 20 Oct 2021 03:06:00 GMT, Jakob Cornell wrote:
>> This has been under discussion on and off for the past month or so on
>> serviceability-dev, and I think a CSR request is required, so this may be a
>> work in progress.
>>
>> Notes on the patch:
>>
On Tue, 19 Oct 2021 21:52:14 GMT, Ioi Lam wrote:
>>> Hi Jacob, this is not your fault, but the "zz help text" in the Chinese and
>>> Japanese versions are in a single huge line. This makes it impossible to
>>> see what you have changed in the GitHub diffs, and impossible to tell
>>> whether yo
On Thu, 23 Sep 2021 15:24:47 GMT, Jakob Cornell wrote:
>> This has been under discussion on and off for the past month or so on
>> serviceability-dev, and I think a CSR request is required, so this may be a
>> work in progress.
>>
>> Notes on the patch:
>>
x27;s out of range.
> - I don't speak Chinese or Japanese, so I've omitted localizations for the
> new messages in those locales. However, I updated the help text in both to
> include the new commands, with the descriptions left empty for now.
Jakob Cornell has updated th
On Thu, 30 Sep 2021 19:22:40 GMT, Chris Plummer wrote:
>> Hey Chris, is there any update on this? I've revised the Problem section so
>> I think we're waiting on the CSR ticket to be updated accordingly and for
>> someone to be assigned for the CSR review.
>
>> Hey Chris, is there any update o
On Thu, 23 Sep 2021 15:24:47 GMT, Jakob Cornell
wrote:
>> This has been under discussion on and off for the past month or so on
>> serviceability-dev, and I think a CSR request is required, so this may be a
>> work in progress.
>>
>> Notes on the patch:
>>
One section I'd like to see improved is the readability of the Problem section.
The middle sentence is long winded and hard to read. Perhaps a bullet list
would be better.
Right you are. I've revised it to use bullet points, and while I've added a
bit more detail to each they should be easie
On Thu, 23 Sep 2021 15:24:47 GMT, Jakob Cornell
wrote:
>> This has been under discussion on and off for the past month or so on
>> serviceability-dev, and I think a CSR request is required, so this may be a
>> work in progress.
>>
>> Notes on the patch:
>>
x27;s out of range.
> - I don't speak Chinese or Japanese, so I've omitted localizations for the
> new messages in those locales. However, I updated the help text in both to
> include the new commands, with the descriptions left empty for now.
Jakob Cornell has updated th
On Fri, 3 Sep 2021 05:05:34 GMT, Jakob Cornell
wrote:
>> This has been under discussion on and off for the past month or so on
>> serviceability-dev, and I think a CSR request is required, so this may be a
>> work in progress.
>>
>> Notes on the patch:
>>
On Fri, 3 Sep 2021 05:05:34 GMT, Jakob Cornell
wrote:
>> This has been under discussion on and off for the past month or so on
>> serviceability-dev, and I think a CSR request is required, so this may be a
>> work in progress.
>>
>> Notes on the patch:
>>
On Tue, 31 Aug 2021 18:54:18 GMT, Chris Plummer wrote:
>> Jakob Cornell has refreshed the contents of this pull request, and previous
>> commits have been removed. The incremental views will show differences
>> compared to the previous content of the PR.
>
> src/jdk.j
On Tue, 31 Aug 2021 00:36:51 GMT, Jakob Cornell
wrote:
>> This has been under discussion on and off for the past month or so on
>> serviceability-dev, and I think a CSR request is required, so this may be a
>> work in progress.
>>
>> Notes on the patch:
>>
x27;s out of range.
> - I don't speak Chinese or Japanese, so I've omitted localizations for the
> new messages in those locales. However, I updated the help text in both to
> include the new commands, with the descriptions left empty for now.
Jakob Cornell has updated th
Hi Magnus,
Works like a charm, and I'm able to set it in jtreg test config using
`-jdb.option="-J-D-..."'. Thanks!
Jakob
Hi all,
While working on changes for JBS 8271356 I spent some time testing on locales
other than en-US and found something a bit odd. I can override the system
default locale for JDB by setting the `LANG' environment variable (on Linux),
and I can override the system locale for the debuggee b
On Tue, 31 Aug 2021 00:36:51 GMT, Jakob Cornell
wrote:
>> This has been under discussion on and off for the past month or so on
>> serviceability-dev, and I think a CSR request is required, so this may be a
>> work in progress.
>>
>> Notes on the patch:
>>
x27;s out of range.
> - I don't speak Chinese or Japanese, so I've omitted localizations for the
> new messages in those locales. However, I updated the help text in both to
> include the new commands, with the descriptions left empty for now.
Jakob Cornell has refreshed
x27;s out of range.
> - I don't speak Chinese or Japanese, so I've omitted localizations for the
> new messages in those locales. However, I updated the help text in both to
> include the new commands, with the descriptions left empty for now.
Jakob Cornell has refreshed
Hi Alan,
Yep, that's along the lines of what I was thinking. Thanks for clarification,
and I'm glad we have potential interest in Jshell integration. I hope to have
a prototype ready for that in the coming weeks.
Jakob
Hi Alan,
Yes, this is just the empty command handling. I am personally interested in
Jline integration, but Chris is skeptical about the review prospects for that,
and since he's been helping me through the process I've limited the present
work. Maybe now that the patch for empty command han
I've finished a patch for this and created PR #5290. #5289 is also linked in
the JBS issue but can be ignored (closed due to wrong source repo branch).
Chris, would you be able to briefly review the PR/patch as necessary to see
whether we're ready to start the CSR process, and if so get that
x27;s out of range.
> - I don't speak Chinese or Japanese, so I've omitted localizations for the
> new messages in those locales. However, I updated the help text in both to
> include the new commands, with the descriptions left empty for now.
Jakob Cornell has refreshed
On Sat, 28 Aug 2021 05:37:23 GMT, Jakob Cornell
wrote:
> This has been under discussion on and off for the past month or so on
> serviceability-dev, and I think a CSR request is required, so this may be a
> work in progress.
>
> Notes on the patch:
>
> - The `list` comm
This has been under discussion on and off for the past month or so on
serviceability-dev, and I think a CSR request is required, so this may be a
work in progress.
Notes on the patch:
- The `list` command previously marked a line in each listing with `=>`. In a
bare `list` this is the next li
This has been under discussion on and off for the past month or so on
serviceability-dev, and I think a CSR request is required, so this may be a
work in progress.
Notes on the patch:
- The `list` command previously marked a line in each listing with `=>`. In a
bare `list` this is the next li
Okay thanks, that's useful advice. I don't think I'll mind reworking my
changes after the fact, so why don't I post an update here once the PR is done
and we'll open a CSR request then.
Jakob
Yeah, `repeat on/off' seems a bit better to me too. With the command (and the
option to use it in a jdbrc) I don't think a command-line option would provide
much use, so I'll propose implementing the command alone.
Does this wrap up the pre-CSR discussion? If so, would you like to see a PR
b
Hi Chris,
Yeah, I think I agree with you, but I seem to recall a few people having the
opposite opinion, so I've been a bit confused about how to proceed. However,
given that we'll be keeping the empty command handling off by default I don't
think it's possible for the change to disrupt anyth
Well I let this thread go quiet for a few weeks, but I did want to follow up on
the new input we got in August. It sounds like multiple people are concerned
about the cost of reviewing a change to JDB that implements GDB's empty command
handling, but a patch that adds Jline line editing and hi
I'm a bit dubious about changing jdb to have blank lines repeat like gdb. Hard
to know if users of jdb expect that behavior and also it feels like basic
history navigation would be better.
Well that would be addressed by our plan to leave the functionality off by
default; I believe enable/dis
Hi Alan, thanks for the input.
The gdb behavior is context dependent and not clear to me that it's worth
trying to add it to jdb.
Could you provide some more detail about the context upon which GDB's behavior
depends? And are you saying that my proposed changes aren't worth adding, or
that
Hi folks,
I've been looking to improve the usability of JDB a bit by imitating GDB's
handling of empty commands. If the most recent command is one that it makes
sense to invoke repeatedly, GDB does so. Also, when the `list' command is
repeated (by either typing it out or issuing an empty com
Thanks for the help Chris. With the JBS ticket set up are we ready for a PR to
be opened, or should I wait for the CSR review?
Jakob
Oops, the mailman didn't link this to the previous thread:
https://mail.openjdk.java.net/pipermail/serviceability-dev/2021-June/038226.html
Hi all,
I've prepared a patch that makes JDB rerun the previous command when nothing is
entered at the prompt. Looks like the next step is to open a JBS issue so I
can submit a PR, but as a new contributor I don't have credentials to open a
JBS issue. Is anybody willing to sponsor my change?
53 matches
Mail list logo
