Re: RFR: 8278423: ExtendedDTraceProbes should be deprecated [v9]

2022-02-11 Thread Tobias Hartmann
On Fri, 11 Feb 2022 08:52:48 GMT, Emanuel Peter wrote: >> Deprecated ExtendedDTraceProbes. >> Edited help messages and man pages accordingly, added the 3 flags to man >> pages. >> Added flag to VMDeprecatedOptions test. >> Replaced the flag with 3 flags in SDTProbesGNULinuxTest.java. >> >> Chec

Re: RFR: 8275729: Qualified method names in CodeHeap Analytics

2021-11-02 Thread Tobias Hartmann
On Mon, 1 Nov 2021 20:51:39 GMT, Evgeny Astigeevich wrote: > This PR changes nmethods names in `METHOD NAMES for CodeHeap` section to be > qualified. > Testing: > - `make test TEST="gtest"`: Passed > - `make run-test TEST="tier1"`: Passed > - `make run-test TEST="tier2"`: Passed > - `make run

Re: RFR: 8261447: MethodInvocationCounters frequently run into overflow [v8]

2021-03-01 Thread Tobias Hartmann
On Thu, 25 Feb 2021 09:01:10 GMT, Lutz Schmidt wrote: >> Dear community, >> may I please request reviews for this fix, improving the usefulness of >> method invocation counters. >> - aggregation counters are retyped as uint64_t, shifting the overflow >> probability way out (> 500 years in case

Re: RFR(S): 8225388: Running jcmd Compiler.CodeHeap_Analytics all 0 cause crash.

2019-06-07 Thread Tobias Hartmann
Hi Leonid, this looks good to me! Please remove the extra whitespace at the end of compileBroker.hpp:420 before the ")". No new webrev required. Thanks, Tobias On 07.06.19 02:36, Leonid Mesnik wrote: > Hi > > Could you please review following fix which verify parameter for > Compiler.CodeHeap

Re: RFR (S) 8213721 : [Graal] Tests vmTestbase/nsk/stress/except/except* may be encountering SEGV during out-of-memory conditions

2018-11-20 Thread Tobias Hartmann
Hi Jc, this looks good to me as well! Best regards, Tobias On 21.11.18 05:14, serguei.spit...@oracle.com wrote: > Hi Jc, > > It looks good to me too. > > Thanks, > Serguei > > > On 11/20/18 20:04, David Holmes wrote: >> Re-directing to hotspot-runtime-dev ... >> >> On 21/11/2018 1:38 pm, JC

Re: [9] RFR(S): 8080999: MemoryPoolMXBean.getUsageThresholdCount() returns incorrect value

2015-09-09 Thread Tobias Hartmann
[CC'ing runtime for wider audience] On 03.09.2015 11:33, Tobias Hartmann wrote: > Hi, > > please review the following patch. > > https://bugs.openjdk.java.net/browse/JDK-8080999 > http://cr.openjdk.java.net/~thartmann/8080999/webrev.00/ > > Problem: > The

[9] RFR(S): 8080999: MemoryPoolMXBean.getUsageThresholdCount() returns incorrect value

2015-09-03 Thread Tobias Hartmann
Hi, please review the following patch. https://bugs.openjdk.java.net/browse/JDK-8080999 http://cr.openjdk.java.net/~thartmann/8080999/webrev.00/ Problem: The compiler test [1] sets a maximum usage threshold for a code heap memory pool, allocates enough memory to hit the threshold and checks if

Re: RFR(S): 8071999: SA's buildreplayjars fail with exception

2015-02-04 Thread Tobias Hartmann
On 04.02.2015 17:16, Christian Thalinger wrote: > Since you’re saying it only fixes it partially should we file a followup bug > and maybe leave a comment behind? I think this one is related: https://bugs.openjdk.java.net/browse/JDK-8015848 Best, Tobias > >> On Feb 4, 2015, at 7:04 AM, Roland