Hi Jc, this looks good to me as well!
Best regards, Tobias On 21.11.18 05:14, serguei.spit...@oracle.com wrote: > Hi Jc, > > It looks good to me too. > > Thanks, > Serguei > > > On 11/20/18 20:04, David Holmes wrote: >> Re-directing to hotspot-runtime-dev ... >> >> On 21/11/2018 1:38 pm, JC Beyler wrote: >>> Hi all, >>> >>> Could I get a review for this small change for the except* tests: >>> >>> Webrev: http://cr.openjdk.java.net/~jcbeyler/8213721/webrev.00/ >>> Bug: https://bugs.openjdk.java.net/browse/JDK-8213721 >>> >>> The bug contains a good explanation of why this is required. >> >> This looks good to me - but then I'm biased :) >> >> Thanks, >> David >> >>> After the webrev, the tests no longer fail due to a SIGSEV with the flags: >>> >>> -XX:+UnlockExperimentalVMOptions -XX:+EnableJVMCI -XX:+UseJVMCICompiler >>> -XX:+TraceExceptions >>> -Dgraal.PrintCompilation=true -XX:+PrintCompilation -XX:+TraceDeoptimization >>> >>> (except010.java failed due to a timeout and except004.java failed due to >>> an OOME from a Graal >>> thread). >>> >>> Thanks, >>> Jc >
