Re: PING: RFR : JDK-8164730 - Make it clear that 'cl' parameter passed to RMIConnector.OISWL is never null.

2016-09-02 Thread Daniel Fuchs
Hi Amit, I hadn't look at the test too closely. If you're about to fix raw types then you should fix Constructor as well - and try to compile your test with -Xlint:all to make sure nothing else has escaped :-) No need to send a new webrev if the compiler is happy. cheers, -- daniel On

RE: PING: RFR : JDK-8164730 - Make it clear that 'cl' parameter passed to RMIConnector.OISWL is never null.

2016-09-02 Thread Amit Sapre
Thanks Alan for pointing this out. Incorporated your comments in this webrev http://cr.openjdk.java.net/~jgeorge/sponsorships/8164730/webrev.01/ Thanks, Amit From: Alan Bateman Sent: Thursday, September 01, 2016 1:46 PM To: Amit Sapre; serviceability-dev Subject: Re: PING: RFR :

Re: PING: RFR : JDK-8164730 - Make it clear that 'cl' parameter passed to RMIConnector.OISWL is never null.

2016-09-01 Thread Alan Bateman
On 01/09/2016 07:01, Amit Sapre wrote: Gentle reminder ! Bug Id : https://bugs.openjdk.java.net/browse/JDK-8164730 Webrev : http://cr.openjdk.java.net/~jgeorge/sponsorships/8164730/webrev.00/ Looks okay to me. A

Re: PING: RFR : JDK-8164730 - Make it clear that 'cl' parameter passed to RMIConnector.OISWL is never null.

2016-09-01 Thread Daniel Fuchs
Hi Amit, Looks good to me! best regards, -- daniel On 01/09/16 07:01, Amit Sapre wrote: Gentle reminder ! *From:*Amit Sapre *Sent:* Tuesday, August 30, 2016 11:33 AM *To:* serviceability-dev *Subject:* RFR : JDK-8164730 - Make it clear that 'cl' parameter passed to RMIConnector.OISWL is