Re: RFR : JDK-7132577 - javax/management/monitor/MultiMonitorTest.java fails in JDK8-B22

2017-02-23 Thread Harsha Wardhana B
-Original Message- From: Amit Sapre Sent: Thursday, February 23, 2017 11:55 AM To: David Holmes; serviceability-dev@openjdk.java.net; Harsha Wardhana B Subject: RE: RFR : JDK-7132577 - javax/management/monitor/MultiMonitorTest.java fails in JDK8-B22 Hello, In a messy run of this test case

Re: RFR : JDK-7132577 - javax/management/monitor/MultiMonitorTest.java fails in JDK8-B22

2017-02-22 Thread David Holmes
Holmes; serviceability-dev@openjdk.java.net; Harsha Wardhana B Subject: RE: RFR : JDK-7132577 - javax/management/monitor/MultiMonitorTest.java fails in JDK8-B22 Hello, In a messy run of this test case, the number of prints for the counter values will be 240 (120 seconds is jtreg timeout) Wi

RE: RFR : JDK-7132577 - javax/management/monitor/MultiMonitorTest.java fails in JDK8-B22

2017-02-22 Thread Amit Sapre
11:55 AM > To: David Holmes; serviceability-dev@openjdk.java.net; Harsha Wardhana > B > Subject: RE: RFR : JDK-7132577 - > javax/management/monitor/MultiMonitorTest.java fails in JDK8-B22 > > Hello, > > In a messy run of this test case, > the number of prints for

Re: RFR : JDK-7132577 - javax/management/monitor/MultiMonitorTest.java fails in JDK8-B22

2017-02-22 Thread David Holmes
ject: Re: RFR : JDK-7132577 - javax/management/monitor/MultiMonitorTest.java fails in JDK8-B22 Hi Amit, On 23/02/2017 12:18 AM, Harsha Wardhana B wrote: Hi Amit, There is no need to wait in a loop to check we have not received any notifications. Without starting the monitors, the listener c

RE: RFR : JDK-7132577 - javax/management/monitor/MultiMonitorTest.java fails in JDK8-B22

2017-02-22 Thread Amit Sapre
openjdk.java.net; Sapre Amit > Cc: Harsha Wardhana B > Subject: Re: RFR : JDK-7132577 - > javax/management/monitor/MultiMonitorTest.java fails in JDK8-B22 > > Hi Amit, > > On 23/02/2017 12:18 AM, Harsha Wardhana B wrote: > > Hi Amit, > > > > There is no n

Re: RFR : JDK-7132577 - javax/management/monitor/MultiMonitorTest.java fails in JDK8-B22

2017-02-22 Thread David Holmes
Hi Amit, On 23/02/2017 12:18 AM, Harsha Wardhana B wrote: Hi Amit, There is no need to wait in a loop to check we have not received any notifications. Without starting the monitors, the listener count will be zero. The first part of diff L116-L121 could be left as is. Agreed. By relying

Re: RFR : JDK-7132577 - javax/management/monitor/MultiMonitorTest.java fails in JDK8-B22

2017-02-22 Thread Harsha Wardhana B
Hi Amit, There is no need to wait in a loop to check we have not received any notifications. Without starting the monitors, the listener count will be zero. The first part of diff L116-L121 could be left as is. By relying on Jtreg timeout for receiving notifications, we will be unable to

Re: RFR : JDK-7132577 - javax/management/monitor/MultiMonitorTest.java fails in JDK8-B22

2017-02-22 Thread Erik Gahlin
Looks good. Erik Hello, Please review this test bug fix which eliminates test case’s own timeout mechanism to default jtreg timeout. Bug ID : https://bugs.openjdk.java.net/browse/JDK-7132577 Webrev : http://cr.openjdk.java.net/~asapre/webrev/2017/JDK-7132577/webrev.00/