Re: RFR : JDK-8162702 - com.sun.management.internal.GcInfoBuilder.getPoolNames should not return reference of it's private member

2016-08-01 Thread David Holmes
- com.sun.management.internal.GcInfoBuilder.getPoolNames should not return reference of it's private member Hi Amit, On 29/07/2016 6:20 PM, Amit Sapre wrote: Hello, Please review this small fix. Bug : https://bugs.openjdk.java.net/browse/JDK-8162702 Webrev : http://cr.openjdk.java.net/~hb/sponsorship/8162702/webrev.00

RE: RFR : JDK-8162702 - com.sun.management.internal.GcInfoBuilder.getPoolNames should not return reference of it's private member

2016-08-01 Thread Amit Sapre
Subject: Re: RFR : JDK-8162702 - com.sun.management.internal.GcInfoBuilder.getPoolNames should not return reference of it's private member Hi Amit, On 29/07/2016 6:20 PM, Amit Sapre wrote: > Hello, > > Please review this small fix. > > Bug : https://bugs.openjdk.java.net/bro

Re: RFR : JDK-8162702 - com.sun.management.internal.GcInfoBuilder.getPoolNames should not return reference of it's private member

2016-07-31 Thread David Holmes
Hi Amit, On 29/07/2016 6:20 PM, Amit Sapre wrote: Hello, Please review this small fix. Bug : https://bugs.openjdk.java.net/browse/JDK-8162702 Webrev : http://cr.openjdk.java.net/~hb/sponsorship/8162702/webrev.00/ This is good defensive programming practice for exported API's, but in this