Re: RFR(S): 8195109: ServiceUtil::visible_oop is not needed anymore

2018-03-21 Thread serguei.spit...@oracle.com
Hi Chris, It looks good. Thanks, Serguei On 3/20/18 12:39, Chris Plummer wrote: Hi, New webrev: http://cr.openjdk.java.net/~cjplummer/8195109/webrev.01/index.html There was a build failure on solaris-sparc in threadSMR.cpp. References to the Copy class were producing "unresolved symbol"

Re: RFR(S): 8195109: ServiceUtil::visible_oop is not needed anymore

2018-03-21 Thread Stefan Karlsson
Looks good. StefanK On 2018-03-20 20:39, Chris Plummer wrote: Hi, New webrev: http://cr.openjdk.java.net/~cjplummer/8195109/webrev.01/index.html There was a build failure on solaris-sparc in threadSMR.cpp. References to the Copy class were producing "unresolved symbol" errors.

Re: RFR(S): 8195109: ServiceUtil::visible_oop is not needed anymore

2018-03-20 Thread Chris Plummer
Hi, New webrev: http://cr.openjdk.java.net/~cjplummer/8195109/webrev.01/index.html There was a build failure on solaris-sparc in threadSMR.cpp. References to the Copy class were producing "unresolved symbol" errors. threadSMR.cpp includes threadService.hpp, which no longer includes

Re: RFR(S): 8195109: ServiceUtil::visible_oop is not needed anymore

2018-03-20 Thread Stefan Karlsson
Looks good to me. StefanK On 2018-03-20 01:48, Chris Plummer wrote: Hello, Please review the following: https://bugs.openjdk.java.net/browse/JDK-8195109 http://cr.openjdk.java.net/~cjplummer/8195109/webrev.00/index.html The assert I added to make sure this is safe has been in place in

RFR(S): 8195109: ServiceUtil::visible_oop is not needed anymore

2018-03-19 Thread Chris Plummer
Hello, Please review the following: https://bugs.openjdk.java.net/browse/JDK-8195109 http://cr.openjdk.java.net/~cjplummer/8195109/webrev.00/index.html The assert I added to make sure this is safe has been in place in jdk/jdk for almost 3 weeks with no issues (longer in jdk/hs). The webrev