Re: RFR: 8204170: MXBeanException.java assumes the existence of a pool that doesn't support usage threshold

2018-05-31 Thread Stefan Karlsson
On 2018-05-31 19:04, mandy chung wrote: On 5/31/18 10:01 AM, Stefan Karlsson wrote: Hi Mandy, On 2018-05-31 18:44, mandy chung wrote: Hi Stefan, I think a better fix is to find another operation that will throw an exception.  ThreadMXBean::getThreadInfo throws IAE and it can be a candidat

Re: RFR: 8204170: MXBeanException.java assumes the existence of a pool that doesn't support usage threshold

2018-05-31 Thread mandy chung
On 5/31/18 10:01 AM, Stefan Karlsson wrote: Hi Mandy, On 2018-05-31 18:44, mandy chung wrote: Hi Stefan, I think a better fix is to find another operation that will throw an exception.  ThreadMXBean::getThreadInfo throws IAE and it can be a candidate. Thanks for taking a look at this pa

Re: RFR: 8204170: MXBeanException.java assumes the existence of a pool that doesn't support usage threshold

2018-05-31 Thread Stefan Karlsson
Hi Mandy, On 2018-05-31 18:44, mandy chung wrote: Hi Stefan, I think a better fix is to find another operation that will throw an exception.  ThreadMXBean::getThreadInfo throws IAE and it can be a candidate. Thanks for taking a look at this patch. The test checks a number of different oper

Re: RFR: 8204170: MXBeanException.java assumes the existence of a pool that doesn't support usage threshold

2018-05-31 Thread mandy chung
Hi Stefan, I think a better fix is to find another operation that will throw an exception. ThreadMXBean::getThreadInfo throws IAE and it can be a candidate. Mandy On 5/31/18 6:38 AM, Stefan Karlsson wrote: Hi all, Please review this patch to deal with the case when all available MemoryPo

Re: RFR: 8204170: MXBeanException.java assumes the existence of a pool that doesn't support usage threshold

2018-05-31 Thread Stefan Karlsson
Thanks, Erik. StefanK On 2018-05-31 16:27, Erik Österlund wrote: Hi Stefan, Looks good. Thanks, /Erik On 2018-05-31 15:38, Stefan Karlsson wrote: Hi all, Please review this patch to deal with the case when all available MemoryPoolMXBeans support usage thresholds. http://cr.openjdk.java.

Re: RFR: 8204170: MXBeanException.java assumes the existence of a pool that doesn't support usage threshold

2018-05-31 Thread Erik Österlund
Hi Stefan, Looks good. Thanks, /Erik On 2018-05-31 15:38, Stefan Karlsson wrote: Hi all, Please review this patch to deal with the case when all available MemoryPoolMXBeans support usage thresholds. http://cr.openjdk.java.net/~stefank/8204170/webrev.01/ https://bugs.openjdk.java.net/browse

RFR: 8204170: MXBeanException.java assumes the existence of a pool that doesn't support usage threshold

2018-05-31 Thread Stefan Karlsson
Hi all, Please review this patch to deal with the case when all available MemoryPoolMXBeans support usage thresholds. http://cr.openjdk.java.net/~stefank/8204170/webrev.01/ https://bugs.openjdk.java.net/browse/JDK-8204170 The tests searches for a MemoryPoolMXBean that returns false for isUsa