RE: RFR: 8230857: Avoid reflection in sun.tools.common.ProcessHelper

2019-09-23 Thread Langer, Christoph
.net> > Subject: Re: RFR: 8230857: Avoid reflection in > sun.tools.common.ProcessHelper > > Hi Christoph, > > The fix looks good to me. > > Thanks, > Serguei > > > On 9/20/19 14:13, Langer, Christoph wrote: > > Thanks David! > >

RE: RFR: 8230857: Avoid reflection in sun.tools.common.ProcessHelper

2019-09-20 Thread Langer, Christoph
build-dev > Subject: Re: RFR: 8230857: Avoid reflection in > sun.tools.common.ProcessHelper > > Hi Christoph, > > On 19/09/2019 7:47 pm, Langer, Christoph wrote: > > Hi, > > > > @Erik, Magnus: Thanks for stepping in to explain things. > > > &g

Re: RFR: 8230857: Avoid reflection in sun.tools.common.ProcessHelper

2019-09-19 Thread David Holmes
Joelsson ; Magnus Ihse Bursie ; Langer, Christoph ; OpenJDK Serviceability ; build-dev Subject: Re: RFR: 8230857: Avoid reflection in sun.tools.common.ProcessHelper Hi Erik, Thanks for the additional details (I can't say I fully understand them :) ). David On 17/09/2019 11:39 pm, Erik Joelsson

RE: RFR: 8230857: Avoid reflection in sun.tools.common.ProcessHelper

2019-09-19 Thread Langer, Christoph
David Holmes > Sent: Mittwoch, 18. September 2019 01:13 > To: Erik Joelsson ; Magnus Ihse Bursie > ; Langer, Christoph > ; OpenJDK Serviceability d...@openjdk.java.net>; build-dev > Subject: Re: RFR: 8230857: Avoid reflection in > sun.tools.common.ProcessHelper > > Hi Eri

Re: RFR: 8230857: Avoid reflection in sun.tools.common.ProcessHelper

2019-09-17 Thread David Holmes
Hi Erik, Thanks for the additional details (I can't say I fully understand them :) ). David On 17/09/2019 11:39 pm, Erik Joelsson wrote: Hello, On 2019-09-17 05:59, David Holmes wrote: Hi Magnus, On 17/09/2019 9:26 pm, Magnus Ihse Bursie wrote: On 2019-09-17 01:01, David Holmes wrote: Hi

Re: RFR: 8230857: Avoid reflection in sun.tools.common.ProcessHelper

2019-09-17 Thread Erik Joelsson
Hello, On 2019-09-17 05:59, David Holmes wrote: Hi Magnus, On 17/09/2019 9:26 pm, Magnus Ihse Bursie wrote: On 2019-09-17 01:01, David Holmes wrote: Hi Christoph, Sorry for the delay getting back you. cc'd build-dev to get some clarification on the below ... On 12/09/2019 7:30 pm, Langer,

Re: RFR: 8230857: Avoid reflection in sun.tools.common.ProcessHelper

2019-09-17 Thread David Holmes
Hi Magnus, On 17/09/2019 9:26 pm, Magnus Ihse Bursie wrote: On 2019-09-17 01:01, David Holmes wrote: Hi Christoph, Sorry for the delay getting back you. cc'd build-dev to get some clarification on the below ... On 12/09/2019 7:30 pm, Langer, Christoph wrote: Hi David, please review an

Re: RFR: 8230857: Avoid reflection in sun.tools.common.ProcessHelper

2019-09-17 Thread Magnus Ihse Bursie
On 2019-09-17 01:01, David Holmes wrote: Hi Christoph, Sorry for the delay getting back you. cc'd build-dev to get some clarification on the below ... On 12/09/2019 7:30 pm, Langer, Christoph wrote: Hi David, please review an enhancement which I've identified when working with

Re: RFR: 8230857: Avoid reflection in sun.tools.common.ProcessHelper

2019-09-16 Thread David Holmes
Hi Christoph, Sorry for the delay getting back you. cc'd build-dev to get some clarification on the below ... On 12/09/2019 7:30 pm, Langer, Christoph wrote: Hi David, please review an enhancement which I've identified when working with Processhelper for JDK-8230850. I noticed that

RE: RFR: 8230857: Avoid reflection in sun.tools.common.ProcessHelper

2019-09-12 Thread Langer, Christoph
Hi David, > > please review an enhancement which I've identified when working with > > Processhelper for JDK-8230850. > > > > I noticed that ProcessHelper is an interface in common code with a > > static method that would lookup the actual platform implementation via > > reflection. This seems a

Re: RFR: 8230857: Avoid reflection in sun.tools.common.ProcessHelper

2019-09-11 Thread David Holmes
Hi Christoph, On 12/09/2019 8:05 am, Langer, Christoph wrote: Hi, please review an enhancement which I’ve identified when working with Processhelper for JDK-8230850. I noticed that ProcessHelper is an interface in common code with a static method that would lookup the actual platform

RFR: 8230857: Avoid reflection in sun.tools.common.ProcessHelper

2019-09-11 Thread Langer, Christoph
Hi, please review an enhancement which I've identified when working with Processhelper for JDK-8230850. I noticed that ProcessHelper is an interface in common code with a static method that would lookup the actual platform implementation via reflection. This seems a little cumbersome since we