Thanks Kevin! I will push it.
Yasumasa
On 2020/03/27 16:42, Kevin Walls wrote:
Great, thanks Yasumasa. Don't worry, the language is not just you - it's often
unclear in other places. 8-) Sorry maybe I should have said you didn't need to
resubmit the webrev for that, but a retest is nice.
Great, thanks Yasumasa. Don't worry, the language is not just you -
it's often unclear in other places. 8-) Sorry maybe I should have said
you didn't need to resubmit the webrev for that, but a retest is nice.
Thanks
Kevin
On 27/03/2020 02:49, Yasumasa Suenaga wrote:
All tests on submit
All tests on submit repo has been passed.
(mach5-one-ysuenaga-JDK-8240956-3-20200327-0003-9753265)
Yasumasa
On 2020/03/27 9:07, Yasumasa Suenaga wrote:
Thanks Kevin and Serguei! and sorry for my English...
I uploaded new webrev:
http://cr.openjdk.java.net/~ysuenaga/JDK-8240956/webrev.05/
Thanks Kevin and Serguei! and sorry for my English...
I uploaded new webrev:
http://cr.openjdk.java.net/~ysuenaga/JDK-8240956/webrev.05/
Diff from webrev.04 is here:
http://hg.openjdk.java.net/jdk/submit/rev/d5f400d70e94
Thanks,
Yasumasa
On 2020/03/27 2:53, serguei.spit...@oracle.com
Hi Kevin,
Nice catch with the name "lastFrame".
I was also confused when reviewed this but did not come up with
something better.
Thanks,
Serguei
On 3/26/20 10:40, Kevin Walls wrote:
Hi Yasumasa,
Oops, didn't catch this - I also had done some manual testing and in
mach5 but clearly not
Hi Yasumasa,
Oops, didn't catch this - I also had done some manual testing and in
mach5 but clearly not enough.
Generally I think this looks good.
"lastFrame" can mean last as in final, or last as in previous. "last" is
one of those annoying English words. Here it means final, if we get an
Thanks Serguei!
I will push it when I get second reviewer.
Yasumasa
On 2020/03/25 1:39, serguei.spit...@oracle.com wrote:
Hi Yasumasa,
I'm okay with this update.
My mach5 test run for this patch is passed.
Thanks,
Serguei
On 3/23/20 17:08, Yasumasa Suenaga wrote:
Hi Serguei,
Thanks
Hi Yasumasa,
I'm okay with this update.
My mach5 test run for this patch is passed.
Thanks,
Serguei
On 3/23/20 17:08, Yasumasa Suenaga wrote:
Hi Serguei,
Thanks for your comment!
I uploaded new webrev:
http://cr.openjdk.java.net/~ysuenaga/JDK-8240956/webrev.04/
Also I pushed it to
Hi Serguei,
Thanks for your comment!
I uploaded new webrev:
http://cr.openjdk.java.net/~ysuenaga/JDK-8240956/webrev.04/
Also I pushed it to submit repo:
http://hg.openjdk.java.net/jdk/submit/rev/fade6a949bd1
On 2020/03/24 7:39, serguei.spit...@oracle.com wrote:
Hi Yasumasa,
The mach5
Hi Yasumasa,
The mach5 tier5 testing looks good.
The serviceability/sa/ClhsdbPstack.java
is failed without fix and is not failed with it.
Thanks,
Serguei
On 3/23/20 10:18, serguei.spit...@oracle.com wrote:
Hi Yasumasa,
I looked at you changes.
It is hard to understand if this fully solves the issue.
http://cr.openjdk.java.net/~ysuenaga/JDK-8240956/webrev.03/src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/debugger/linux/amd64/LinuxAMD64CFrame.java.frames.html
Thanks Chris!
I'm waiting for reviewers for this change.
Yasumasa
On 2020/03/21 4:23, Chris Plummer wrote:
Hi Yasumasa,
The failure is due to JDK-8231634, so not something you need to worry about.
thanks,
Chris
On 3/20/20 2:45 AM, Yasumasa Suenaga wrote:
Hi Chris,
I uploaded new webrev
Hi Yasumasa,
The failure is due to JDK-8231634, so not something you need to worry about.
thanks,
Chris
On 3/20/20 2:45 AM, Yasumasa Suenaga wrote:
Hi Chris,
I uploaded new webrev which includes reverting change for ProblemList:
http://cr.openjdk.java.net/~ysuenaga/JDK-8240956/webrev.03/
Hi Chris,
I uploaded new webrev which includes reverting change for ProblemList:
http://cr.openjdk.java.net/~ysuenaga/JDK-8240956/webrev.03/
I tested it on submit repo
(mach5-one-ysuenaga-JDK-8240956-2-20200320-0814-9586301),
but it has failed in ClhsdbJstackXcompStress.java.
However I
Hi Yasumasa,
The test has been problem listed so please add undoing this to your
webrev. Here's the diff that problem listed it:
diff --git a/test/hotspot/jtreg/ProblemList.txt
b/test/hotspot/jtreg/ProblemList.txt
--- a/test/hotspot/jtreg/ProblemList.txt
+++
Hi all,
This webrev has passed submit repo
(mach5-one-ysuenaga-JDK-8240956-20200316-0924-9487169) and additional tests.
So please review it:
JBS: https://bugs.openjdk.java.net/browse/JDK-8240956
webrev: http://cr.openjdk.java.net/~ysuenaga/JDK-8240956/webrev.02/
Thanks,
Yasumasa
On
On 16/03/2020 9:46 pm, David Holmes wrote:
On 16/03/2020 7:20 pm, Yasumasa Suenaga wrote:
Hi David,
I missed loop condition, so I fixed it and pushed to submit repo.
Could you try again?
http://hg.openjdk.java.net/jdk/submit/rev/9c148df17f23
webrev is here:
Thank you so much, David!
Yasumasa
On 2020/03/16 21:01, David Holmes wrote:
On 16/03/2020 9:46 pm, David Holmes wrote:
On 16/03/2020 7:20 pm, Yasumasa Suenaga wrote:
Hi David,
I missed loop condition, so I fixed it and pushed to submit repo.
Could you try again?
On 16/03/2020 7:20 pm, Yasumasa Suenaga wrote:
Hi David,
I missed loop condition, so I fixed it and pushed to submit repo.
Could you try again?
http://hg.openjdk.java.net/jdk/submit/rev/9c148df17f23
webrev is here:
http://cr.openjdk.java.net/~ysuenaga/JDK-8240956/webrev.02/
Test job
Hi David,
I missed loop condition, so I fixed it and pushed to submit repo.
Could you try again?
http://hg.openjdk.java.net/jdk/submit/rev/9c148df17f23
webrev is here:
http://cr.openjdk.java.net/~ysuenaga/JDK-8240956/webrev.02/
Thanks a lot!
Yasumasa
On 2020/03/16 16:17, David Holmes
Sorry it is still crashing.
#
# A fatal error has been detected by the Java Runtime Environment:
#
# SIGSEGV (0xb) at pc=0x7f98ec01e94e, pid=13702, tid=13704
#
# JRE version: Java(TM) SE Runtime Environment (15.0) (fastdebug build
15-internal+0-2020-03-16-0640217.suenaga.source)
# Java VM:
On 16/03/2020 4:51 pm, Yasumasa Suenaga wrote:
On 2020/03/16 15:43, Chris Plummer wrote:
BTW, if you submit it to the submit repo, we can then go and run
additional internal tests (and even more builds) using that job.
Thanks for that tip Chris!
I've pushed the change to submit repo, but
On 3/15/20 11:51 PM, Yasumasa Suenaga wrote:
On 2020/03/16 15:43, Chris Plummer wrote:
BTW, if you submit it to the submit repo, we can then go and run
additional internal tests (and even more builds) using that job.
I've pushed the change to submit repo, but I've not yet received the
On 2020/03/16 15:43, Chris Plummer wrote:
BTW, if you submit it to the submit repo, we can then go and run additional
internal tests (and even more builds) using that job.
I've pushed the change to submit repo, but I've not yet received the result.
I will share you when I get job ID.
BTW, if you submit it to the submit repo, we can then go and run
additional internal tests (and even more builds) using that job.
Chris
On 3/15/20 11:36 PM, Yasumasa Suenaga wrote:
Hi David,
Thank you for testing it.
I updated webrev to avoid bailout to Java frame when DWARF has
language
Hi David,
Thank you for testing it.
I updated webrev to avoid bailout to Java frame when DWARF has language
personality routine or LSDA.
Could you try it?
http://cr.openjdk.java.net/~ysuenaga/JDK-8240956/webrev.01/
It works well on my Fedora 31 and Oracle Linux 7.7 .
I've pushed it to
Correction ...
On 16/03/2020 12:53 pm, David Holmes wrote:
On 16/03/2020 12:17 pm, David Holmes wrote:
Hi Yasumasa,
I can't review this as I know nothing about the code, but I'm putting
the patch through our internal testing.
Sorry but the crashes still exist:
#
# A fatal error has been
On 16/03/2020 12:17 pm, David Holmes wrote:
Hi Yasumasa,
I can't review this as I know nothing about the code, but I'm putting
the patch through our internal testing.
Sorry but the crashes still exist:
#
# A fatal error has been detected by the Java Runtime Environment:
#
# SIGSEGV (0xb)
Hi Yasumasa,
I can't review this as I know nothing about the code, but I'm putting
the patch through our internal testing.
David
On 14/03/2020 11:35 am, Yasumasa Suenaga wrote:
Hi all,
Please review this change:
JBS: https://bugs.openjdk.java.net/browse/JDK-8240956
webrev:
Hi all,
Please review this change:
JBS: https://bugs.openjdk.java.net/browse/JDK-8240956
webrev: http://cr.openjdk.java.net/~ysuenaga/JDK-8240956/webrev.00/
JDK-8234624 introduced DWARF parser in SA for unwinding native frames in jstack
mixed mode.
However some error has seen
30 matches
Mail list logo
