Re: RFR: 8242328: Update mentions of ThreadMBean to ThreadMXBean

2020-06-12 Thread Mandy Chung
On 6/12/20 12:27 AM, David Holmes wrote: No. There is no MXBeanServer. This attempts to shed some light on everything: https://docs.oracle.com/en/java/javase/14/docs/api/java.management/javax/management/MXBean.html "An MXBean is a kind of MBean. An MXBean object can be registered

Re: RFR: 8242328: Update mentions of ThreadMBean to ThreadMXBean

2020-06-12 Thread David Holmes
On 12/06/2020 4:02 pm, serguei.spit...@oracle.com wrote: Hi Leonid, It looks okay to me. > I find this whole MBean vs MXBean terminology very confusing. :) Me too. :) For instance, I see some references to MBeanServer (should they also be replaced with MXBeanServer?): No. There is no

Re: RFR: 8242328: Update mentions of ThreadMBean to ThreadMXBean

2020-06-12 Thread serguei.spit...@oracle.com
Hi Leonid, It looks okay to me. > I find this whole MBean vs MXBean terminology very confusing. :) Me too. :) For instance, I see some references to MBeanServer (should they also be replaced with MXBeanServer?):

Re: RFR: 8242328: Update mentions of ThreadMBean to ThreadMXBean

2020-06-11 Thread Igor Ignatyev
LGTM -- Igor > On Jun 11, 2020, at 2:09 PM, Leonid Mesnik wrote: > > Hi > > Could you review following fix which change leftovers of ThreadMBean to > ThreadMXBean. In the most cases the comments were updated only. > > webrev: http://cr.openjdk.java.net/~lmesnik/8242328/webrev.00/ > > bug:

Re: RFR: 8242328: Update mentions of ThreadMBean to ThreadMXBean

2020-06-11 Thread David Holmes
Hi Leonid, On 12/06/2020 7:09 am, Leonid Mesnik wrote: Hi Could you review following fix which change leftovers of ThreadMBean to ThreadMXBean. In the most cases the comments were updated only. webrev: http://cr.openjdk.java.net/~lmesnik/8242328/webrev.00/ Looks good! I find this whole

RFR: 8242328: Update mentions of ThreadMBean to ThreadMXBean

2020-06-11 Thread Leonid Mesnik
Hi Could you review following fix which change leftovers of ThreadMBean to ThreadMXBean. In the most cases the comments were updated only. webrev: http://cr.openjdk.java.net/~lmesnik/8242328/webrev.00/ bug: https://bugs.openjdk.java.net/browse/JDK-8242328 Leonid