Hi Chris and David,
Thank you for reviewing this change.
--Best regards,
Daniil
On 5/26/20, 4:33 PM, "Chris Plummer" wrote:
Hi Daniil,
Looks good.
thanks,
Chris
On 5/26/20 10:46 AM, Daniil Titov wrote:
> Hi Chris and David,
>
> Please review a new version
Hi Daniil,
Looks good.
thanks,
Chris
On 5/26/20 10:46 AM, Daniil Titov wrote:
Hi Chris and David,
Please review a new version of the fix [1] with the changes Chris suggested.
[1] Webrev: http://cr.openjdk.java.net/~dtitov/8244993/webrev.02
[2] Jira issue:
Hi Chris,
I like the pattern and use it quite often.
And the main reason not to avoid repetition of the object, but to avoid
stupid copy-paste errors like
MyObject obj1 = new MyObject();
obj1.method1();
obj1.method2();
MyObject obj2 = new MyObject();
obj2.method1();
obj1.method2(); <== I
Hi Chris and David,
Please review a new version of the fix [1] with the changes Chris suggested.
[1] Webrev: http://cr.openjdk.java.net/~dtitov/8244993/webrev.02
[2] Jira issue: https://bugs.openjdk.java.net/browse/JDK-8244993
Thank you,
Daniil
On 5/22/20, 11:50 AM, "Chris Plummer" wrote:
On 24/05/2020 3:06 am, Chris Plummer wrote:
On 5/23/20 6:03 AM, David Holmes wrote:
Hi Chris,
On 23/05/2020 4:50 am, Chris Plummer wrote:
Hi Daniil,
There is one reference to "jvmwarningmsg" that occurs before it is
declared while all the rest all come after. It probably would make
sense
On 5/23/20 6:03 AM, David Holmes wrote:
Hi Chris,
On 23/05/2020 4:50 am, Chris Plummer wrote:
Hi Daniil,
There is one reference to "jvmwarningmsg" that occurs before it is
declared while all the rest all come after. It probably would make
sense to move its declaration up near the top of the
Hi Chris,
On 23/05/2020 4:50 am, Chris Plummer wrote:
Hi Daniil,
There is one reference to "jvmwarningmsg" that occurs before it is
declared while all the rest all come after. It probably would make sense
to move its declaration up near the top of the file.
92 private static void
Hi Daniil,
There is one reference to "jvmwarningmsg" that occurs before it is
declared while all the rest all come after. It probably would make sense
to move its declaration up near the top of the file.
92 private static void matchListedProcesses(OutputAnalyzer output) {
93
Hi Daniil,
On 22/05/2020 5:24 pm, Daniil Titov wrote:
Hi David,
Some tiers in Mach5 are configured to run tests with '-showversion' VM options.
In JDK-8242009 [3] we started forwarding test VM options to j-*tools
Okay. Filtering it out seems fine then.
Thanks,
David
and some tests that
Hi David,
Some tiers in Mach5 are configured to run tests with '-showversion' VM options.
In JDK-8242009 [3] we started forwarding test VM options to j-*tools
and some tests that launch them and expect an empty stderr (apart from VM
warnings) need to be corrected to either ignore version
Hi Dannil,
On 22/05/2020 3:06 pm, Daniil Titov wrote:
Please review a webrev [1] that reverts the changes done in
jdk.test.lib.process.OutputAnalyzer in [3].
Change [3] modified OutputAnalyzer stderrShouldBeEmptyIgnoreVMWarnings()
methods to ignore also VM version strings . The current
Please review a webrev [1] that reverts the changes done in
jdk.test.lib.process.OutputAnalyzer in [3].
Change [3] modified OutputAnalyzer stderrShouldBeEmptyIgnoreVMWarnings()
methods to ignore also VM version strings . The current webrev [1] reverts this
change and instead makes the tests
12 matches
Mail list logo
