Re: RFR: 8282170: JVMTI SetBreakpoint metaspace allocation test [v5]

2022-03-10 Thread Aleksey Shipilev
On Wed, 9 Mar 2022 10:11:41 GMT, Aleksey Shipilev wrote: >> There are few bugs in SetBreakpoint when it reaches for metaspace >> allocation, notably >> [JDK-8214992](https://bugs.openjdk.java.net/browse/JDK-8214992) and >> [JDK-8264149](https://bugs.openjdk.java.net/browse/JDK-8264149). This a

Re: RFR: 8282170: JVMTI SetBreakpoint metaspace allocation test [v5]

2022-03-10 Thread Chris Plummer
On Wed, 9 Mar 2022 10:11:41 GMT, Aleksey Shipilev wrote: >> There are few bugs in SetBreakpoint when it reaches for metaspace >> allocation, notably >> [JDK-8214992](https://bugs.openjdk.java.net/browse/JDK-8214992) and >> [JDK-8264149](https://bugs.openjdk.java.net/browse/JDK-8264149). This a

Re: RFR: 8282170: JVMTI SetBreakpoint metaspace allocation test [v5]

2022-03-10 Thread Leonid Mesnik
On Wed, 9 Mar 2022 10:11:41 GMT, Aleksey Shipilev wrote: >> There are few bugs in SetBreakpoint when it reaches for metaspace >> allocation, notably >> [JDK-8214992](https://bugs.openjdk.java.net/browse/JDK-8214992) and >> [JDK-8264149](https://bugs.openjdk.java.net/browse/JDK-8264149). This a

Re: RFR: 8282170: JVMTI SetBreakpoint metaspace allocation test [v4]

2022-03-10 Thread Aleksey Shipilev
On Tue, 8 Mar 2022 19:16:25 GMT, Leonid Mesnik wrote: >> Aleksey Shipilev has updated the pull request with a new target base due to >> a merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contains seven additional >> co

Re: RFR: 8282170: JVMTI SetBreakpoint metaspace allocation test [v5]

2022-03-09 Thread Aleksey Shipilev
> There are few bugs in SetBreakpoint when it reaches for metaspace allocation, > notably [JDK-8214992](https://bugs.openjdk.java.net/browse/JDK-8214992) and > [JDK-8264149](https://bugs.openjdk.java.net/browse/JDK-8264149). This adds > the test that exercises the metaspace allocation paths. >

Re: RFR: 8282170: JVMTI SetBreakpoint metaspace allocation test [v4]

2022-03-09 Thread Aleksey Shipilev
On Wed, 9 Mar 2022 02:20:22 GMT, Serguei Spitsyn wrote: > Not a review yet but I'd suggest to convert .c to .cpp. In long term we would > like to get rid of the *.c files in the serviceability/jvmti test folder for > consistency. Good thinking. I converted the test to C++, and this also allowe

Re: RFR: 8282170: JVMTI SetBreakpoint metaspace allocation test [v4]

2022-03-08 Thread Serguei Spitsyn
On Tue, 8 Mar 2022 18:37:45 GMT, Aleksey Shipilev wrote: >> There are few bugs in SetBreakpoint when it reaches for metaspace >> allocation, notably >> [JDK-8214992](https://bugs.openjdk.java.net/browse/JDK-8214992) and >> [JDK-8264149](https://bugs.openjdk.java.net/browse/JDK-8264149). This a

Re: RFR: 8282170: JVMTI SetBreakpoint metaspace allocation test [v4]

2022-03-08 Thread Leonid Mesnik
On Tue, 8 Mar 2022 18:37:45 GMT, Aleksey Shipilev wrote: >> There are few bugs in SetBreakpoint when it reaches for metaspace >> allocation, notably >> [JDK-8214992](https://bugs.openjdk.java.net/browse/JDK-8214992) and >> [JDK-8264149](https://bugs.openjdk.java.net/browse/JDK-8264149). This a

Re: RFR: 8282170: JVMTI SetBreakpoint metaspace allocation test [v3]

2022-03-08 Thread Aleksey Shipilev
On Mon, 28 Feb 2022 18:49:05 GMT, Aleksey Shipilev wrote: >> There are few bugs in SetBreakpoint when it reaches for metaspace >> allocation, notably >> [JDK-8214992](https://bugs.openjdk.java.net/browse/JDK-8214992) and >> [JDK-8264149](https://bugs.openjdk.java.net/browse/JDK-8264149). This

Re: RFR: 8282170: JVMTI SetBreakpoint metaspace allocation test [v3]

2022-03-08 Thread Aleksey Shipilev
On Mon, 7 Mar 2022 16:58:38 GMT, Leonid Mesnik wrote: >> Aleksey Shipilev has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Fix copyright > > test/hotspot/jtreg/serviceability/jvmti/SetBreakpoint/TestManyBreakpoints.java > line 35: > >>

Re: RFR: 8282170: JVMTI SetBreakpoint metaspace allocation test [v4]

2022-03-08 Thread Aleksey Shipilev
> There are few bugs in SetBreakpoint when it reaches for metaspace allocation, > notably [JDK-8214992](https://bugs.openjdk.java.net/browse/JDK-8214992) and > [JDK-8264149](https://bugs.openjdk.java.net/browse/JDK-8264149). This adds > the test that exercises the metaspace allocation paths. >

Re: RFR: 8282170: JVMTI SetBreakpoint metaspace allocation test [v3]

2022-03-07 Thread Leonid Mesnik
On Mon, 28 Feb 2022 18:49:05 GMT, Aleksey Shipilev wrote: >> There are few bugs in SetBreakpoint when it reaches for metaspace >> allocation, notably >> [JDK-8214992](https://bugs.openjdk.java.net/browse/JDK-8214992) and >> [JDK-8264149](https://bugs.openjdk.java.net/browse/JDK-8264149). This

Re: RFR: 8282170: JVMTI SetBreakpoint metaspace allocation test

2022-03-07 Thread Aleksey Shipilev
On Tue, 22 Feb 2022 19:54:59 GMT, Chris Plummer wrote: >> There are few bugs in SetBreakpoint when it reaches for metaspace >> allocation, notably >> [JDK-8214992](https://bugs.openjdk.java.net/browse/JDK-8214992) and >> [JDK-8264149](https://bugs.openjdk.java.net/browse/JDK-8264149). This add

Re: RFR: 8282170: JVMTI SetBreakpoint metaspace allocation test

2022-03-01 Thread Aleksey Shipilev
On Tue, 22 Feb 2022 19:54:59 GMT, Chris Plummer wrote: >> There are few bugs in SetBreakpoint when it reaches for metaspace >> allocation, notably >> [JDK-8214992](https://bugs.openjdk.java.net/browse/JDK-8214992) and >> [JDK-8264149](https://bugs.openjdk.java.net/browse/JDK-8264149). This add

Re: RFR: 8282170: JVMTI SetBreakpoint metaspace allocation test [v3]

2022-02-28 Thread Chris Plummer
On Mon, 28 Feb 2022 18:49:05 GMT, Aleksey Shipilev wrote: >> There are few bugs in SetBreakpoint when it reaches for metaspace >> allocation, notably >> [JDK-8214992](https://bugs.openjdk.java.net/browse/JDK-8214992) and >> [JDK-8264149](https://bugs.openjdk.java.net/browse/JDK-8264149). This

Re: RFR: 8282170: JVMTI SetBreakpoint metaspace allocation test [v3]

2022-02-28 Thread Aleksey Shipilev
On Tue, 22 Feb 2022 19:43:46 GMT, Chris Plummer wrote: >> Aleksey Shipilev has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Fix copyright > > test/hotspot/jtreg/serviceability/jvmti/SetBreakpoint/TestManyBreakpoints.java > line 2: > >>

Re: RFR: 8282170: JVMTI SetBreakpoint metaspace allocation test [v3]

2022-02-28 Thread Aleksey Shipilev
> There are few bugs in SetBreakpoint when it reaches for metaspace allocation, > notably [JDK-8214992](https://bugs.openjdk.java.net/browse/JDK-8214992) and > [JDK-8264149](https://bugs.openjdk.java.net/browse/JDK-8264149). This adds > the test that exercises the metaspace allocation paths. >

Re: RFR: 8282170: JVMTI SetBreakpoint metaspace allocation test [v2]

2022-02-28 Thread Chris Plummer
On Mon, 28 Feb 2022 15:51:24 GMT, Aleksey Shipilev wrote: >> There are few bugs in SetBreakpoint when it reaches for metaspace >> allocation, notably >> [JDK-8214992](https://bugs.openjdk.java.net/browse/JDK-8214992) and >> [JDK-8264149](https://bugs.openjdk.java.net/browse/JDK-8264149). This

Re: RFR: 8282170: JVMTI SetBreakpoint metaspace allocation test [v2]

2022-02-28 Thread Aleksey Shipilev
> There are few bugs in SetBreakpoint when it reaches for metaspace allocation, > notably [JDK-8214992](https://bugs.openjdk.java.net/browse/JDK-8214992) and > [JDK-8264149](https://bugs.openjdk.java.net/browse/JDK-8264149). This adds > the test that exercises the metaspace allocation paths. >

Re: RFR: 8282170: JVMTI SetBreakpoint metaspace allocation test

2022-02-22 Thread Aleksey Shipilev
On Tue, 22 Feb 2022 19:54:59 GMT, Chris Plummer wrote: > So you load a class 50 times in separate ClassLoaders, and each load triggers > the ClassPrepare event, and each time that happens you set a breakpoint on > each of the 1000 methods, meaning a total of 5000 breakpoints. Doing this > will

Re: RFR: 8282170: JVMTI SetBreakpoint metaspace allocation test

2022-02-22 Thread Chris Plummer
On Mon, 21 Feb 2022 10:55:42 GMT, Aleksey Shipilev wrote: > There are few bugs in SetBreakpoint when it reaches for metaspace allocation, > notably [JDK-8214992](https://bugs.openjdk.java.net/browse/JDK-8214992) and > [JDK-8264149](https://bugs.openjdk.java.net/browse/JDK-8264149). This adds >

RFR: 8282170: JVMTI SetBreakpoint metaspace allocation test

2022-02-21 Thread Aleksey Shipilev
There are few bugs in SetBreakpoint when it reaches for metaspace allocation, notably [JDK-8214992](https://bugs.openjdk.java.net/browse/JDK-8214992) and [JDK-8264149](https://bugs.openjdk.java.net/browse/JDK-8264149). This adds the test that exercises the metaspace allocation paths. Additional