Good to go!
-JB-
On 31.7.2015 18:44, olivier.lagn...@oracle.com wrote:
Thanks Jaroslav and Serguey for the comments for first pass of review.
I have fixed the patch following your comments.
Please find the 2nd version here :
webrev: http://cr.openjdk.java.net/~olagneau/8131784/webrev.01/
Tha
Looks good.
Thanks,
Serguei
On 7/31/15 9:44 AM, olivier.lagn...@oracle.com wrote:
Thanks Jaroslav and Serguey for the comments for first pass of review.
I have fixed the patch following your comments.
Please find the 2nd version here :
webrev: http://cr.openjdk.java.net/~olagneau/8131784/webr
Hi Olivier,
Ok, reviewed.
Thank you for the update!
Serguei
On 7/31/15 9:21 AM, olivier.lagn...@oracle.com wrote:
Hi Serguey,
Thanks for reviewing. Please see comments inlined.
On 31/07/2015 01:50, serguei.spit...@oracle.com wrote:
Hi Olivier,
I agree with the comments from Jaroslav.
A cou
Thanks Jaroslav and Serguey for the comments for first pass of review.
I have fixed the patch following your comments.
Please find the 2nd version here :
webrev: http://cr.openjdk.java.net/~olagneau/8131784/webrev.01/
Thanks,
Olivier.
On 30/07/2015 18:55, olivier.lagn...@oracle.com wrote:
Hi,
Hi Serguey,
Thanks for reviewing. Please see comments inlined.
On 31/07/2015 01:50, serguei.spit...@oracle.com wrote:
Hi Olivier,
I agree with the comments from Jaroslav.
A couple of minor comments.
+ if ( exitCode != 0 ) {
Unneeded extra spaces
Ok. fixed.
+ } catch (InterruptedException
Hi Jaroslav,
Thanks for reviewing this fix. Comments inlined.
Olivier.
On 30/07/2015 19:13, Jaroslav Bachorik wrote:
Hi Olivier,
On 30.7.2015 18:55, olivier.lagn...@oracle.com wrote:
Hi,
Could you please review this fix:
bug: https://bugs.openjdk.java.net/browse/JDK-8131784
webrev: http://c
Hi Olivier,
I agree with the comments from Jaroslav.
A couple of minor comments.
+if ( exitCode != 0 ) {
Unneeded extra spaces
+} catch (InterruptedException e) {
+Thread.currentThread().interrupt();
+throw new RuntimeException("Parent process i
Hi Olivier,
On 30.7.2015 18:55, olivier.lagn...@oracle.com wrote:
Hi,
Could you please review this fix:
bug: https://bugs.openjdk.java.net/browse/JDK-8131784
webrev: http://cr.openjdk.java.net/~olagneau/8131784/webrev.00/
We add tracing information to help diagnosing master bug problem
(https:
Hi,
Could you please review this fix:
bug: https://bugs.openjdk.java.net/browse/JDK-8131784
webrev: http://cr.openjdk.java.net/~olagneau/8131784/webrev.00/
We add tracing information to help diagnosing master bug problem
(https://bugs.openjdk.java.net/browse/JDK-8130339),
and we will monitor th
