Re: RFR: JDK-8203026: java.rmi.NoSuchObjectException: no such object in table

2019-03-25 Thread serguei.spit...@oracle.com
Hi Gary, It looks good to me. Nit:   It is better to define as interface: +private static RemoteHostImpl remoteHost; => +private static RemoteHost remoteHost; +private static RemoteVmImpl rvm; => +private static Re

Re: RFR: JDK-8203026: java.rmi.NoSuchObjectException: no such object in table

2019-03-25 Thread Gary Adams
Here's an updated webrev that includes the change to bind to the stub. The jstatd tests continue to pass after this change. Webrev: http://cr.openjdk.java.net/~gadams/8203026/webrev.01/ It would be good to have a second reviewer from the serviceability team. Longer term it would be good to rep

Re: RFR: JDK-8203026: java.rmi.NoSuchObjectException: no such object in table

2019-03-22 Thread Roger Riggs
Hi Gary, Holding a static reference to the implementation solves the problem. But I noticed that the object that is bound in the registry is the RemoteHostImpl and it should be the RemoteHost stub. Line 145: should be: bind(name.toString(), stub); That is likely to solve the problem

RFR: JDK-8203026: java.rmi.NoSuchObjectException: no such object in table

2019-03-22 Thread gary.ad...@oracle.com
Here's a proposed fix for the intermittent jstatd test failure. By moving the exported object from a local method variable to a static class variable a strong reference is held so the object will not be garbage collected prematurely.   Webrev: http://cr.openjdk.java.net/~gadams/8203026/webrev.00/