Re: RFR : JDK-8141591 - javax/management/remote/mandatory/threads/ExecutorTest.java fails intermittently

2016-11-21 Thread Daniel Fuchs
Hi Harsha, I'm still unsure that creating a new executor is the right solution, but we can give it a try... good to go. best regards, -- daniel On 17/11/16 13:14, Harsha Wardhana B wrote: Hello, Gentle reminder !! -Harsha On Tuesday 15 November 2016 02:16 PM, Harsha Wardhana B wrote:

Re: RFR : JDK-8141591 - javax/management/remote/mandatory/threads/ExecutorTest.java fails intermittently

2016-11-15 Thread Harsha Wardhana B
Hello, Please review below webrev incorporating Daniel's comments. http://cr.openjdk.java.net/~hb/8141591/webrev.01/ Regards Harsha On Monday 14 November 2016 04:14 PM, Daniel Fuchs wrote: On 14/11/16 06:57, Harsha Wardhana B wrote: Well, that will not cover the case where user shuts down

Re: RFR : JDK-8141591 - javax/management/remote/mandatory/threads/ExecutorTest.java fails intermittently

2016-11-14 Thread Daniel Fuchs
On 14/11/16 06:57, Harsha Wardhana B wrote: Well, that will not cover the case where user shuts down executor but keeps the client/server alive. So we will need a executor that can keep notif system running as well as do clean-up if client/server is closed. It's OK to continue in order to do

Re: RFR : JDK-8141591 - javax/management/remote/mandatory/threads/ExecutorTest.java fails intermittently

2016-11-13 Thread Harsha Wardhana B
Hi Daniel, On Friday 11 November 2016 11:02 PM, Daniel Fuchs wrote: On 11/11/16 16:57, Harsha Wardhana B wrote: Hi Daniel, Old executor will be shutdown by the user. We are only swapping a user supplied executor with new linear executor. It will follow the same shutdown sequence as original

Re: RFR : JDK-8141591 - javax/management/remote/mandatory/threads/ExecutorTest.java fails intermittently

2016-11-11 Thread Daniel Fuchs
On 11/11/16 16:57, Harsha Wardhana B wrote: Hi Daniel, Old executor will be shutdown by the user. We are only swapping a user supplied executor with new linear executor. It will follow the same shutdown sequence as original one. OK - the LinearExecutor has only one thread and that thread will

Re: RFR : JDK-8141591 - javax/management/remote/mandatory/threads/ExecutorTest.java fails intermittently

2016-11-11 Thread Harsha Wardhana B
Hi Daniel, On Friday 11 November 2016 10:12 PM, Daniel Fuchs wrote: Hi Harsha, // We reached here because the executor was shutdown. // If executor was supplied by client, then it was shutdown // abruptly or JMXConnector was shutdown along with executor // while this thread was suspended

Re: RFR : JDK-8141591 - javax/management/remote/mandatory/threads/ExecutorTest.java fails intermittently

2016-11-11 Thread Daniel Fuchs
Hi Harsha, // We reached here because the executor was shutdown. // If executor was supplied by client, then it was shutdown // abruptly or JMXConnector was shutdown along with executor // while this thread was suspended at L564. if (!(executor instanceof LinearExecutor)) { // Spawn

RFR : JDK-8141591 - javax/management/remote/mandatory/threads/ExecutorTest.java fails intermittently

2016-11-11 Thread Harsha Wardhana B
Hello, Please review the fix for issue : https://bugs.openjdk.java.net/browse/JDK-8141591 webrev : http://cr.openjdk.java.net/~hb/8141591/webrev.00/ Fix details: The root-cause for the issue is that NotifFetcher thread was suspended at L562 after which main thread ran to completion shutting