Re: RFR 8199467 Compilation Errors in libinstrument Reentrancy.c with VS2017

Hi Martin, Good recommendation; pushed. Thanks, Roger On 3/21/2018 3:31 PM, Martin Buchholz wrote: On Wed, Mar 21, 2018 at 12:13 PM, Roger Riggs > wrote: -    void *  test = (void *) 0x; +    void *  test =

Re: RFR 8199467 Compilation Errors in libinstrument Reentrancy.c with VS2017

On Wed, Mar 21, 2018 at 12:13 PM, Roger Riggs wrote: > > -void * test = (void *) 0x; > +void * test = (void *) 0xul; > Martin's 15th law: Never use "l" in a numeric constant unless the constant is 0xCafeBabel, so 0xUL

Re: RFR 8199467 Compilation Errors in libinstrument Reentrancy.c with VS2017

Hi Roger, It looks good to me. Thank you for taking care about this! Thanks, Serguei On 3/21/18 12:13, Roger Riggs wrote: Please review a small change to avoid sign extension in libinstrument/ Reentrancy.c to correct an compilation warning with vs2017. diff --git

RFR 8199467 Compilation Errors in libinstrument Reentrancy.c with VS2017

Please review a small change to avoid sign extension in libinstrument/ Reentrancy.c to correct an compilation warning with vs2017. diff --git a/src/java.instrument/share/native/libinstrument/Reentrancy.c b/src/java.instrument/share/native/libinstrument/Reentrancy.c ---