Re: Need comments on JEP-158: Unified JVM Logging

2014-05-30 Thread Thomas Stüfe
Hi all, I like you proposal and hope this tracing system turns out well. I'm with the SAP JVM; we have had our own homebrewn tracing system for years, which resembles your proposal a lot. If your solution turns out well, we may decide to abandon our propietary solution in favor of your proposal.

Re: Need comments on JEP-158: Unified JVM Logging

2014-05-30 Thread Fredrik Arvidsson
Hi Mario, thanks for the feedback! Pleas see my comments in-lined below. On 2014-05-16 13:41, Mario Torre wrote: On Fri, 2014-05-16 at 11:45 +0100, Richard Warburton wrote: Hi, Hi all, I share this same doubts, and I'm also a bit confused. I'm not saying that an abstract framework should de

Re: Need comments on JEP-158: Unified JVM Logging

2014-05-21 Thread Fredrik Arvidsson
Hi Thomas and thanks for the feedback. Interesting to see that you already have a design that is so close to what we are proposing in this JEP. I have added some comments in-line below. On 2014-05-20 09:59, Thomas Stüfe wrote: Hi all, I like you proposal and hope this tracing system turns ou

Re: Need comments on JEP-158: Unified JVM Logging

2014-05-18 Thread Fredrik Arvidsson
Hi Chris You will find my comments in-line below. On 2014-05-17 09:47, Chris Newland wrote: Hi Fredrik, The discussion I had with David Holmes and John Rose on hotspot-dev back in February might be relevant to this JEP: http://mail.openjdk.java.net/pipermail/hotspot-dev/2014-February/012718.ht

Re: Need comments on JEP-158: Unified JVM Logging

2014-05-18 Thread Fredrik Arvidsson
Hi Martijn Thank you for doing that. I'm afraid it is going to be hard enough anyway to keep myself updated on all feedback given :) For me it is a matter of course that these kind of discussions should be held in the open. We are all stake holders in this. As long as the discussion does not tu

Re: Need comments on JEP-158: Unified JVM Logging

2014-05-18 Thread Fredrik Arvidsson
Hi Dmitry, thanks for the feedback. I will comment in-line below. On 2014-05-16 15:40, Dmitry Samersoff wrote: Fredrik, 1. I'm not sure we have to provide user-configurable decoration. It add complication to logger because not all decorations available for all components and it creates

Re: Need comments on JEP-158: Unified JVM Logging

2014-05-18 Thread Martijn Verburg
Hi Fredrik, I've asked all of the discussions on our list to be fed back here or directly to you. Thanks for opening the discussion, we really appreciate it! Cheers, Martijn On Sunday, 18 May 2014, Fredrik Arvidsson wrote: > Hi Richard > > I will add more text in the JEP describing the intent

Re: Need comments on JEP-158: Unified JVM Logging

2014-05-18 Thread Fredrik Arvidsson
Hi all On 2014-05-18 12:14, Kirk Pepperdine wrote: Hi Fredrik, I do need more information but I think a flat structure would provide less overhead rather than passing messages through a network of “sub” loggers. Kirk, I can understand that you are concerned that the hierarchical structure wou

Re: Need comments on JEP-158: Unified JVM Logging

2014-05-18 Thread Kirk Pepperdine
Hi Fredrik, I do need more information but I think a flat structure would provide less overhead rather than passing messages through a network of “sub” loggers. Peter Lawrey wrote JChronicle which at it’s core is a messaging system but it’s also a wickedly fast logger. That said, there isn’t a

Re: Need comments on JEP-158: Unified JVM Logging

2014-05-18 Thread Kirk Pepperdine
Hi Chris, I too am bothered by the jumbled lines. However I don’t think that we need strict ordering. However I don’t believe it’s up to the logging framework to enforce order. If order is needed it should be up to the producer or the consumer of messages to deal with the issue of order. Howeve

Re: Need comments on JEP-158: Unified JVM Logging

2014-05-18 Thread Fredrik Arvidsson
Hi Richard I will add more text in the JEP describing the intent of the hierarchical logger design. As you said, it is not that clear in the current one. Thanks. Regarding out off band discussions. I have noted that and I will try to keep myself updated to that. It is not optimal to have dis

Re: Need comments on JEP-158: Unified JVM Logging

2014-05-18 Thread Richard Warburton
Hi Fredrik, In the JEP I tried to explain the concept of 'sub' loggers but I did not > put in anything about the intent of having them. I think that your > requirement easily could be solved using sub loggers, or sub components if > you like that wording better. > > Loggers are ordered in an hiera

Re: Need comments on JEP-158: Unified JVM Logging

2014-05-17 Thread Chris Newland
Hi Fredrik, The discussion I had with David Holmes and John Rose on hotspot-dev back in February might be relevant to this JEP: http://mail.openjdk.java.net/pipermail/hotspot-dev/2014-February/012718.html I'm the author of a JITWatch[1], a JIT compiler log analysis tool which relies on -XX:+Trace

Re: Need comments on JEP-158: Unified JVM Logging

2014-05-16 Thread Dmitry Samersoff
Fredrik, 1. I'm not sure we have to provide user-configurable decoration. It add complication to logger because not all decorations available for all components and it creates a burden for customer support because all tools would have to support different log formats. 2. Backend might be

Re: Need comments on JEP-158: Unified JVM Logging

2014-05-16 Thread Mario Torre
On Fri, 2014-05-16 at 11:45 +0100, Richard Warburton wrote: > Hi, Hi all, I share this same doubts, and I'm also a bit confused. > I'm not saying that an abstract framework should depend upon the details of > the different components but if you had component definable markers for the > type of i

Re: Need comments on JEP-158: Unified JVM Logging

2014-05-16 Thread Fredrik Arvidsson
Hi Richard, thanks for the feedback. In the JEP I tried to explain the concept of 'sub' loggers but I did not put in anything about the intent of having them. I think that your requirement easily could be solved using sub loggers, or sub components if you like that wording better. Loggers ar

Re: Need comments on JEP-158: Unified JVM Logging

2014-05-16 Thread Richard Warburton
Hi, Please help me review this updated version of the JEP-158 Unified JVM > Logging that was pushed today to the JEP repository. > > Since the service posting the JEPs to http://openjdk.java.net/jeps/ site > seems to be non working at the moment I am linking directly to the HG > repository instead