Re: RFR(M): v.04, 8155091: Remove SA related functions from tmtools

2016-05-05 Thread Dmitry Samersoff
Mandy, OK. Will change it. Thank you for review! -Dmitry On 2016-05-05 22:48, Mandy Chung wrote: > >> On May 5, 2016, at 5:51 AM, Dmitry Samersoff >> wrote: >> >> Please, see updated webrev. >> >> http://cr.openjdk.java.net/~dsamersoff/JDK-8155091/webrev.04/ > > src/jdk.hotspot.agent/share

Re: RFR(M): v.04, 8155091: Remove SA related functions from tmtools

2016-05-05 Thread Mandy Chung
> On May 5, 2016, at 5:51 AM, Dmitry Samersoff > wrote: > > Please, see updated webrev. > > http://cr.openjdk.java.net/~dsamersoff/JDK-8155091/webrev.04/ src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/tools/ToolProvider.java I suggest to remove this as jdk.hotspot.agent is no longer

Re: RFR(M): v.04, 8155091: Remove SA related functions from tmtools

2016-05-05 Thread Mandy Chung
> On May 5, 2016, at 5:51 AM, Dmitry Samersoff > wrote: > > > http://cr.openjdk.java.net/~dsamersoff/JDK-8155091/webrev.04/ src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/tools/ToolProvider.java This is not used. Looks like it’s a copy of

Re: RFR(M): v.04, 8155091: Remove SA related functions from tmtools

2016-05-05 Thread Dmitry Samersoff
Alan, Webrev updated in-place (press shift-reload). -Dmitry On 2016-05-05 16:30, Alan Bateman wrote: > > On 05/05/2016 13:51, Dmitry Samersoff wrote: >> Please, see updated webrev. >> >> http://cr.openjdk.java.net/~dsamersoff/JDK-8155091/webrev.04/ >> >> Removed ToolProvider and update modules-

Re: RFR(M): v.04, 8155091: Remove SA related functions from tmtools

2016-05-05 Thread Alan Bateman
On 05/05/2016 13:51, Dmitry Samersoff wrote: Please, see updated webrev. http://cr.openjdk.java.net/~dsamersoff/JDK-8155091/webrev.04/ Removed ToolProvider and update modules-info files. -Dmitry Can `requires jdk.jcmd` be dropped from jdk.hotspot.agent's module declaration? shouldWarnSA/w

Re: RFR(M): v.04, 8155091: Remove SA related functions from tmtools

2016-05-05 Thread Dmitry Samersoff
Please, see updated webrev. http://cr.openjdk.java.net/~dsamersoff/JDK-8155091/webrev.04/ Removed ToolProvider and update modules-info files. -Dmitry On 2016-05-04 22:30, Dmitry Samersoff wrote: > Everybody, > > Please review the changes: > > http://cr.openjdk.java.net/~dsamersoff/JDK-8155091