Re: code review request for JVM/TI CompiledMethodLoad event extension (6580131)

2010-05-03 Thread Jeremy Manson
Okay, thanks. Jeremy On Mon, May 3, 2010 at 4:22 PM, Tom Rodriguez wrote: > They are resource allocated so they don't need to be free'd.  The destructor > of ResourceMark will release any storage that was allocated. > > tom

Re: code review request for JVM/TI CompiledMethodLoad event extension (6580131)

2010-05-03 Thread Tom Rodriguez
They are resource allocated so they don't need to be free'd. The destructor of ResourceMark will release any storage that was allocated. tom On May 3, 2010, at 3:47 PM, Jeremy Manson wrote: > Resurrecting an old thread... > > Is there any reason that no one ever frees the arrays that are crea

Re: code review request for JVM/TI CompiledMethodLoad event extension (6580131)

2010-05-03 Thread Jeremy Manson
Resurrecting an old thread... Is there any reason that no one ever frees the arrays that are created by this changeset in create_inline_record() in jvmtiExport.cpp? Or am I just missing where they are freed? I don't think they are freed elsewhere... I added a method that performed some obvious

Re: code review request for JVM/TI CompiledMethodLoad event extension (6580131)

2010-01-20 Thread Daniel D. Daugherty
Greetings, The jvmticmlr.h stuff is in: - OpenJDK6 - JDK and HotSpot sides - JDK7 - JDK side - HSX17 - HotSpot side When HSX17-B08 pushes to JDK7, then the HotSpot side will be in JDK7 also. We'll be looking at the JDK6-Update train next... Dan Daniel D. Daugherty wrote: Greetings, The

RE: code review request for JVM/TI CompiledMethodLoad event extension (6580131)

2010-01-11 Thread Venkatachalam, Vasanth
27;t see a newer version of this file included in the webrev. Vasanth From: daniel.daughe...@sun.com [mailto:daniel.daughe...@sun.com] Sent: Monday, January 11, 2010 3:02 PM To: Tom Rodriguez Cc: Venkatachalam, Vasanth; Deneau, Tom; serviceability-dev@openjdk.java.net Subject: Re: code review reque

Re: code review request for JVM/TI CompiledMethodLoad event extension (6580131)

2010-01-11 Thread Daniel D. Daugherty
Vasanth   From: Venkatachalam, Vasanth Sent: Monday, January 11, 2010 3:30 PM To: 'daniel.daughe...@sun.com'; Tom Rodriguez Cc: Deneau, Tom; serviceability-dev@openjdk.java.net Subject: RE: code review request for JVM/TI CompiledMethodLoad event extension (6580131

RE: code review request for JVM/TI CompiledMethodLoad event extension (6580131)

2010-01-11 Thread Venkatachalam, Vasanth
Tom; serviceability-dev@openjdk.java.net Subject: Re: code review request for JVM/TI CompiledMethodLoad event extension (6580131) Thanks for the review! I did a merge with HSX-17 this AM and that went very smoothly so I'm testing those bits right now. I'm hoping to hear from Vasanth t

Re: code review request for JVM/TI CompiledMethodLoad event extension (6580131)

2010-01-11 Thread Daniel D. Daugherty
Thanks for the review, Kelly! Dan Kelly O'Hair wrote: The makefile changes look fine, and thanks for fixing my spelling errors in the tests. ;^) The new demo looks good too. -kto Daniel D. Daugherty wrote: Thanks for the review! I did a merge with HSX-17 this AM and that went very smooth

Re: code review request for JVM/TI CompiledMethodLoad event extension (6580131)

2010-01-11 Thread Kelly O'Hair
The makefile changes look fine, and thanks for fixing my spelling errors in the tests. ;^) The new demo looks good too. -kto Daniel D. Daugherty wrote: Thanks for the review! I did a merge with HSX-17 this AM and that went very smoothly so I'm testing those bits right now. I'm hoping to hea

Re: code review request for JVM/TI CompiledMethodLoad event extension (6580131)

2010-01-11 Thread Daniel D. Daugherty
Thanks for the review!  I did a merge with HSX-17 this AM and that went very smoothly so I'm testing those bits right now. I'm hoping to hear from Vasanth today, but he doesn't appear to have an OpenJDK id so I can't list him as a reviewer; I have listed him as a contributor. I'm also hoping

Re: code review request for JVM/TI CompiledMethodLoad event extension (6580131)

2010-01-11 Thread Tom Rodriguez
This looks good to me. Thanks for your thorough work on this. tom On Jan 11, 2010, at 11:28 AM, Daniel D. Daugherty wrote: > Second call for this code review request. > > Dan > > > Daniel D. Daugherty wrote: >> Greetings, >> >> The folks at AMD Labs have been kind enough to provide an >> ex

Re: code review request for JVM/TI CompiledMethodLoad event extension (6580131)

2010-01-11 Thread Daniel D. Daugherty
Second call for this code review request. Dan Daniel D. Daugherty wrote: Greetings, The folks at AMD Labs have been kind enough to provide an extension to the JVM/TI CompileMethodLoad event in order to provide additional information about in-lining. This extension uses the existing (but previ

code review request for JVM/TI CompiledMethodLoad event extension (6580131)

2010-01-07 Thread Daniel D. Daugherty
Greetings, The folks at AMD Labs have been kind enough to provide an extension to the JVM/TI CompileMethodLoad event in order to provide additional information about in-lining. This extension uses the existing (but previously unused) compile_info paramter: http://java.sun.com/javase/6/docs/platf