hg: jdk7/hotspot-rt/hotspot: 7034585: Adjust fillInStackTrace filtering to assist 6998871

2011-04-12 Thread david . holmes
Changeset: 6a615eae2f34 Author:dholmes Date: 2011-04-12 02:53 -0400 URL: http://hg.openjdk.java.net/jdk7/hotspot-rt/hotspot/rev/6a615eae2f34 7034585: Adjust fillInStackTrace filtering to assist 6998871 Summary: Allow for one or more fillInStackTrace frames to be skipped Reviewed-by:

code review for attach on demand (AOD) test fix (7035555)

2011-04-12 Thread Daniel D. Daugherty
Greetings, I have minor fixes to an Attach On Demand (AOD) test that I'd like to get into T&L snapshot for OpenJDK7-B140 (next week). Here is my proposed changeset comment: 703: 4/4 attach/BasicTests.sh needs another tweak for Cygwin Summary: Test needs to properly detect missing AgentIn

hg: jdk7/tl/jdk: 6882437: CertPath/X509CertPathDiscovery/Test fails on jdk7/pit/b62

2011-04-12 Thread xuelei . fan
Changeset: 6e306c3aa17b Author:xuelei Date: 2011-04-12 08:27 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/6e306c3aa17b 6882437: CertPath/X509CertPathDiscovery/Test fails on jdk7/pit/b62 Summary: Pass trust anchors to CRL certification path building, support CRLs without AK

Re: code review for attach on demand (AOD) test fix (7035555)

2011-04-12 Thread Dmitry Samersoff
Dan, test/com/sun/tools/attach/ApplicationSetup.sh I don't know whether you use the same shell script for UNIX and Cygwin but I think "${TESTCLASSES}/Application.jar" is safer than "${TESTCLASSES}"/Application.jar test/com/sun/tools/attach/BasicTests.java Nit: + System.out.println("INFO:

Re: code review for attach on demand (AOD) test fix (7035555)

2011-04-12 Thread Daniel D. Daugherty
On 4/12/2011 9:33 AM, Dmitry Samersoff wrote: Dan, test/com/sun/tools/attach/ApplicationSetup.sh I don't know whether you use the same shell script for UNIX and Cygwin Yes, these scripts are intended to run on all supported platforms. but I think "${TESTCLASSES}/Application.jar" is safer

Re: code review for attach on demand (AOD) test fix (7035555)

2011-04-12 Thread Dmitry Samersoff
Dan, Thumb up! -Dmitry On 2011-04-12 19:47, Daniel D. Daugherty wrote: On 4/12/2011 9:33 AM, Dmitry Samersoff wrote: Dan, test/com/sun/tools/attach/ApplicationSetup.sh I don't know whether you use the same shell script for UNIX and Cygwin Yes, these scripts are intended to run on all suppo

Re: code review for attach on demand (AOD) test fix (7035555)

2011-04-12 Thread Daniel D. Daugherty
Thanks! And thanks for the quick review! Dan On 4/12/2011 9:53 AM, Dmitry Samersoff wrote: Dan, Thumb up! -Dmitry On 2011-04-12 19:47, Daniel D. Daugherty wrote: On 4/12/2011 9:33 AM, Dmitry Samersoff wrote: Dan, test/com/sun/tools/attach/ApplicationSetup.sh I don't know whether you use

hg: jdk7/tl/jdk: 7035615: Address lint warnings for javax.sql.rowset & com.sun.rowset

2011-04-12 Thread lance . andersen
Changeset: 1bb95f6ac753 Author:lancea Date: 2011-04-12 12:25 -0400 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/1bb95f6ac753 7035615: Address lint warnings for javax.sql.rowset & com.sun.rowset Reviewed-by: alanb, darcy ! src/share/classes/com/sun/rowset/CachedRowSetImpl.java !

Re: code review for attach on demand (AOD) test fix (7035555)

2011-04-12 Thread Daniel D. Daugherty
I could do that, but I was trying to be "nice" formatting wise. Dan On 4/12/2011 12:19 PM, Kelly O'Hair wrote: Why the multiple println() lines? Why not just one "INFO:" message, who gives a rip how long it is? -kto On Apr 12, 2011, at 8:12 AM, Daniel D. Daugherty wrote: Greet

hg: jdk7/tl/jdk: 7007772: Address typos in javadoc for ResultSet

2011-04-12 Thread lance . andersen
Changeset: 0bae251b548b Author:lancea Date: 2011-04-12 14:32 -0400 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/0bae251b548b 7007772: Address typos in javadoc for ResultSet Reviewed-by: ohair, smarks ! src/share/classes/java/sql/ResultSet.java

Re: code review for attach on demand (AOD) test fix (7035555)

2011-04-12 Thread John Pampuch
FWIW, in the very unlikely chance we would ever localize these messages, life is much easier for the localization team if it is a single message.  (I'm guessing this isn't a place we'd localize, but it is a good habit to get into.) -John On

Re: code review for attach on demand (AOD) test fix (7035555)

2011-04-12 Thread Dmitry Samersoff
Dan, test/com/sun/tools/attach/BasicTests.java We don't break output into lines explicitly (i.e. no \n inside) is it expected? test/com/sun/tools/attach/BasicTests.sh +echo "INFO: Test 2 will cause error messages about SilverBullet.jar" \ +"and an agent failing to start." missed space a

Re: code review for attach on demand (AOD) test fix (7035555)

2011-04-12 Thread Daniel D. Daugherty
On 4/12/2011 2:23 PM, Dmitry wrote: Dan, test/com/sun/tools/attach/BasicTests.java We don't break output into lines explicitly (i.e. no \n inside) is it expected? Yes. Kelly wanted the INFO output on a single line. test/com/sun/tools/attach/BasicTests.sh +echo "INFO: Test 2 will cause e

Re: code review for attach on demand (AOD) test fix (7035555)

2011-04-12 Thread Kelly O'Hair
Looks good to me. -kto On Apr 12, 2011, at 1:23 PM, Dmitry Samersoff wrote: > Dan, > > test/com/sun/tools/attach/BasicTests.java > > We don't break output into lines explicitly (i.e. no \n inside) is it > expected? > > test/com/sun/tools/attach/BasicTests.sh > > +echo "INFO: Test 2 will cau

hg: jdk7/tl/jdk: 7035555: 4/4 attach/BasicTests.sh needs another tweak for Cygwin

2011-04-12 Thread daniel . daugherty
Changeset: 59b2b9a34b3c Author:dcubed Date: 2011-04-12 13:36 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/59b2b9a34b3c 703: 4/4 attach/BasicTests.sh needs another tweak for Cygwin Summary: Test needs to properly detect missing AgentInitializationException. Clarify when

hg: jdk7/tl/jaxws: 7034918: Integrate JAX-WS 2.2.4-b01 in to JDK 7

2011-04-12 Thread kelly . ohair
Changeset: d5e3452a6909 Author:ohair Date: 2011-04-12 12:39 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/jaxws/rev/d5e3452a6909 7034918: Integrate JAX-WS 2.2.4-b01 in to JDK 7 Reviewed-by: ramap ! jaxws.properties

hg: jdk7/tl/jdk: 7026304: Fork-Join sample

2011-04-12 Thread rickard . backman
Changeset: 9128eace50f5 Author:rbackman Date: 2011-04-12 13:14 +0200 URL: http://hg.openjdk.java.net/jdk7/tl/jdk/rev/9128eace50f5 7026304: Fork-Join sample Summary: Implement a merge-sort sample using Fork-Join Reviewed-by: hosterda, chegar, dholmes ! make/mksample/Makefile + make/

hg: jdk7/tl/langtools: 2 new changesets

2011-04-12 Thread maurizio . cimadamore
Changeset: f00986f55961 Author:mcimadamore Date: 2011-04-12 20:56 -0700 URL: http://hg.openjdk.java.net/jdk7/tl/langtools/rev/f00986f55961 7034511: Loophole in typesafety Summary: Type-variable substutution takes upper bound of replaced captured type-variable Reviewed-by: dlsmith