RFR (XS): 8019155 Update makefiles with correct jfr packages

2013-06-26 Thread Staffan Larsen
Please review this small fix for the 7u40 makefiles to include the correct packages in jfr.jar. webrev: http://cr.openjdk.java.net/~sla/8019155/webrev.00/ Thanks, /Staffan

RE: RFR (XS): 8019155 Update makefiles with correct jfr packages

2013-06-26 Thread Markus Grönlund
Looks good. /Markus -Original Message- From: Staffan Larsen Sent: den 26 juni 2013 09:42 To: build-...@openjdk.java.net build-dev; serviceability-dev@openjdk.java.net serviceability-dev@openjdk.java.net Subject: RFR (XS): 8019155 Update makefiles with correct jfr packages Please review

Re: RFR (XS): 8019155 Update makefiles with correct jfr packages

2013-06-26 Thread Erik Joelsson
Looks good to me, but I'm not a jdk7 reviewer. /Erik On 2013-06-26 09:42, Staffan Larsen wrote: Please review this small fix for the 7u40 makefiles to include the correct packages in jfr.jar. webrev: http://cr.openjdk.java.net/~sla/8019155/webrev.00/ Thanks, /Staffan

Re: RFR (XS): 8019155 Update makefiles with correct jfr packages

2013-06-26 Thread Staffan Larsen
Thanks Erik and Markus. Widening the audience to get the required number of reviewers. Thanks, /Staffan On 26 jun 2013, at 10:02, Erik Joelsson wrote: > Looks good to me, but I'm not a jdk7 reviewer. > > /Erik > > On 2013-06-26 09:42, Staffan Larsen wrote: >> Please review this small fix for

hg: hsx/hotspot-rt/hotspot: 2 new changesets

2013-06-26 Thread zhengyu . gu
Changeset: 8cff1de240de Author:zgu Date: 2013-06-25 17:22 -0400 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/8cff1de240de 8017478: Kitchensink crashed with SIGSEGV in BaselineReporter::diff_callsites Summary: Fixed possible NULL pointer that caused SIGSEGV Reviewed-by:

Re: RFR 8014506: Test for Jdp (Java Discovery Protocol) feature

2013-06-26 Thread Dmitry Samersoff
Nils, I'm sponsoring this push but don't see any review replies in this thread. Webrev refreshed against latest tl is here: http://cr.openjdk.java.net/~dsamersoff/JDK-8014506/webrev.01/ -Dmitry On 2013-05-27 12:25, Alex Schenkman wrote: > Please review these tests for the Jdp protocol. > > T

hg: hsx/hotspot-rt/hotspot: 2 new changesets

2013-06-26 Thread kevin . walls
Changeset: 38ea2efa32a7 Author:kevinw Date: 2013-06-26 00:01 +0100 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/38ea2efa32a7 8010278: SA: provide mechanism for using an alternative SA debugger back-end. Reviewed-by: sla, dsamersoff ! agent/src/share/classes/sun/jvm/ho

Re: RFR 8014506: Test for Jdp (Java Discovery Protocol) feature

2013-06-26 Thread Staffan Larsen
test/lib/testlibrary/jdk/testlibrary/PortFinder.java: - This looks racy to me. There is no guarantee that the port will still be available after the call to close(). - Missing copyright notice. - In comment "on of them" -> "one of them" test/sun/management/jdp/ClientConnection.java: - broken in

Re: RFR (XS): 8019155 Update makefiles with correct jfr packages

2013-06-26 Thread David Holmes
+1 from me. David On 26/06/2013 6:08 PM, Staffan Larsen wrote: Thanks Erik and Markus. Widening the audience to get the required number of reviewers. Thanks, /Staffan On 26 jun 2013, at 10:02, Erik Joelsson wrote: Looks good to me, but I'm not a jdk7 reviewer. /Erik On 2013-06-26 09:42,

hg: jdk8/tl/jdk: 8017049: rename property jdk.tls.rejectClientInitializedRenego

2013-06-26 Thread xuelei . fan
Changeset: 0822bcddbd4f Author:xuelei Date: 2013-06-26 06:32 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/0822bcddbd4f 8017049: rename property jdk.tls.rejectClientInitializedRenego Reviewed-by: vinnie, wetmore, mullan ! src/share/classes/sun/security/ssl/Handshaker.java !

hg: jdk8/tl/jdk: 8012647: Add Arrays.parallelPrefix (prefix sum, scan, cumulative sum)

2013-06-26 Thread chris . hegarty
Changeset: e83cdd58f1cf Author:chegar Date: 2013-06-26 15:30 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/e83cdd58f1cf 8012647: Add Arrays.parallelPrefix (prefix sum, scan, cumulative sum) Reviewed-by: chegar, alanb, psandoz Contributed-by: Doug Lea , Tristan Yan , Chris H

Re: RFR: 8013590: NPG: Add a memory pool MXBean for Metaspace

2013-06-26 Thread Mikael Gerdin
Erik, On 2013-06-11 17:27, Erik Helin wrote: Hi Mikael and Jon, thanks for reviewing! I have updated the webrev. The changes from webrev.00 are: - Only exposing the compressed class space memory pool if compressed classes are used. - Renamed the name of the pool to "Compressed Class Space"

hg: jdk8/tl/jdk: 8016761: Lambda metafactory - incorrect type conversion of constructor method handle

2013-06-26 Thread robert . field
Changeset: 71059bca036a Author:rfield Date: 2013-06-26 07:50 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/71059bca036a 8016761: Lambda metafactory - incorrect type conversion of constructor method handle Reviewed-by: jrose ! src/share/classes/java/lang/invoke/InnerClassLa

Re: RFR (XS): 8019155 Update makefiles with correct jfr packages

2013-06-26 Thread Tim Bell
Looks good to me as well. Tim On 06/26/13 05:32 AM, David Holmes wrote: +1 from me. David On 26/06/2013 6:08 PM, Staffan Larsen wrote: Thanks Erik and Markus. Widening the audience to get the required number of reviewers. Thanks, /Staffan On 26 jun 2013, at 10:02, Erik Joelsson wrote:

hg: jdk8/tl/jdk: 8017322: java/util/Currency/PropertiesTest.sh should run exclusively

2013-06-26 Thread naoto . sato
Changeset: 336e5a862013 Author:naoto Date: 2013-06-26 11:21 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/336e5a862013 8017322: java/util/Currency/PropertiesTest.sh should run exclusively Reviewed-by: alanb ! test/TEST.ROOT

hg: jdk8/tl/langtools: 8016908: TEST_BUG: removing non-ascii characters causes tests to fail

2013-06-26 Thread kumar . x . srinivasan
Changeset: c2d9303c3477 Author:ksrini Date: 2013-06-26 09:54 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/c2d9303c3477 8016908: TEST_BUG: removing non-ascii characters causes tests to fail Reviewed-by: jjg, vromero ! test/tools/javac/api/6437999/T6437999.java - test/

hg: jdk8/tl/jdk: 7018139: Fix HTML accessibility and doclint issues in java.math

2013-06-26 Thread joe . darcy
Changeset: 1fda8fa7ae97 Author:darcy Date: 2013-06-26 13:24 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/1fda8fa7ae97 7018139: Fix HTML accessibility and doclint issues in java.math Reviewed-by: lancea, bpb ! src/share/classes/java/math/BigDecimal.java ! src/share/classes/

hg: jdk8/tl/langtools: 8014137: Update test/tools/javac/literals/UnderscoreLiterals to add testcases with min/max values

2013-06-26 Thread jonathan . gibbons
Changeset: 3b2e10524627 Author:jjg Date: 2013-06-26 18:03 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/3b2e10524627 8014137: Update test/tools/javac/literals/UnderscoreLiterals to add testcases with min/max values Reviewed-by: jjg, darcy Contributed-by: matherey.nu..

hg: jdk8/tl/jdk: 8019223: Fix doclint warnings in java.rmi.server

2013-06-26 Thread joe . darcy
Changeset: a5aa57eb85b6 Author:darcy Date: 2013-06-26 19:09 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/a5aa57eb85b6 8019223: Fix doclint warnings in java.rmi.server Reviewed-by: smarks ! src/share/classes/java/rmi/server/RMIClassLoader.java

hg: jdk8/tl/langtools: 8014017: extra space in javadoc class heading

2013-06-26 Thread bhavesh . x . patel
Changeset: 27bd6a2302f6 Author:bpatel Date: 2013-06-26 20:42 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/27bd6a2302f6 8014017: extra space in javadoc class heading Reviewed-by: jjg ! src/share/classes/com/sun/tools/doclets/internal/toolkit/builders/ClassBuilder.jav

hg: jdk8/tl/langtools: 8013738: Two javadoc tests have bug 0000000

2013-06-26 Thread bhavesh . x . patel
Changeset: 36e8bc1907a2 Author:bpatel Date: 2013-06-26 20:45 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/36e8bc1907a2 8013738: Two javadoc tests have bug 000 Reviewed-by: jjg ! test/com/sun/javadoc/testNestedInlineTag/TestNestedInlineTag.java ! test/com/sun/java

hg: jdk8/tl/langtools: 8007338: Method grouping tab line-folding

2013-06-26 Thread bhavesh . x . patel
Changeset: 4fe5aab73bb2 Author:bpatel Date: 2013-06-26 20:38 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/4fe5aab73bb2 8007338: Method grouping tab line-folding Reviewed-by: jjg ! src/share/classes/com/sun/tools/doclets/internal/toolkit/resources/stylesheet.css ! te

hg: jdk8/tl/langtools: 8014230: Compilation incorrectly succeeds with inner class constructor with 254 parameters

2013-06-26 Thread eric . mccorkle
Changeset: c674b396827c Author:emc Date: 2013-06-27 00:37 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/c674b396827c 8014230: Compilation incorrectly succeeds with inner class constructor with 254 parameters Summary: The compiler does not account fr extra parameters d

hg: jdk8/tl/jdk: 8019228: Fix doclint issues in java.util.zip

2013-06-26 Thread joe . darcy
Changeset: ac65905883a7 Author:darcy Date: 2013-06-26 22:12 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/ac65905883a7 8019228: Fix doclint issues in java.util.zip Reviewed-by: sherman, mchung ! src/share/classes/java/util/zip/Deflater.java ! src/share/classes/java/util/zip