test/lib/testlibrary/jdk/testlibrary/PortFinder.java: - This looks racy to me. There is no guarantee that the port will still be available after the call to close(). - Missing copyright notice. - In comment "on of them" -> "one of them"
test/sun/management/jdp/ClientConnection.java: - broken indentation - inconsistent spacing in method calls. Sometime "joinGroup(address);" and sometimes "setSoTimeout( msTimeOut );". Should be without spaces. test/sun/management/jdp/DynamicLauncher.java: - type: binded -> bound - inconsistent spacing in method calls test/sun/management/jdp/JdpOffTest.java - broken indentation test/sun/management/jdp/JdpTestUtil.java - broken indentation I stopped reading here. Can we get these basic things fixed before the next review round, please? /Staffan On 26 jun 2013, at 12:21, Dmitry Samersoff <dmitry.samers...@oracle.com> wrote: > Nils, > > I'm sponsoring this push but don't see any review replies in this thread. > > Webrev refreshed against latest tl is here: > > http://cr.openjdk.java.net/~dsamersoff/JDK-8014506/webrev.01/ > > -Dmitry > > > On 2013-05-27 12:25, Alex Schenkman wrote: >> Please review these tests for the Jdp protocol. >> >> There are three cases: >> 1) Jdp is off. >> 2) Jdp is on and using default address and port. >> 3) Jdp is on using custom address and port. >> >> Tests: http://cr.openjdk.java.net/~nloodin/8014506/webrev.00/ >> <http://cr.openjdk.java.net/%7Enloodin/8014506/webrev.00/> >> Jdp feature enhancement: https://jbs.oracle.com/bugs/browse/JDK-8002048 >> JDK CCC: http://ccc.us.oracle.com/8002048 >> >> >> Thanks in advance! >> >> -- >> Alex Schenkman >> Java VM SQE Stockholm >> > > > -- > Dmitry Samersoff > Oracle Java development team, Saint Petersburg, Russia > * I would love to change the world, but they won't give me the sources.
