RFR 8043572: demo/jvmti/mtrace/TraceJFrame.java fails with AWTError: Can't connect to X11 window server using '$DISPLAY_SITE' as the value of the DISPLAY variable.

2014-05-23 Thread Jaroslav Bachorik
Please, review a simple test fix. Issue : https://bugs.openjdk.java.net/browse/JDK-8043572 Webrev: http://cr.openjdk.java.net/~jbachorik/8043572/webrev.00 The reason of failure is similar to JDK-8039432. Test tries to access the graphics subsystem unconditionally and on headless system it fails

Re: RFR 8043572: demo/jvmti/mtrace/TraceJFrame.java fails with AWTError: Can't connect to X11 window server using '$DISPLAY_SITE' as the value of the DISPLAY variable.

2014-05-23 Thread Staffan Larsen
Good one! I missed that TraceJFrame and JFrameCreateTime were different… Reviewed. /Staffan On 23 maj 2014, at 11:54, Jaroslav Bachorik wrote: > Please, review a simple test fix. > > Issue : https://bugs.openjdk.java.net/browse/JDK-8043572 > Webrev: http://cr.openjdk.java.net/~jbachorik/8043

Re: RFR: 8039995: Test serviceability/sa/jmap-hashcode/Test8028623.java fails on some Linux/Mac machines.

2014-05-23 Thread Peter Allwin
Looks good to me! Thanks for looking at this Kevin, /peter On 20 May 2014, at 13:14, Kevin Walls wrote: > Hi - any comments? 8-) > > On 12/05/14 16:02, Kevin Walls wrote: >> >> Hi, >> >> I'd like to get a review of this test change. It assumed that jmap would >> have permission to run on

Re: RFR: 8039995: Test serviceability/sa/jmap-hashcode/Test8028623.java fails on some Linux/Mac machines.

2014-05-23 Thread Dmitry Samersoff
Kevin, It might make sense to check output for "Error attaching to process:" regardless to exit code of jmap and terminate test immediately with appropriate exit code (internally, I use 7) to distinguish between PASS and ERROR. -Dmitry On 2014-05-20 15:14, Kevin Walls wrote: > Hi - any comme

Re: RFR: 8041923 Command line output is missing from jinfo

2014-05-23 Thread Peter Allwin
Looks good to me! /peter On 09 May 2014, at 16:30, Staffan Larsen wrote: > Before the fix of JDK-8036599 the jinfo -flags output contained: > > Non-default VM flags: -XX:InitialHeapSize=31457280 -XX:MaxHeapSize=31457280 > -XX:MaxNewSize=10485760 -XX:MinHeapDeltaBytes=524288 -XX:NewSize=157286

Re: RFR: 8041923 Command line output is missing from jinfo

2014-05-23 Thread Jaroslav Bachorik
Looks fine! -JB- On 05/09/2014 04:30 PM, Staffan Larsen wrote: Before the fix of JDK-8036599 the jinfo -flags output contained: Non-default VM flags: -XX:InitialHeapSize=31457280 -XX:MaxHeapSize=31457280 -XX:MaxNewSize=10485760 -XX:MinHeapDeltaBytes=524288 -XX:NewSize=1572864 -XX:OldSize=209

Re: RFR: 8041923 Command line output is missing from jinfo

2014-05-23 Thread Staffan Larsen
Peter, Jaroslav: Thanks! Any Reviewer out there willing to take a look? /Staffan On 23 maj 2014, at 15:51, Jaroslav Bachorik wrote: > Looks fine! > > -JB- > > On 05/09/2014 04:30 PM, Staffan Larsen wrote: >> Before the fix of JDK-8036599 the jinfo -flags output contained: >> >> Non-defaul

Re: RFR: 8041923 Command line output is missing from jinfo

2014-05-23 Thread Daniel D. Daugherty
> webrev: http://cr.openjdk.java.net/~sla/8041923/webrev.00/ src/share/classes/sun/tools/jinfo/JInfo.java No comments. Thumbs up. Dan On 5/23/14 8:03 AM, Staffan Larsen wrote: Peter, Jaroslav: Thanks! Any Reviewer out there willing to take a look? /Staffan On 23 maj 2014, at 15:51, J

Re: RFR: 8041923 Command line output is missing from jinfo

2014-05-23 Thread Staffan Larsen
Thanks! On 23 maj 2014, at 16:26, Daniel D. Daugherty wrote: > > webrev: http://cr.openjdk.java.net/~sla/8041923/webrev.00/ > > src/share/classes/sun/tools/jinfo/JInfo.java >No comments. > > Thumbs up. > > Dan > > > On 5/23/14 8:03 AM, Staffan Larsen wrote: >> Peter, Jaroslav: Thanks!