Re: [9] RFR (M) 8054888: Runtime: Add Diagnostic Command that prints the class hierarchy

On 01/08/2015 10:29 PM, Chris Plummer wrote: Hi Karen, Comments inline. On 1/8/15 8:07 AM, Karen Kinnear wrote: Chris, Thank you for doing this. I had a couple of questions/comments. I like your idea of being able to start with a specific class to show all subclasses of. Ok. I'll add that

Re: [9] RFR (M) 8054888: Runtime: Add Diagnostic Command that prints the class hierarchy

On 2015-01-08 20:15, Chris Plummer wrote: Hi Stefan, Comments inline below: On 1/8/15 2:50 AM, Stefan Karlsson wrote: Hi Chris, On 2015-01-08 00:29, Chris Plummer wrote: Hi, Please review the following changes for the addition of the VM.class_hierarchy DCMD. Please read the bug first for

Re: RFR 8066708: JMXStartStopTest fails to connect to port 38112

Stuart, > The range that Dmitry suggests is reasonable, though I note that the > actual ephemeral port range used by the kernel will differ from OS to > OS and even from system to system. I don't know if that's really > significant though. If you end up choosing a port outside the > ephemeral rang

Re: RFR(XXS): 8068584: Compiler attach tests should be quarantined

Looks good to me. I'm not a reviewer though. Mikael On 2015-01-08 13:45, Mattias Tobiasson wrote: > Thanks for the explanation. > I have moved the @ignore tags to directly before the first @run tag. > > webrev: http://cr.openjdk.java.net/~ykantser/8068584/webrev.01/ >

Re: RFR 8066708: JMXStartStopTest fails to connect to port 38112

Thank you all for the valuable input! On 9.1.2015 03:50, Stuart Marks wrote: Hi Jaroslav, I'm distant enough from this code that I don't think I'm in a position to say "no you can't check this in," and I'm mindful of the fact that this bug is a high priority and you want to get a fix in. But ha

Re: [9] RFR (M) 8054888: Runtime: Add Diagnostic Command that prints the class hierarchy

It’s getting difficult to get all the information into the same output: hierarchy, interfaces, class loaders and modules. I took a stab at it and it could look like this: java.lang.Object |--java.io.Serializable (java.base, 0x0007c00375f8, iface) |--java.util.RandomAccess (java.base, 0x0

RFR(XXS): 8068718: com/sun/jdi/CatchPatternTest.sh should be quarantined

Hi, Could I please have a review of addition to ProblemList. bug: https://bugs.openjdk.java.net/browse/JDK-8068718 webrev: http://cr.openjdk.java.net/~miauno/8068718/webrev.00/ Thanks, Mikael

Re: RFR(XXS): 8068718: com/sun/jdi/CatchPatternTest.sh should be quarantined

Looks good! -JB- On 9.1.2015 13:54, Mikael Auno wrote: Hi, Could I please have a review of addition to ProblemList. bug: https://bugs.openjdk.java.net/browse/JDK-8068718 webrev: http://cr.openjdk.java.net/~miauno/8068718/webrev.00/ Thanks, Mikael

Re: RFR(XXS): 8068718: com/sun/jdi/CatchPatternTest.sh should be quarantined

Thanks for the review! Mikael On 2015-01-09 13:59, Jaroslav Bachorik wrote: > Looks good! > > -JB- > > On 9.1.2015 13:54, Mikael Auno wrote: >> Hi, >> >> Could I please have a review of addition to ProblemList. >> >> bug: https://bugs.openjdk.java.net/browse/JDK-8068718 >> webrev: http://cr.ope

RE: RFR(XXS): 8068584: Compiler attach tests should be quarantined

Looks good. Thanks, Christian -Original Message- From: serviceability-dev [mailto:serviceability-dev-boun...@openjdk.java.net] On Behalf Of Mattias Tobiasson Sent: Thursday, January 8, 2015 7:45 AM To: Mikael Auno; serviceability-dev@openjdk.java.net Subject: Re: RFR(XXS): 8068584: Compi

Re: [9] RFR (M) 8054888: Runtime: Add Diagnostic Command that prints the class hierarchy

Staffan, On Jan 9, 2015, at 7:38 AM, Staffan Larsen wrote: > It’s getting difficult to get all the information into the same output: > hierarchy, interfaces, class loaders and modules. I took a stab at it and it > could look like this: > > java.lang.Object > |--java.io.Serializable (java.base,

Re: [9] RFR (M) 8054888: Runtime: Add Diagnostic Command that prints the class hierarchy

Thanks Frederic for suggesting two different dcmds - they could share a lot of the code logic. If folks generally prefer these as separate dcmds - I can file an rfe to add the inverted one - i.e. start at a given class/interface and tell me its supertypes. thanks, Karen On Jan 9, 2015, at 3:53 A

Re: [9] RFR (M) 8054888: Runtime: Add Diagnostic Command that prints the class hierarchy

> On 9 jan 2015, at 18:49, Karen Kinnear wrote: > > Staffan, > > On Jan 9, 2015, at 7:38 AM, Staffan Larsen wrote: > >> It’s getting difficult to get all the information into the same output: >> hierarchy, interfaces, class loaders and modules. I took a stab at it and it >> could look like t

Re: [9] RFR (M) 8054888: Runtime: Add Diagnostic Command that prints the class hierarchy

On 1/9/15 4:38 AM, Staffan Larsen wrote: It�s getting difficult to get all the information into the same output: hierarchy, interfaces, class loaders and modules. I took a stab at it and it could look like this: java.l

Re: [9] RFR (M) 8054888: Runtime: Add Diagnostic Command that prints the class hierarchy

On 1/9/15 4:38 AM, Staffan Larsen wrote: It�s getting difficult to get all the information into the same output: hierarchy, interfaces, class loaders and modules. I took a stab at it and it could look like this: java.l