Looks good. Thanks, Christian
-----Original Message----- From: serviceability-dev [mailto:serviceability-dev-boun...@openjdk.java.net] On Behalf Of Mattias Tobiasson Sent: Thursday, January 8, 2015 7:45 AM To: Mikael Auno; serviceability-dev@openjdk.java.net Subject: Re: RFR(XXS): 8068584: Compiler attach tests should be quarantined Thanks for the explanation. I have moved the @ignore tags to directly before the first @run tag. webrev: http://cr.openjdk.java.net/~ykantser/8068584/webrev.01/ <http://cr.openjdk.java.net/%7Eykantser/8068584/webrev.01/> Mattias On 01/08/2015 11:21 AM, Mikael Auno wrote: > On 2015-01-08 11:04, Mattias Tobiasson wrote: >> Hi, >> Could I please have a review of this bug quarantine. >> >> bug: https://bugs.openjdk.java.net/browse/JDK-8068584 >> webrev: http://cr.openjdk.java.net/~ykantser/8068584/webrev.00/ >> >> Thanks, >> Mattias >> > Mattias, > > In the two **/Launcher.java tests, you must place @ignore after the > @library line, otherwise there will be a "Parse Exception: `@library' > must appear before first `@run'". (The error message is, to say the > least, a bit unintuitive until you figure out that "@ignore" is just > an alias for "@run ignore".) > > Mikael
