Re: RFR:8148103:add more tests for task "Update JDI and JDWP for modules"

Hi Sergey, Thank you very much for the review. I've submitted JDK-8165017 as you have suggested. Best regards, Alexander - Original Message - From: serguei.spit...@oracle.com To: alexander.kulyakh...@oracle.com Cc: christian.tornqv...@oracle.com, serviceability-dev@openjdk.java.n

Re: RFR:8148103:add more tests for task "Update JDI and JDWP for modules"

Hi Alexander, On 8/30/16 02:56, Alexander Kulyakhtin wrote: Hi Sergey, Thank you very much for the review. I've submitted JDK-8165017 as you have suggested. Ok, thanks! Is it enough to have one review for test enhancements? Also, do you hav

Fwd: RFR:8139368:-javaagent and -Dcom.sun.management need to add to the initial set of modules to resolve

Hi, Could I, please, have some feedback on the RFR below (adding a new test for the -javaagent option)? Best regards, Alexander - Forwarded Message - From: alexander.kulyakh...@oracle.com To: serviceability-dev@openjdk.java.net Cc: christian.tornqv...@oracle.com, alan.bate...@oracle.com

RE: PING : RFR : JDK-8066635 - Fix deprecation warnings in java.management module

Hello, Fixed the alignment problem as well. Here is the updated webrev. http://cr.openjdk.java.net/~jgeorge/sponsorships/8066635/webrev.02/ Thanks, Amit -Original Message- From: David Holmes Sent: Tuesday, August 30, 2016 11:44 AM To: Amit Sapre; serviceability-dev Subject: Re: PING :

Re: PING : RFR : JDK-8066635 - Fix deprecation warnings in java.management module

On 30/08/2016 8:39 PM, Amit Sapre wrote: Hello, Fixed the alignment problem as well. Here is the updated webrev. http://cr.openjdk.java.net/~jgeorge/sponsorships/8066635/webrev.02/ Can you use the original style for this please. No need to see an updated webrev. Thanks, David Thanks, Amit

Re: RFR:(S): 8164562: serviceability/sa/TestInstanceKlassSizeForInterface.java: fails with NPE

Thanks Alejandro. A minor correction - the patch is pushed to jdk9/hs/hotspot which is the right repo to fix this issue. I did a grep on jdk9/hs/hotspot/test and find no other test changes using the old CLI options. I have covered the necessary changes in jdk9/dev/hotspot/test in [1]. Mandy

Re: RFR JDK-8152589 : java/lang/management/ThreadMXBean/Locks.java fails intermittently, blocked on wrong object

On 8/29/16 8:51 PM, David Holmes wrote: On 30/08/2016 9:08 AM, Daniel D. Daugherty wrote: On 8/23/16 6:17 AM, Harsha Wardhana B wrote: Hi David, You approach to waiter object is a neat little abstraction and I will make it a point to use it in future fixes, if required. revised webrev : htt