Hello,
Please review and push the fix.
This is a formal letter after the discussion on the alias.
Bug:https://bugs.openjdk.java.net/browse/JDK-8194143
Webrev:http://cr.openjdk.java.net/~avu/egor.ushakov/cast_fix/
--
Egor Ushakov
Software Developer
JetBrains
http://www.jetbrains.com
The Drive to
Thanks, Egor!
I'll sponsor the push.
Do I have to run the JDI tests, or already tested it with the
JTreg JDI tests?
Thanks,
Serguei
On 1/17/18 01:15, Egor Ushakov wrote:
Hello,
Please review and push
Thanks, Serguei.
We have tested this with JTreg tests already.
On 17-Jan-18 12:35, serguei.spit...@oracle.com wrote:
Thanks, Egor!
I'll sponsor the push.
Do I have to run the JDI tests, or already tested it with the JTreg
JDI tests?
Thanks,
Serguei
On 1/17/18 01:15, Egor Ushakov wrote:
Hi Egor,
On 17/01/2018 7:15 PM, Egor Ushakov wrote:
Hello,
Please review and push the fix.
This is a formal letter after the discussion on the alias.
Bug:https://bugs.openjdk.java.net/browse/JDK-8194143
Webrev:http://cr.openjdk.java.net/~avu/egor.ushakov/cast_fix/
The underlying link actuall
Here’s an updated webrev addressing the comments from David Holmes.
1. Moved new cgroup specific support from unix -> Linux and put stubs in all
other OS's
2. Reduced the size of the stack arrays in perfMemory_linux.cpp
There are still two outstanding issues:
[serviceability] : Can we and sho
Hi Egor and David,
Both webrevs below are from Daniil Titov on the JVMTI bug: JDK-8153629.
Also, I expect new webrev is based on the JDK 11 jdk/hs repository and
with 2018 copyright comments updated.
Thanks,
Serguei
On 1/17/18 02:24, David Holmes wrote:
Hi Egor,
On 17/01/2018 7:15 PM, Egor
Is the link http://cr.openjdk.java.net/~avu/egor.ushakov/cast_fix
broken? for me it works well.
attaching the patch just in case.
It was created on jdk10, do I need to recreate it based on jdk11 with
the 2018 copyrights?
On 17-Jan-18 20:26, serguei.spit...@oracle.com wrote:
Hi Egor and David,
On 1/17/18 09:26, serguei.spit...@oracle.com wrote:
Hi Egor and David,
Both webrevs below are from Daniil Titov on the JVMTI bug: JDK-8153629.
Sorry, it is not fully correct.
The first is the old link points to the jdk 10 related webrev with an
uncommitted patch and 2017 copyright comments.
Got it, will do!
BTW who are the reviewers? You and David?
On 17-Jan-18 20:34, serguei.spit...@oracle.com wrote:
On 1/17/18 09:26, serguei.spit...@oracle.com wrote:
Hi Egor and David,
Both webrevs below are from Daniil Titov on the JVMTI bug: JDK-8153629.
Sorry, it is not fully correct.
Th
On 1/17/18 09:32, Egor Ushakov wrote:
Is the link http://cr.openjdk.java.net/~avu/egor.ushakov/cast_fix
broken? for me it works well.
attaching the patch just in case.
It was my mistake this time, sorry. :(
Please, see my previous message.
It was created on jdk10, do I need to recreate it ba
On 1/17/18 09:36, Egor Ushakov wrote:
Got it, will do!
BTW who are the reviewers? You and David?
I think so.
Thanks,
Serguei
On 17-Jan-18 20:34, serguei.spit...@oracle.com wrote:
On 1/17/18 09:26, serguei.spit...@oracle.com wrote:
Hi Egor and David,
Both webrevs below are from Daniil Ti
Hi Bob,
I think the new methods in VMSupport and probablywith
VMSupport.getVMTemporaryDirectory should belong to jdk.internal.jvmstat
as they are specific for jvmstat and attach API to use.
W.r.t VMSupportImpl, the implementation is the same for all platforms
except Linux. One option is to
I put these new methods in VMSupport since this was the class containg the
getVMTemporaryDirectory and
the intention of this class was document as:
/*
* Support class used by JVMTI and VM attach mechanism.
*/
class VMSupport {
I could create a new PerfDataFileImpl or jdk.internal.jvmstat.VMSup
Hi Daniil,
Have you run with -Xcomp. I'm concerned that inlining will cause the
test to fail because stack depths will not be as expected. Also, if you
find the owned monitor, but the depth is not as expected, I think you
are better off printing an error message right away rather than the
som
Hi Daniil,
Some nits.
207 if (monitorCount == 3) {
208 for (idx = 0; idx < 3; idx++) {
Need to get rid of hardcoded number of monitors (3).
184 err = (*jvmti) -> GetCurrentThread(jvmti, &thread);
Extra spaces around '->'.
214 TEST_CLASS,
On 1/17/18 12:21, serguei.spit...@oracle.com wrote:
Hi Daniil,
Some nits.
207 if (monitorCount == 3) {
208 for (idx = 0; idx < 3; idx++) {
Need to get rid of hardcoded number of monitors (3).
184 err = (*jvmti) -> GetCurrentThread(jvmti, &thread);
Extra spaces around
Thank you, Serguei and Chris!
The test runs successfully in mach5 when –Xcomp Java option is added. Please
review a new version of patch that changes the way how the error messages are
printed as suggested.
Webrev: http://cr.openjdk.java.net/~dtitov/8153629/webrev.03/
Bug: https://bugs.openjdk
Daniil,
Looks great!
Could you, please, make a minor cleanup of status handling?
60 jint status = FAILED;
=>
60 jint status = PASSED;
At the lines 167, 173, 179, 186 and 192:
return status;
=>
return FAILED;
And remove the line:
205 status = PASSED;
No need for anoth
Hi Daniil,
Looks good. Thanks for the -Xcomp testing.
Chris
On 1/17/18 1:36 PM, Daniil Titov wrote:
Thank you, Serguei and Chris!
The test runs successfully in mach5 when –Xcomp Java option is added. Please
review a new version of patch that changes the way how the error messages are
printe
Hi Jesper,
cc'd serviceability-dev
On 18/01/2018 7:03 AM, jesper.wilhelms...@oracle.com wrote:
Hi,
A new JBS component is now available for the serviceability agent:
hotspot/svc-agent
This means that the old label svc-sa is deprecated and any issue that had this
label has been moved to the n
On 18/01/2018 3:32 AM, Egor Ushakov wrote:
Is the link http://cr.openjdk.java.net/~avu/egor.ushakov/cast_fix
broken? for me it works well.
To clarify ... your earlier email was in multi-part-mime format
including a plain text and html part. The html version has:
Bug: href="https://bugs.openj
On 1/17/18 14:36, David Holmes wrote:
On 18/01/2018 3:32 AM, Egor Ushakov wrote:
Is the link http://cr.openjdk.java.net/~avu/egor.ushakov/cast_fix
broken? for me it works well.
To clarify ... your earlier email was in multi-part-mime format
including a plain text and html part. The html versi
> On 17 Jan 2018, at 23:26, David Holmes wrote:
>
> Hi Jesper,
>
> cc'd serviceability-dev
>
> On 18/01/2018 7:03 AM, jesper.wilhelms...@oracle.com wrote:
>> Hi,
>> A new JBS component is now available for the serviceability agent:
>> hotspot/svc-agent
>> This means that the old label svc-sa
On 1/17/18 11:08 AM, Bob Vandette wrote:
I put these new methods in VMSupport since this was the class containg the
getVMTemporaryDirectory and
the intention of this class was document as:
/*
* Support class used by JVMTI and VM attach mechanism.
*/
class VMSupport {
I looked at the hist
24 matches
Mail list logo
