HotSpot Serviceability Agent (SA) Survey

Hi, The HotSpot Serviceability Agent (SA) is a set of APIs and tools for debugging HotSpot Virtual Machine and has been a part of the JVM/JDK for a long time, however we don't have a lot of data about how it is used in practice, especially outside of Oracle. Therefore, we have created an

Re: RFR 8199467 Compilation Errors in libinstrument Reentrancy.c with VS2017

On Wed, Mar 21, 2018 at 12:13 PM, Roger Riggs wrote: > > -void * test = (void *) 0x; > +void * test = (void *) 0xul; > Martin's 15th law: Never use "l" in a numeric constant unless the constant is 0xCafeBabel, so 0xUL

Re: RFR(S): 8198655: test/lib/jdk/test/lib/apps/LingeredApp shouldn't inherit cout/cerr

Yeah, this was all new to me. Before this I didn't know anything about jtreg IO other than the use of OutputAnalyzer for capture and verification. Thanks for reviewing. Chris On 3/21/18 11:08 AM, serguei.spit...@oracle.com wrote: Hi Chris, It looks good to me. It is a little bit more

Re: RFR(S): 8195109: ServiceUtil::visible_oop is not needed anymore

Hi Chris, It looks good. Thanks, Serguei On 3/20/18 12:39, Chris Plummer wrote: Hi, New webrev: http://cr.openjdk.java.net/~cjplummer/8195109/webrev.01/index.html There was a build failure on solaris-sparc in threadSMR.cpp. References to the Copy class were producing "unresolved symbol"

RFR 8199467 Compilation Errors in libinstrument Reentrancy.c with VS2017

Please review a small change to avoid sign extension in libinstrument/ Reentrancy.c to correct an compilation warning with vs2017. diff --git a/src/java.instrument/share/native/libinstrument/Reentrancy.c b/src/java.instrument/share/native/libinstrument/Reentrancy.c ---

Re: RFR(S): 8198655: test/lib/jdk/test/lib/apps/LingeredApp shouldn't inherit cout/cerr

Hi Chris, It looks good to me. It is a little bit more complicated than one would expect but reasonable. Thanks, Serguei On 3/21/18 09:31, Chris Plummer wrote: Ping. I still need a couple of reviews for this. thanks, Chris On 3/19/18 3:50 PM, Chris Plummer wrote: I looked into modifying

Re: RFR 8199467 Compilation Errors in libinstrument Reentrancy.c with VS2017

Hi Roger, It looks good to me. Thank you for taking care about this! Thanks, Serguei On 3/21/18 12:13, Roger Riggs wrote: Please review a small change to avoid sign extension in libinstrument/ Reentrancy.c to correct an compilation warning with vs2017. diff --git

Re: RFR(S) 8199924: Solaris: Correctly enqueue null arguments of attach operations

Hi Christoph, On 21/03/2018 6:10 PM, Langer, Christoph wrote: Hi, may I please ask for reviews of the following small fix. Webrev: http://cr.openjdk.java.net/~clanger/webrevs/8199924.0/ Bug: https://bugs.openjdk.java.net/browse/JDK-8199924 If one passes null arguments to the varargs of

Re: RFR(S): 8195109: ServiceUtil::visible_oop is not needed anymore

Looks good. StefanK On 2018-03-20 20:39, Chris Plummer wrote: Hi, New webrev: http://cr.openjdk.java.net/~cjplummer/8195109/webrev.01/index.html There was a build failure on solaris-sparc in threadSMR.cpp. References to the Copy class were producing "unresolved symbol" errors.

RFR(S) 8199924: Solaris: Correctly enqueue null arguments of attach operations

Hi, may I please ask for reviews of the following small fix. Webrev: http://cr.openjdk.java.net/~clanger/webrevs/8199924.0/ Bug: https://bugs.openjdk.java.net/browse/JDK-8199924 If one passes null arguments to the varargs of attach operations, they get swallowed on Solaris and following

RE: RFR(S) 8199924: Solaris: Correctly enqueue null arguments of attach operations

Hi David, thanks for looking at this. I currently have no emotions whether to fix it in C or in Java - I'll check it out... Best regards Christoph > -Original Message- > From: David Holmes [mailto:david.hol...@oracle.com] > Sent: Mittwoch, 21. März 2018 10:20 > To: Langer, Christoph

Re: RFR(S) 8199924: Solaris: Correctly enqueue null arguments of attach operations

On 22/03/2018 12:51 AM, Daniel D. Daugherty wrote: On 3/21/18 10:23 AM, Daniel D. Daugherty wrote: On 3/21/18 10:00 AM, Langer, Christoph wrote: Hi Dan, that is, you mean the C-code? My original change? Hmmm... I think I confused myself before I drank enough coffee... Looking again...

Re: RFR(S): 8198655: test/lib/jdk/test/lib/apps/LingeredApp shouldn't inherit cout/cerr

Sorry Chris I just don't have time to try and figure this one out. If it works uses it. David On 22/03/2018 4:24 AM, Chris Plummer wrote: Yeah, this was all new to me. Before this I didn't know anything about jtreg IO other than the use of OutputAnalyzer for capture and verification. Thanks

Re: RFR: 8049695: nsk/jdb/options/connect/connect003 fails with "Launched jdb could not attach to debuggee during 300000 milliseconds"

On 22/03/2018 2:41 AM, Alex Menkov wrote: Hi David, On 03/20/2018 21:51, David Holmes wrote: Hi Alex, On 21/03/2018 3:25 AM, Alex Menkov wrote: Hi David, On 03/19/2018 18:10, David Holmes wrote: Hi Alex, On 20/03/2018 10:28 AM, Alex Menkov wrote: Hi guys, please re-review the fix. I

Re: RFR(S): 8198655: test/lib/jdk/test/lib/apps/LingeredApp shouldn't inherit cout/cerr

Hi Chris, the changeset looks reasonable, reviewed. Thanks, -- Igor > On Mar 21, 2018, at 3:26 PM, David Holmes wrote: > > Sorry Chris I just don't have time to try and figure this one out. If it > works uses it. > > David > > On 22/03/2018 4:24 AM, Chris Plummer

RE: RFR(S) 8199924: Solaris: Correctly enqueue null arguments of attach operations

Hi Dan, that is, you mean the C-code? My original change? Best regards Christoph > -Original Message- > From: Daniel D. Daugherty [mailto:daniel.daughe...@oracle.com] > Sent: Mittwoch, 21. März 2018 14:59 > To: Langer, Christoph ; David Holmes >

Re: RFR(S) 8199924: Solaris: Correctly enqueue null arguments of attach operations

Hmmm... shouldn't the inconsistency in the Solaris backend also be addressed? Dan On 3/21/18 8:45 AM, Langer, Christoph wrote: Hi David, thanks for looking at this. I currently have no emotions whether to fix it in C or in Java - I'll check it out... Best regards Christoph -Original

Re: RFR(S) 8199924: Solaris: Correctly enqueue null arguments of attach operations

On 3/21/18 10:23 AM, Daniel D. Daugherty wrote: On 3/21/18 10:00 AM, Langer, Christoph wrote: Hi Dan, that is, you mean the C-code? My original change? Hmmm... I think I confused myself before I drank enough coffee... Looking again... Okay I definitely confused myself... and I clearly

Re: RFR(S) 8199924: Solaris: Correctly enqueue null arguments of attach operations

Forgot to make it clear that I did review the change... > Webrev: http://cr.openjdk.java.net/~clanger/webrevs/8199924.0/ src/jdk.attach/solaris/native/libattach/VirtualMachineImpl.c     No comments. Thumbs up. Dan On 3/21/18 10:51 AM, Daniel D. Daugherty wrote: On 3/21/18 10:23 AM, Daniel

Re: RFR(S): 8198655: test/lib/jdk/test/lib/apps/LingeredApp shouldn't inherit cout/cerr

Ping. I still need a couple of reviews for this. thanks, Chris On 3/19/18 3:50 PM, Chris Plummer wrote: I looked into modifying OutputAnalyzer (actually ended up being ProcessTools that needed all the changes) to be more flexible so it could support LingeredApp. The problem I ran into is

Re: RFR(S) 8199924: Solaris: Correctly enqueue null arguments of attach operations

On 3/21/18 10:00 AM, Langer, Christoph wrote: Hi Dan, that is, you mean the C-code? My original change? Hmmm... I think I confused myself before I drank enough coffee... Looking again... Dan Best regards Christoph -Original Message- From: Daniel D. Daugherty

Re: RFR: 8049695: nsk/jdb/options/connect/connect003 fails with "Launched jdb could not attach to debuggee during 300000 milliseconds"

Hi David, On 03/20/2018 21:51, David Holmes wrote: Hi Alex, On 21/03/2018 3:25 AM, Alex Menkov wrote: Hi David, On 03/19/2018 18:10, David Holmes wrote: Hi Alex, On 20/03/2018 10:28 AM, Alex Menkov wrote: Hi guys, please re-review the fix. I still have an unanswered question about