[8u-backport] RFR: JDK-8191948: jdb error: InvalidTypeException: Can't assign double[][][] to double[][][]

Hi, Kindly review the backport of "JDK-8191948: jdb error: InvalidTypeException: Can't assign double[][][] to double[][][]" to 8u Webrev - http://cr.openjdk.java.net/~fmatte/8191948/webrev.00/ JDK 11 bug - https://bugs.openjdk.java.net/browse/JDK-8191948 JDK 11 changeset - http://hg.openj

Re: RFR JDK-8170089: nsk/jdi/EventSet/resume/resume008: ERROR: suspendCounts don't match for : Common-Cleaner

During some longer testing runs I noticed similar failures for resume002, resume003 and resume006. I'll spend a few more cycles to see if a more general purpose solution could be shared across these tests. On 7/24/18 7:46 PM, Chris Plummer wrote: Hi Gary, It looks like that should work fine. t

Re: RFR (XS) 8208059: [TESTBUG] HeapMonitorInterpreterArrayTest.java fails

On 7/25/18 10:20 AM, JC Beyler wrote: Hi all, There seems to be an intermittent failure with the HeapMonitorInterpreterArrayTest. I believe it is due to the possibility of a huge interval being chosen at the end of the test and GC arriving before checking the samples. This fix should help a

Re: [8u-backport] RFR: JDK-8191948: jdb error: InvalidTypeException: Can't assign double[][][] to double[][][]

Hi Fairoz, The changes look good. I'm not sure what the policy is when part of the (full) backport contains test changes that aren't directly applicable to 8u. You might need some sort of noreg label on the backport CR. thanks, Chris On 7/25/18 1:23 AM, Fairoz Matte wrote: Hi, Kindly revi

Re: RFR (XS) 8208059: [TESTBUG] HeapMonitorInterpreterArrayTest.java fails

Thanks for your help Daniel, Could I get a second review and I'll prepare an updated webrev :) Jc On Wed, Jul 25, 2018 at 7:42 AM Daniel D. Daugherty < daniel.daughe...@oracle.com> wrote: > On 7/25/18 10:20 AM, JC Beyler wrote: > > Hi all, > > There seems to be an intermittent failure with the >

Re: RFR (XS) 8208059: [TESTBUG] HeapMonitorInterpreterArrayTest.java fails

Hi Jc, It looks good. I'll push it after you send me a patch. On 7/25/18 07:42, Daniel D. Daugherty wrote: On 7/25/18 10:20 AM, JC Beyler wrote: Hi all, There seems to be an intermittent

Re: RFR (XS) 8208059: [TESTBUG] HeapMonitorInterpreterArrayTest.java fails

Hi Serguei, Here it is: http://cr.openjdk.java.net/~jcbeyler/8208059/webrev.01/ Let me know if you need anything else and thanks for your help! Jc On Wed, Jul 25, 2018 at 10:37 AM serguei.spit...@oracle.com < serguei.spit...@oracle.com> wrote: > Hi Jc, > > It looks good. > I'll push it after yo

Re: [8u-backport] RFR: JDK-8191948: jdb error: InvalidTypeException: Can't assign double[][][] to double[][][]

Hi Fairoz, Looks good to me too. Thank you for taking care about this backport! On 7/25/18 10:31, Chris Plummer wrote: Hi Fairoz, The changes look good. I'm not sure what the policy is when part of the (full)

Re: RFR(S): 8151259: [TESTBUG] nsk/jvmti/RedefineClasses/redefclass030 fails with "unexpected values of outer fields of the class" when running with -Xcomp

Looks good to me --alex On 07/24/2018 16:23, Chris Plummer wrote: Thanks, Serguei. I could use one more reviewer. thanks, Chris On 7/24/18 3:00 PM, serguei.spit...@oracle.com wrote: Chris, Thank you for the explanations. I'm Okay with this webrev as it is. Thanks, Serguei On 7/24/18 13

Re: RFR (XS) 8208059: [TESTBUG] HeapMonitorInterpreterArrayTest.java fails

Hi Jc, Pushed now. Thanks! Serguei On 7/25/18 10:54, JC Beyler wrote: Hi Serguei, Here it is: http://cr.openjdk.java.net/~jcbeyler/8208059/webrev.01/ L

Re: RFR(S): 8151259: [TESTBUG] nsk/jvmti/RedefineClasses/redefclass030 fails with "unexpected values of outer fields of the class" when running with -Xcomp

Thanks! On 7/25/18 11:00 AM, Alex Menkov wrote: Looks good to me --alex On 07/24/2018 16:23, Chris Plummer wrote: Thanks, Serguei. I could use one more reviewer. thanks, Chris On 7/24/18 3:00 PM, serguei.spit...@oracle.com wrote: Chris, Thank you for the explanations. I'm Okay with this

RFR: JDK-8199155 : Accessibility issues in jdk.jdi

Hi, please review the following for for https://bugs.openjdk.java.net/browse/JDK-8199155 webrev: http://cr.openjdk.java.net/~amenkov/accessibility/webrev/ The fix adds standard "banner", "navigation", "main" regions and fixes " without " issue. For styles which are used by most browsers are us

Re: JDK-8199155 : Accessibility issues in jdk.jdi

Looks good to me. --Daniil On 7/25/18, 11:23 AM, "serviceability-dev on behalf of Alex Menkov" wrote: Hi, please review the following for for https://bugs.openjdk.java.net/browse/JDK-8199155 webrev: http://cr.openjdk.java.net/~amenkov/accessibility/webrev/

RFR(XS): 8208205: ProblemList tests that fail due to 'Error attaching to process: Can't create thread_db agent!'

Greetings, I'm in the process of reducing the noise in the JDK11 and JDK12 CIs so I need a single (R)eviewer for the following fix:   JDK-8208205 ProblemList tests that fail due to 'Error attaching to   process: Can't create thread_db agent!'   https://bugs.openjdk.java.net/browse/JD

Re: RFR(XS): 8208205: ProblemList tests that fail due to 'Error attaching to process: Can't create thread_db agent!'

Hi Dan, Looks good to me. Thanks for cleaning up the noise. Chris On 7/25/18 12:03 PM, Daniel D. Daugherty wrote: Greetings, I'm in the process of reducing the noise in the JDK11 and JDK12 CIs so I need a single (R)eviewer for the following fix:   JDK-8208205 ProblemList tests that fail due

Re: RFR(XS): 8208205: ProblemList tests that fail due to 'Error attaching to process: Can't create thread_db agent!'

Chris, Thanks for the quick review! Dan On 7/25/18 3:32 PM, Chris Plummer wrote: Hi Dan, Looks good to me. Thanks for cleaning up the noise. Chris On 7/25/18 12:03 PM, Daniel D. Daugherty wrote: Greetings, I'm in the process of reducing the noise in the JDK11 and JDK12 CIs so I need a si

Re: JDK-8199155 : Accessibility issues in jdk.jdi

Hi Alex, +1 Thanks, Serguei On 7/25/18 11:47, Daniil Titov wrote: Looks good to me. --Daniil On 7/25/18, 11:23 AM, "serviceability-dev on behalf of Alex Menkov" wrote: Hi, please review the following for for https://bugs.openjdk.java.net/browse/JDK-8199155

RFR(XXS): 8208226 ProblemList com/sun/jdi/BasicJDWPConnectionTest.java

Greetings, I'm in the process of reducing the noise in the JDK11 and JDK12 CIs so I need a single (R)eviewer for the following fix:   JDK-8208226 ProblemList com/sun/jdi/BasicJDWPConnectionTest.java   https://bugs.openjdk.java.net/browse/JDK-8208226 Here's the diff: $ hg diff diff -r ec6d58430

Re: RFR(XXS): 8208226 ProblemList com/sun/jdi/BasicJDWPConnectionTest.java

Hi Dan, Looks good. Thanks, Serguei On 7/25/18 13:50, Daniel D. Daugherty wrote: Greetings, I'm in the process of reducing the noise in the JDK11 and JDK12 CIs so I need a single (R)eviewer for the following fix:   JDK-8208226 ProblemList com/sun/jdi/BasicJDWPConnectionTest.java   https://b

Re: RFR(XXS): 8208226 ProblemList com/sun/jdi/BasicJDWPConnectionTest.java

Serguei, Thanks for the very fast review! Dan On 7/25/18 5:03 PM, serguei.spit...@oracle.com wrote: Hi Dan, Looks good. Thanks, Serguei On 7/25/18 13:50, Daniel D. Daugherty wrote: Greetings, I'm in the process of reducing the noise in the JDK11 and JDK12 CIs so I need a single (R)eview

RFR 8207364: nsk/jvmti/ResourceExhausted/resexhausted003 fails to start

Hello, Please review the change that fix the test issue. The fix increases the metaspace size and corrects the path to the class files. Webrev: http://cr.openjdk.java.net/~dtitov/8207364/webrev.01/ Issue: https://bugs.openjdk.java.net/browse/JDK-8207364 Thanks! Best regards, Daniil

Re: RFR 8207364: nsk/jvmti/ResourceExhausted/resexhausted003 fails to start

Hi Daniil, It looks good to me. What is the need to increase the metaspace size? Thanks, Serguei On 7/25/18 16:11, Daniil Titov wrote: Hello, Please review the change that fix the test issue. The fix increases the metaspace size and corrects the path to the class files. Webrev: http://cr.

Re: RFR 8207364: nsk/jvmti/ResourceExhausted/resexhausted003 fails to start

Hi Serguei, On 64 bit machines Java fails to initialize a VM and prints " MaxMetaspaceSize is too small." diagnostic if the max metaspace size set to 8MB or less (java -XX:MaxMetaspaceSize=8m) Per open/src/hotspot/share/memory/metaspace.cpp (line 1140) and open/src/hotspot/share/runtime/glo

Re: RFR 8207364: nsk/jvmti/ResourceExhausted/resexhausted003 fails to start

Daniil, Thank you for the explanation. Thanks, Serguei On 7/25/18 17:38, Daniil Titov wrote: Hi Serguei, On 64 bit machines Java fails to initialize a VM and prints " MaxMetaspaceSize is too small." diagnostic if the max metaspace size set to 8MB or less (java -XX:MaxMetaspaceSize=8m) P

Re: RFR 8207364: nsk/jvmti/ResourceExhausted/resexhausted003 fails to start

Hi Daniil, After reading some old comments I added to JDK-6606767, I wonder if bumping the metaspace size all the way up to 16m is the right thing to do. It seems the test wants to exhaust the metaspace, so maybe it should be set it to the smallest allowed size. Is the test still exhausting th

RE: [8u-backport] RFR: JDK-8191948: jdb error: InvalidTypeException: Can't assign double[][][] to double[][][]

Hi Chris and Serguei, Thanks for the review, I will add the appropriate noreg label. Thanks, Fairoz From: Serguei Spitsyn Sent: Wednesday, July 25, 2018 11:24 PM To: Chris Plummer ; Fairoz Matte ; serviceability-dev@openjdk.java.net Subject: Re: [8u-backport] RFR: JDK-8191948: jdb error: Inva