Re: RFR: JDK-8212028: Use run-test makefile framework for testing in Oracle's Mach5

Hi Erik, Thank you for preserving through this, so we finally can move to 100% run-test! On 2018-10-12 00:29, Erik Joelsson wrote: Hello, (adding serviceability-dev and hotspot-dev for test changes) Bug: https://bugs.openjdk.java.net/browse/JDK-8212028 Webrev: http://cr.openjdk.java.net/~

Re: Backport 8195115: G1 Old Gen MemoryPool CollectionUsage.used values don't reflect mixed GC results

Thanks for the review, new webrev at http://cr.openjdk.java.net/~phh/8195115/webrev.06/. The different requires were an artifact of me trying to get TestOldGenCollectionUsage.java to run. Good catch. Jiangli changed the heap size to 14m to get it to work with CDS, see https://bugs.openjdk.java

Re: RFR: JDK-8212028: Use run-test makefile framework for testing in Oracle's Mach5

On 2018-10-12 01:37, Magnus Ihse Bursie wrote: Hi Erik, Thank you for preserving through this, so we finally can move to 100% run-test! On 2018-10-12 00:29, Erik Joelsson wrote: Hello, (adding serviceability-dev and hotspot-dev for test changes) Bug: https://bugs.openjdk.java.net/browse

Re: RFR 8211736: jdb doesn't print prompt when breakpoint is hit and suspend policy is STOP_EVENT_THREAD

Hi Daniil, 1) +1 for printCurrentLocation when suspendPolicy != SUSPEND_ALL 2) wrong indent in JdbStopThreadTest.java: 36 import lib.jdb.JdbCommand; 37 import lib.jdb.JdbTest; 3) I think it would be better to make waitForSimplePrompt property of JdbCommand (like JdbCommand.

Re: RFR: JDK-8212028: Use run-test makefile framework for testing in Oracle's Mach5

> 12 okt. 2018 kl. 18:16 skrev Erik Joelsson : > > >> On 2018-10-12 01:37, Magnus Ihse Bursie wrote: >> Hi Erik, >> >> Thank you for preserving through this, so we finally can move to 100% >> run-test! >> >>> On 2018-10-12 00:29, Erik Joelsson wrote: >>> >>> Hello, >>> >>> (adding servicea

Re: RFR 8211736: jdb doesn't print prompt when breakpoint is hit and suspend policy is STOP_EVENT_THREAD

Hi Chris and Alex, Please find below the output of the debug session: ===BEGIN=== jdb ThreadObj Initializing jdb ... > stop thread at ThreadObj:4 Deferring breakpoint ThreadObj:4. It will be set after the class is loaded. > run run ThreadObj Set uncaught java.lang.Throwable Set deferred uncaught j

Re: RFR 8211736: jdb doesn't print prompt when breakpoint is hit and suspend policy is STOP_EVENT_THREAD

Hi Daniil, Thanks for the debug session. I did make me realize one flaw. The "thread" command requires a thread number, but the breakpoint output only includes the thread name. I wonder if we could also include the thread number, although we'd have to be careful not to break any existing test

Re: RFR (L) 8212082: Remove the NSK_CPP_STUB macros from remaining vmTestbase/jvmti/[sS]*

This looks fine. Do the tests run correctly after the transform? paul From: serviceability-dev on behalf of JC Beyler Date: Friday, October 12, 2018 at 4:41 PM To: "serviceability-dev@openjdk.java.net" Subject: RFR (L) 8212082: Remove the NSK_CPP_STUB macros from remaining vmTestbase/jvmti/[

Re: crash in JvmtiExport::post_compiled_method_load

Hi, We have observed the same issue again on Java 10.0+46. I just wanted to share the new error file and the jvm args in case these provide additional information. hs_err file: https://gist.github.com/nezihyigitbasi/912fc3e7f2aff933f5828f5e913dae64 jvm args: https://gist.github.com/nezihyigitbasi/3

Re: crash in JvmtiExport::post_compiled_method_load

Hi Nezih, I've added a comment to the bug report with your details. Thanks! Serguei On 10/12/18 3:28 PM, nezih yigitbasi wrote: Hi, We have observed the same issue again on Java 10.0+46. I just wanted to share the new error file and the jvm args in case these provide additional information.

Re: RFR (L) 8212082: Remove the NSK_CPP_STUB macros from remaining vmTestbase/jvmti/[sS]*

Looks good to me. --alex On 10/12/2018 14:25, JC Beyler wrote: Yes they do, they have run on my dev machine and I'm submitting it on the submit repo (though that will test build and not the tests from what I understood) :) Jc On Fri, Oct 12, 2018 at 2:16 PM Hohensee, Paul